From: Hans Verkuil <hverkuil@xs4all.nl> To: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Tomi Valkeinen <tomi.valkeinen@ti.com>, Hans Verkuil <hans.verkuil@cisco.com> Subject: [PATCH 3/5] adv7842: when the EDID is cleared, unconfigure CEC as well Date: Thu, 4 Oct 2018 11:08:58 +0200 [thread overview] Message-ID: <20181004090900.32915-4-hverkuil@xs4all.nl> (raw) In-Reply-To: <20181004090900.32915-1-hverkuil@xs4all.nl> From: Hans Verkuil <hans.verkuil@cisco.com> When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> --- drivers/media/i2c/adv7842.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 4f8fbdd00e35..71fe56565f75 100644 --- a/drivers/media/i2c/adv7842.c +++ b/drivers/media/i2c/adv7842.c @@ -786,8 +786,10 @@ static int edid_write_hdmi_segment(struct v4l2_subdev *sd, u8 port) /* Disable I2C access to internal EDID ram from HDMI DDC ports */ rep_write_and_or(sd, 0x77, 0xf3, 0x00); - if (!state->hdmi_edid.present) + if (!state->hdmi_edid.present) { + cec_phys_addr_invalidate(state->cec_adap); return 0; + } pa = cec_get_edid_phys_addr(edid, 256, &spa_loc); err = cec_phys_addr_validate(pa, &pa, NULL); -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl> To: linux-media@vger.kernel.org Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, Hans Verkuil <hans.verkuil@cisco.com>, dri-devel@lists.freedesktop.org Subject: [PATCH 3/5] adv7842: when the EDID is cleared, unconfigure CEC as well Date: Thu, 4 Oct 2018 11:08:58 +0200 [thread overview] Message-ID: <20181004090900.32915-4-hverkuil@xs4all.nl> (raw) In-Reply-To: <20181004090900.32915-1-hverkuil@xs4all.nl> From: Hans Verkuil <hans.verkuil@cisco.com> When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> --- drivers/media/i2c/adv7842.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 4f8fbdd00e35..71fe56565f75 100644 --- a/drivers/media/i2c/adv7842.c +++ b/drivers/media/i2c/adv7842.c @@ -786,8 +786,10 @@ static int edid_write_hdmi_segment(struct v4l2_subdev *sd, u8 port) /* Disable I2C access to internal EDID ram from HDMI DDC ports */ rep_write_and_or(sd, 0x77, 0xf3, 0x00); - if (!state->hdmi_edid.present) + if (!state->hdmi_edid.present) { + cec_phys_addr_invalidate(state->cec_adap); return 0; + } pa = cec_get_edid_phys_addr(edid, 256, &spa_loc); err = cec_phys_addr_validate(pa, &pa, NULL); -- 2.18.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-04 16:01 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-04 9:08 [PATCH 0/5] cec/adv/omap: fixes and new status flags Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 1/5] cec: add new tx/rx status bits to detect aborts/timeouts Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 2/5] adv7604: when the EDID is cleared, unconfigure CEC as well Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil [this message] 2018-10-04 9:08 ` [PATCH 3/5] adv7842: " Hans Verkuil 2018-10-04 9:08 ` [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-05 14:13 ` Hans Verkuil 2018-10-05 14:13 ` Hans Verkuil 2018-10-08 12:52 ` Tomi Valkeinen 2018-10-08 12:52 ` Tomi Valkeinen 2018-10-08 12:58 ` Hans Verkuil 2018-10-08 12:58 ` Hans Verkuil 2018-10-08 12:45 ` Tomi Valkeinen 2018-10-08 12:45 ` Tomi Valkeinen 2018-10-08 12:55 ` Hans Verkuil 2018-10-08 12:55 ` Hans Verkuil 2018-10-08 13:03 ` Tomi Valkeinen 2018-10-08 13:03 ` Tomi Valkeinen 2018-10-04 9:09 ` [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Hans Verkuil 2018-10-04 9:09 ` Hans Verkuil 2018-10-08 12:47 ` Tomi Valkeinen 2018-10-08 12:47 ` Tomi Valkeinen 2018-10-08 13:01 ` Hans Verkuil 2018-10-08 13:01 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181004090900.32915-4-hverkuil@xs4all.nl \ --to=hverkuil@xs4all.nl \ --cc=dri-devel@lists.freedesktop.org \ --cc=hans.verkuil@cisco.com \ --cc=linux-media@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.