From: Hans Verkuil <hverkuil@xs4all.nl> To: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Hans Verkuil <hans.verkuil@cisco.com> Subject: Re: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Date: Mon, 8 Oct 2018 15:01:02 +0200 [thread overview] Message-ID: <959571c2-4a0d-87be-2ff3-4417aee152f1@xs4all.nl> (raw) In-Reply-To: <7b609cdf-ff95-f32c-8431-59f04f87de56@ti.com> On 10/08/2018 02:47 PM, Tomi Valkeinen wrote: > On 04/10/18 12:09, Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil@cisco.com> >> >> The HDMI_CEC_DBG_3 register does have a retransmit count, but you >> can't write to it, those bits are read-only. >> >> So drop the attempt to set the retransmit count, since it doesn't >> work. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >> --- >> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> index dee66a5101b5..00407f1995a8 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> @@ -280,9 +280,6 @@ static int hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts, >> hdmi_write_reg(core->base, HDMI_CEC_INT_STATUS_1, >> HDMI_CEC_RETRANSMIT_CNT_INT_MASK); >> >> - /* Set the retry count */ >> - REG_FLD_MOD(core->base, HDMI_CEC_DBG_3, attempts - 1, 6, 4); >> - > > I presume there's no harm in having a different retry count in the HW > than what was requested via the API? Correct. Some CEC HW implementations expect that the software calculates the retry count, but the omap4 does this in hardware (not quite optimally, I'm afraid) and those just ignore the argument. Regards, Hans > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > > Tomi >
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl> To: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-media@vger.kernel.org Cc: Hans Verkuil <hans.verkuil@cisco.com>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Date: Mon, 8 Oct 2018 15:01:02 +0200 [thread overview] Message-ID: <959571c2-4a0d-87be-2ff3-4417aee152f1@xs4all.nl> (raw) In-Reply-To: <7b609cdf-ff95-f32c-8431-59f04f87de56@ti.com> On 10/08/2018 02:47 PM, Tomi Valkeinen wrote: > On 04/10/18 12:09, Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil@cisco.com> >> >> The HDMI_CEC_DBG_3 register does have a retransmit count, but you >> can't write to it, those bits are read-only. >> >> So drop the attempt to set the retransmit count, since it doesn't >> work. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >> --- >> drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> index dee66a5101b5..00407f1995a8 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c >> @@ -280,9 +280,6 @@ static int hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts, >> hdmi_write_reg(core->base, HDMI_CEC_INT_STATUS_1, >> HDMI_CEC_RETRANSMIT_CNT_INT_MASK); >> >> - /* Set the retry count */ >> - REG_FLD_MOD(core->base, HDMI_CEC_DBG_3, attempts - 1, 6, 4); >> - > > I presume there's no harm in having a different retry count in the HW > than what was requested via the API? Correct. Some CEC HW implementations expect that the software calculates the retry count, but the omap4 does this in hardware (not quite optimally, I'm afraid) and those just ignore the argument. Regards, Hans > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > > Tomi > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-08 20:12 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-04 9:08 [PATCH 0/5] cec/adv/omap: fixes and new status flags Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 1/5] cec: add new tx/rx status bits to detect aborts/timeouts Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 2/5] adv7604: when the EDID is cleared, unconfigure CEC as well Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 3/5] adv7842: " Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-04 9:08 ` [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done Hans Verkuil 2018-10-04 9:08 ` Hans Verkuil 2018-10-05 14:13 ` Hans Verkuil 2018-10-05 14:13 ` Hans Verkuil 2018-10-08 12:52 ` Tomi Valkeinen 2018-10-08 12:52 ` Tomi Valkeinen 2018-10-08 12:58 ` Hans Verkuil 2018-10-08 12:58 ` Hans Verkuil 2018-10-08 12:45 ` Tomi Valkeinen 2018-10-08 12:45 ` Tomi Valkeinen 2018-10-08 12:55 ` Hans Verkuil 2018-10-08 12:55 ` Hans Verkuil 2018-10-08 13:03 ` Tomi Valkeinen 2018-10-08 13:03 ` Tomi Valkeinen 2018-10-04 9:09 ` [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Hans Verkuil 2018-10-04 9:09 ` Hans Verkuil 2018-10-08 12:47 ` Tomi Valkeinen 2018-10-08 12:47 ` Tomi Valkeinen 2018-10-08 13:01 ` Hans Verkuil [this message] 2018-10-08 13:01 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=959571c2-4a0d-87be-2ff3-4417aee152f1@xs4all.nl \ --to=hverkuil@xs4all.nl \ --cc=dri-devel@lists.freedesktop.org \ --cc=hans.verkuil@cisco.com \ --cc=linux-media@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.