From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Sudeep Holla <sudeep.holla@arm.com>, Mark Rutland <mark.rutland@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Linux PM <linux-pm@vger.kernel.org>, Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@kernel.org>, Lina Iyer <ilina@codeaurora.org>, Rob Herring <robh+dt@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset) Date: Fri, 5 Oct 2018 11:47:29 +0100 [thread overview] Message-ID: <20181005104729.GB25651@red-moon> (raw) In-Reply-To: <CAPDyKFrWzDU9BsfAnx7uoaXq=gmGg2r46Mn-cJHSWUk-TmyomA@mail.gmail.com> On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > >> > > I don't see any dependency there, so I'll queue up the 1-3 in > >> > > pm-domains and the 4-6 in pm-cpuidle. > >> > > >> > I do not see why we should merge patches 4-6 for v4.20; they add legacy > >> > (DT bindings and related parsing code) with no user in the kernel; we > >> > may still want to tweak them, in particular PSCI DT bindings. > >> > >> My impression was that 4-6 have been agreed on due to the ACKs they > >> carry. I'll drop them if that's not the case. > > > > I have not expressed myself correctly: they have been agreed (even > > though as I said they may require some tweaking) but I see no urgency > > of merging them in v4.20 since they have no user. They contain DT > > bindings, that create ABI/legacy, I think it is better to have code > > that uses them in the kernel before merging them and creating a > > dependency that is not needed. > > There is already code using the new bindings, for the idle states. > Please have look at patch 5, 6 and 11. I had a look before replying and I reiterate the point, there is no reason to merge those patches without the rest of the series, none. There is already a way to describe idle states in the kernel and it works very well, we will add one when we need it not before. > Moreover, you have had plenty on time to look at the series, as those > patches haven't changed since a very long time. So ? > May I suggest you do the review instead, so we can move things > forward, please. The changes in the v9 series should be trivial to > review. There is no reason to merge patches [4, 5, 6, 10] stand-alone, they are not solving any problem and they do not provide any benefit other than adding useless ABI/legacy, they make sense when we look at the whole series. > >> > Likewise, it makes no sense to merge patches 7-8 without the rest of > >> > the PSCI patches. > > Well, those patches are part of this series, because Mark wanted me to > move the files. Is really such a big deal? I think it makes sense, no > matter what happens afterwards. We can merge patches [7-8] even if there is no urgency at all to do so, usually PSCI patches go via arm-soc whose patches queue is now closed and I do not think that's a problem at all. Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset) Date: Fri, 5 Oct 2018 11:47:29 +0100 [thread overview] Message-ID: <20181005104729.GB25651@red-moon> (raw) In-Reply-To: <CAPDyKFrWzDU9BsfAnx7uoaXq=gmGg2r46Mn-cJHSWUk-TmyomA@mail.gmail.com> On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > >> > > I don't see any dependency there, so I'll queue up the 1-3 in > >> > > pm-domains and the 4-6 in pm-cpuidle. > >> > > >> > I do not see why we should merge patches 4-6 for v4.20; they add legacy > >> > (DT bindings and related parsing code) with no user in the kernel; we > >> > may still want to tweak them, in particular PSCI DT bindings. > >> > >> My impression was that 4-6 have been agreed on due to the ACKs they > >> carry. I'll drop them if that's not the case. > > > > I have not expressed myself correctly: they have been agreed (even > > though as I said they may require some tweaking) but I see no urgency > > of merging them in v4.20 since they have no user. They contain DT > > bindings, that create ABI/legacy, I think it is better to have code > > that uses them in the kernel before merging them and creating a > > dependency that is not needed. > > There is already code using the new bindings, for the idle states. > Please have look at patch 5, 6 and 11. I had a look before replying and I reiterate the point, there is no reason to merge those patches without the rest of the series, none. There is already a way to describe idle states in the kernel and it works very well, we will add one when we need it not before. > Moreover, you have had plenty on time to look at the series, as those > patches haven't changed since a very long time. So ? > May I suggest you do the review instead, so we can move things > forward, please. The changes in the v9 series should be trivial to > review. There is no reason to merge patches [4, 5, 6, 10] stand-alone, they are not solving any problem and they do not provide any benefit other than adding useless ABI/legacy, they make sense when we look at the whole series. > >> > Likewise, it makes no sense to merge patches 7-8 without the rest of > >> > the PSCI patches. > > Well, those patches are part of this series, because Mark wanted me to > move the files. Is really such a big deal? I think it makes sense, no > matter what happens afterwards. We can merge patches [7-8] even if there is no urgency at all to do so, usually PSCI patches go via arm-soc whose patches queue is now closed and I do not think that's a problem at all. Lorenzo
next prev parent reply other threads:[~2018-10-05 10:47 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-03 14:38 [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset) Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 01/11] PM / Domains: Don't treat zero found compatible idle states as an error Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 02/11] PM / Domains: Deal with multiple states but no governor in genpd Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 03/11] PM / Domains: Document flags for genpd Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-04 13:48 ` Tony Lindgren 2018-10-04 13:48 ` Tony Lindgren 2018-10-04 14:57 ` Ulf Hansson 2018-10-04 14:57 ` Ulf Hansson 2018-10-04 16:13 ` Tony Lindgren 2018-10-04 16:13 ` Tony Lindgren 2018-10-03 14:38 ` [PATCH v9 04/11] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-10 15:03 ` Sudeep Holla 2018-10-10 15:03 ` Sudeep Holla 2018-10-11 14:44 ` Ulf Hansson 2018-10-11 14:44 ` Ulf Hansson 2018-10-11 16:41 ` Sudeep Holla 2018-10-11 16:41 ` Sudeep Holla 2018-10-12 9:43 ` Ulf Hansson 2018-10-12 9:43 ` Ulf Hansson 2018-10-12 10:13 ` Sudeep Holla 2018-10-12 10:13 ` Sudeep Holla 2018-10-12 10:24 ` Ulf Hansson 2018-10-12 10:24 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 05/11] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-10 15:03 ` Sudeep Holla 2018-10-10 15:03 ` Sudeep Holla 2018-10-11 15:05 ` Ulf Hansson 2018-10-11 15:05 ` Ulf Hansson 2018-10-11 16:01 ` Sudeep Holla 2018-10-11 16:01 ` Sudeep Holla 2018-10-03 14:38 ` [PATCH v9 06/11] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-10 15:03 ` Sudeep Holla 2018-10-10 15:03 ` Sudeep Holla 2018-10-03 14:38 ` [PATCH v9 07/11] drivers: firmware: psci: Move psci to separate directory Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 08/11] MAINTAINERS: Update files for PSCI Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 09/11] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 10/11] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-03 14:38 ` [PATCH v9 11/11] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson 2018-10-03 14:38 ` Ulf Hansson 2018-10-04 8:39 ` [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset) Rafael J. Wysocki 2018-10-04 8:39 ` Rafael J. Wysocki 2018-10-04 8:58 ` Ulf Hansson 2018-10-04 8:58 ` Ulf Hansson 2018-10-04 9:01 ` Rafael J. Wysocki 2018-10-04 9:01 ` Rafael J. Wysocki 2018-10-04 9:32 ` Rafael J. Wysocki 2018-10-04 9:32 ` Rafael J. Wysocki 2018-10-04 10:10 ` Ulf Hansson 2018-10-04 10:10 ` Ulf Hansson 2018-10-04 15:57 ` Lorenzo Pieralisi 2018-10-04 15:57 ` Lorenzo Pieralisi 2018-10-04 17:07 ` Rafael J. Wysocki 2018-10-04 17:07 ` Rafael J. Wysocki 2018-10-04 17:21 ` Lorenzo Pieralisi 2018-10-04 17:21 ` Lorenzo Pieralisi 2018-10-04 18:36 ` Ulf Hansson 2018-10-04 18:36 ` Ulf Hansson 2018-10-04 18:38 ` Ulf Hansson 2018-10-04 18:38 ` Ulf Hansson 2018-10-05 10:47 ` Lorenzo Pieralisi [this message] 2018-10-05 10:47 ` Lorenzo Pieralisi 2018-10-05 11:49 ` Ulf Hansson 2018-10-05 11:49 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181005104729.GB25651@red-moon \ --to=lorenzo.pieralisi@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=geert+renesas@glider.be \ --cc=ilina@codeaurora.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.