Re: [PATCH] Typo `dashes ?` -> `dashes?`

From: Jeff King <peff@peff.net>
To: Jacques Bodin-Hullin <j.bodinhullin@monsieurbiz.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Typo `dashes ?` -> `dashes?`
Date: Mon, 15 Oct 2018 13:20:41 -0400	[thread overview]
Message-ID: <20181015172041.GC1301@sigill.intra.peff.net> (raw)
In-Reply-To: <01020166741c381f-bd183f7f-725d-4b4f-9f5f-804560b2b00b-000000@eu-west-1.amazonses.com>

On Sun, Oct 14, 2018 at 07:44:58PM +0000, Jacques Bodin-Hullin wrote:

> diff --git a/parse-options.c b/parse-options.c
> index 3b874a83a0c89..88512212392ae 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -352,7 +352,7 @@ static void check_typos(const char *arg, const struct option *options)
>  		return;
>  
>  	if (starts_with(arg, "no-")) {
> -		error ("did you mean `--%s` (with two dashes ?)", arg);
> +		error ("did you mean `--%s` (with two dashes?)", arg);

I agree the extra space in the original is stylistically weird, and your
suggestion is an improvement. However, I think this is really a question
"did you mean..." with a parenthetical phrase. Most style guides would
recommend putting the punctuation outside, like:

  error: did you mean `--foo` (with two dashes)?

Speaking of style, the extra space between "error" and "(" does not
match our usual coding style. It might be worth removing while we're
touching these lines.

-Peff