Re: [PATCH] parse-options: lose an unnecessary space in an error message

From: Junio C Hamano <gitster@pobox.com>
To: Jacques Bodin-Hullin <j.bodinhullin@monsieurbiz.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] parse-options: lose an unnecessary space in an error message
Date: Wed, 05 Feb 2020 10:49:10 -0800	[thread overview]
Message-ID: <xmqqv9ok6fa1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <0102017015765b98-e2e26f61-dd07-4a32-a72f-2d7b2159fffe-000000@eu-west-1.amazonses.com> (Jacques Bodin-Hullin's message of "Wed, 5 Feb 2020 13:07:23 +0000")

Jacques Bodin-Hullin <j.bodinhullin@monsieurbiz.com> writes:

> Signed-off-by: Jacques Bodin-Hullin <j.bodinhullin@monsieurbiz.com>
> ---
>  parse-options.c          | 4 ++--
>  t/t0040-parse-options.sh | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/parse-options.c b/parse-options.c
> index b42f54d48b96c..71dbe84d896b4 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -420,7 +420,7 @@ static void check_typos(const char *arg, const struct option *options)
>  		return;
>  
>  	if (starts_with(arg, "no-")) {
> -		error(_("did you mean `--%s` (with two dashes ?)"), arg);
> +		error(_("did you mean `--%s` (with two dashes)?"), arg);

Makes sense.  Not just there is an extra SP before the question
mark, the question mark is about the whole sentence, so pushing
it out of the parentheses also is a good change.

We might even want to lose the parentheses altogether, i.e.

	did you mean `--%s` with two dashes?

Hmm?

Thanks.