From: Jeff King <peff@peff.net>
To: Jacques Bodin-Hullin <j.bodinhullin@monsieurbiz.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Typo `dashes ?` -> `dashes?`
Date: Wed, 17 Oct 2018 04:23:22 -0400 [thread overview]
Message-ID: <20181017082321.GA31932@sigill.intra.peff.net> (raw)
In-Reply-To: <CAAwZSqAk+D-6y9ArT_tAychwLnNUANinLPYX-ciXJDmyv+J7FA@mail.gmail.com>
On Mon, Oct 15, 2018 at 09:31:54PM +0200, Jacques Bodin-Hullin wrote:
> I've just updated the PR with the `error(` change.
>
> Also I did the change for the question mark at the end, because you are
> right, when we read it, it sounds better.
>
> Do I need to put back the patch in this thread? It's here:
> https://patch-diff.githubusercontent.com/raw/git/git/pull/540.patch
The commit looks good, though you may want to expand the commit message
a little (it's not really a typo, but more of a style fix).
The next step would normally be to send the patch to the list (ideally
in this thread), with "[PATCH v2]" in the subject.
It looks like you're using SubmitGit. I don't remember offhand how it
works for sending re-rolls like this, but I think it's possible. If you
run into trouble, you might try instead using GitGitGadget, which is a
similar PR->mail gateway that is a little more featureful:
https://github.com/gitgitgadget/gitgitgadget
-Peff
next prev parent reply other threads:[~2018-10-17 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 19:44 [PATCH] Typo `dashes ?` -> `dashes?` Jacques Bodin-Hullin
2018-10-15 17:20 ` Jeff King
[not found] ` <CAAwZSqAk+D-6y9ArT_tAychwLnNUANinLPYX-ciXJDmyv+J7FA@mail.gmail.com>
2018-10-17 8:23 ` Jeff King [this message]
2018-11-16 22:58 ` [PATCH-2] Change writing style Jacques Bodin-Hullin
2018-11-17 9:04 ` Junio C Hamano
2020-02-05 13:07 ` [PATCH] parse-options: lose an unnecessary space in an error message Jacques Bodin-Hullin
2020-02-05 18:49 ` Junio C Hamano
2020-02-05 20:11 ` Jacques Bodin-Hullin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017082321.GA31932@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.bodinhullin@monsieurbiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.