Re: [PATCH 5/5] ARM: actions: remove boot_lock and pen_release - Russell King

From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linus.walleij@linaro.org,
	linux-actions@lists.infradead.org,
	"Andreas Färber" <afaerber@suse.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: actions: remove boot_lock and pen_release
Date: Thu, 13 Dec 2018 12:04:56 +0000	[thread overview]
Message-ID: <20181213120456.GP30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181213120153.GA18173@mani>

On Thu, Dec 13, 2018 at 05:31:53PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Dec 13, 2018 at 11:55:57AM +0000, Russell King wrote:
> > The actions SMP implementation has several issues:
> > 
> > 1. pen_release is only ever read and compared to -1, and is defined in
> >    arch/arm/kernel/smp.c to be -1.  This test will always succeed.
> > 
> > 2. we are already guaranteed to be single threaded while bringing up a
> >    CPU, so the spinlock makes no sense, remove it.
> > 
> > 3. owl_secondary_startup() is not referenced nor defined, the prototype
> >    is redundant, remove it.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Hi Russel,
> 
> Is this patch a superset of https://www.spinics.net/lists/arm-kernel/msg694546.html?

Probably not, I couldn't find which platform Linus had already done in
my mailbox, so I just did those that I could see in the kernel tree.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up