All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	"Russell King" <rmk+kernel@armlinux.org.uk>,
	linux-actions@lists.infradead.org,
	"Andreas Färber" <afaerber@suse.de>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] ARM: actions: remove boot_lock and pen_release
Date: Fri, 11 Jan 2019 09:19:54 +0100	[thread overview]
Message-ID: <CACRpkdakqbVprrHgO01i_uSXsFa5=HXtzBu5qiVmW5twQ84PmQ@mail.gmail.com> (raw)
In-Reply-To: <20181213120153.GA18173@mani>

On Thu, Dec 13, 2018 at 1:02 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> On Thu, Dec 13, 2018 at 11:55:57AM +0000, Russell King wrote:
> > The actions SMP implementation has several issues:
> >
> > 1. pen_release is only ever read and compared to -1, and is defined in
> >    arch/arm/kernel/smp.c to be -1.  This test will always succeed.
> >
> > 2. we are already guaranteed to be single threaded while bringing up a
> >    CPU, so the spinlock makes no sense, remove it.
> >
> > 3. owl_secondary_startup() is not referenced nor defined, the prototype
> >    is redundant, remove it.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Hi Russel,
>
> Is this patch a superset of https://www.spinics.net/lists/arm-kernel/msg694546.html?

Please apply Russell's patch first, I can easily apply my refactorings on
top later.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	"Russell King" <rmk+kernel@armlinux.org.uk>,
	linux-actions@lists.infradead.org,
	"Andreas Färber" <afaerber@suse.de>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] ARM: actions: remove boot_lock and pen_release
Date: Fri, 11 Jan 2019 09:19:54 +0100	[thread overview]
Message-ID: <CACRpkdakqbVprrHgO01i_uSXsFa5=HXtzBu5qiVmW5twQ84PmQ@mail.gmail.com> (raw)
In-Reply-To: <20181213120153.GA18173@mani>

On Thu, Dec 13, 2018 at 1:02 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> On Thu, Dec 13, 2018 at 11:55:57AM +0000, Russell King wrote:
> > The actions SMP implementation has several issues:
> >
> > 1. pen_release is only ever read and compared to -1, and is defined in
> >    arch/arm/kernel/smp.c to be -1.  This test will always succeed.
> >
> > 2. we are already guaranteed to be single threaded while bringing up a
> >    CPU, so the spinlock makes no sense, remove it.
> >
> > 3. owl_secondary_startup() is not referenced nor defined, the prototype
> >    is redundant, remove it.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Hi Russel,
>
> Is this patch a superset of https://www.spinics.net/lists/arm-kernel/msg694546.html?

Please apply Russell's patch first, I can easily apply my refactorings on
top later.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-11  8:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 11:55 [PATCH 5/5] ARM: actions: remove boot_lock and pen_release Russell King
2018-12-13 11:55 ` Russell King
2018-12-13 12:01 ` Manivannan Sadhasivam
2018-12-13 12:01   ` Manivannan Sadhasivam
2018-12-13 12:04   ` Russell King - ARM Linux
2018-12-13 12:04     ` Russell King - ARM Linux
2019-01-11  8:19   ` Linus Walleij [this message]
2019-01-11  8:19     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdakqbVprrHgO01i_uSXsFa5=HXtzBu5qiVmW5twQ84PmQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=afaerber@suse.de \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.