From: Rob Herring <robh@kernel.org> To: Loys Ollivier <lollivier@baylibre.com> Cc: devicetree@vger.kernel.org, Johan Hovold <johan@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: gnss: add gtop binding Date: Fri, 11 Jan 2019 08:43:30 -0600 [thread overview] Message-ID: <20190111144330.GA30111@bogus> (raw) In-Reply-To: <1545994235-8309-3-git-send-email-lollivier@baylibre.com> On Fri, Dec 28, 2018 at 11:50:33AM +0100, Loys Ollivier wrote: > Add binding for GlobalTop GNSS receivers. > > Signed-off-by: Loys Ollivier <lollivier@baylibre.com> > --- > Documentation/devicetree/bindings/gnss/gtop.txt | 33 +++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gnss/gtop.txt > > diff --git a/Documentation/devicetree/bindings/gnss/gtop.txt b/Documentation/devicetree/bindings/gnss/gtop.txt > new file mode 100644 > index 000000000000..24c86703aa46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gnss/gtop.txt > @@ -0,0 +1,33 @@ > +GlobalTop GNSS Receiver DT binding > + > +The GlobalTop GNSS receivers uses UART interfaces. > + > +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic > +properties. > + > +Required properties: > + > +- compatible : Must be > + > + "globaltop,pa6h" > + > +- vcc-supply : Main voltage regulator > + > +Optional properties: > + > +- timepulse-gpios : Time pulse GPIO > +- v-bckp-supply : Backup voltage regulator > + > +Example: > + > +&uart_A { > + status = "okay"; Don't show status in examples. > + pinctrl-0 = <&uart_a_pins>; > + pinctrl-names = "default"; > + > + gnss { > + compatible = "globaltop,pa6h"; > + vcc-supply = <&vcc_3v3>; > + current-speed = <9600>; Shouldn't the driver know what speed the device operates at? If you do use this, then it needs to be documented as to when it is needed. > + }; > +}; > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Loys Ollivier <lollivier@baylibre.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>, Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: gnss: add gtop binding Date: Fri, 11 Jan 2019 08:43:30 -0600 [thread overview] Message-ID: <20190111144330.GA30111@bogus> (raw) In-Reply-To: <1545994235-8309-3-git-send-email-lollivier@baylibre.com> On Fri, Dec 28, 2018 at 11:50:33AM +0100, Loys Ollivier wrote: > Add binding for GlobalTop GNSS receivers. > > Signed-off-by: Loys Ollivier <lollivier@baylibre.com> > --- > Documentation/devicetree/bindings/gnss/gtop.txt | 33 +++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gnss/gtop.txt > > diff --git a/Documentation/devicetree/bindings/gnss/gtop.txt b/Documentation/devicetree/bindings/gnss/gtop.txt > new file mode 100644 > index 000000000000..24c86703aa46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gnss/gtop.txt > @@ -0,0 +1,33 @@ > +GlobalTop GNSS Receiver DT binding > + > +The GlobalTop GNSS receivers uses UART interfaces. > + > +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic > +properties. > + > +Required properties: > + > +- compatible : Must be > + > + "globaltop,pa6h" > + > +- vcc-supply : Main voltage regulator > + > +Optional properties: > + > +- timepulse-gpios : Time pulse GPIO > +- v-bckp-supply : Backup voltage regulator > + > +Example: > + > +&uart_A { > + status = "okay"; Don't show status in examples. > + pinctrl-0 = <&uart_a_pins>; > + pinctrl-names = "default"; > + > + gnss { > + compatible = "globaltop,pa6h"; > + vcc-supply = <&vcc_3v3>; > + current-speed = <9600>; Shouldn't the driver know what speed the device operates at? If you do use this, then it needs to be documented as to when it is needed. > + }; > +}; > -- > 2.7.4 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-11 14:45 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-28 10:50 [PATCH 0/4] Add driver for globaltop GNSS receivers Loys Ollivier 2018-12-28 10:50 ` Loys Ollivier 2018-12-28 10:50 ` [PATCH 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier 2018-12-28 10:50 ` Loys Ollivier 2019-01-11 14:40 ` Rob Herring 2019-01-11 14:40 ` Rob Herring 2018-12-28 10:50 ` [PATCH 2/4] dt-bindings: gnss: add gtop binding Loys Ollivier 2018-12-28 10:50 ` Loys Ollivier 2019-01-11 14:43 ` Rob Herring [this message] 2019-01-11 14:43 ` Rob Herring 2018-12-28 10:50 ` [PATCH 3/4] gnss: add gtop receiver type support Loys Ollivier 2018-12-28 10:50 ` Loys Ollivier 2018-12-28 10:50 ` [PATCH 4/4] gnss: add driver for globaltop receivers Loys Ollivier 2018-12-28 10:50 ` Loys Ollivier 2019-01-03 16:04 ` [PATCH 0/4] Add driver for globaltop GNSS receivers Loys Ollivier 2019-01-03 16:04 ` Loys Ollivier 2019-01-04 9:19 ` Johan Hovold 2019-01-04 9:19 ` Johan Hovold 2019-01-07 16:21 ` Loys Ollivier 2019-01-07 16:21 ` Loys Ollivier 2019-01-07 16:37 ` Johan Hovold 2019-01-07 16:37 ` Johan Hovold 2019-01-04 17:51 ` Rob Herring 2019-01-04 17:51 ` Rob Herring 2019-01-15 10:00 ` Loys Ollivier 2019-01-15 10:00 ` Loys Ollivier 2019-01-15 10:00 ` Loys Ollivier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190111144330.GA30111@bogus \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=johan@kernel.org \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lollivier@baylibre.com \ --cc=mark.rutland@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.