From: Bjorn Helgaas <helgaas@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>, g@google.com
Cc: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kselftest@vger.kernel.org, Jon Mason <jdmason@kudzu.us>,
Joerg Roedel <joro@8bytes.org>, Allen Hubbe <allenbh@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Eric Pilmore <epilmore@gigaio.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 2/9] PCI/MSI: Support allocating virtual MSI interrupts
Date: Fri, 1 Feb 2019 13:23:23 -0600 [thread overview]
Message-ID: <20190201192323.GS229773@google.com> (raw)
In-Reply-To: <74993e67-cdc5-234a-d26c-5c0177a0299a@deltatee.com>
On Thu, Jan 31, 2019 at 03:52:09PM -0700, Logan Gunthorpe wrote:
> On 2019-01-31 3:39 p.m., Bjorn Helgaas wrote:
> >> diff --git a/include/linux/msi.h b/include/linux/msi.h
> >> index 784fb52b9900..6458ab049852 100644
> >> --- a/include/linux/msi.h
> >> +++ b/include/linux/msi.h
> >> @@ -88,6 +88,7 @@ struct msi_desc {
> >> __u8 multi_cap : 3;
> >> __u8 maskbit : 1;
> >> __u8 is_64 : 1;
> >> + __u8 is_virtual : 1;
> >
> > You did the right thing by using the same style as what's already
> > here, but does anybody know why are we using __u8 and __u16 here?
> >
> > Those typedefs are in include/uapi/asm-generic/int-l64.h, which
> > suggests they're for things exported to user space, but I don't think
> > that's the case here, so I'm wondering if we could someday replace
> > these with u8 and u16. Obviously that wouldn't be part of *this*
> > series.
>
> Yes, I was also confused by this. But I always follow the "when-in-rome"
> rule.
Thanks for following the "when-in-rome" rule. That seems so obvious
that it wouldn't even need to be written down, but it is often
ignored.
> My understanding is the same as yours is that __u8 should be used
> for userspace compatibility which doesn't apply here. If there is
> consensus on this being wrong, I'd be happy to write a cleanup patch
> that fixes it separate from this series.
That'd be awesome. There are also a couple more in pci-driver.c that
could be fixed at the same time.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: helgaas at kernel.org (Bjorn Helgaas)
Subject: [PATCH 2/9] PCI/MSI: Support allocating virtual MSI interrupts
Date: Fri, 1 Feb 2019 13:23:23 -0600 [thread overview]
Message-ID: <20190201192323.GS229773@google.com> (raw)
In-Reply-To: <74993e67-cdc5-234a-d26c-5c0177a0299a@deltatee.com>
On Thu, Jan 31, 2019 at 03:52:09PM -0700, Logan Gunthorpe wrote:
> On 2019-01-31 3:39 p.m., Bjorn Helgaas wrote:
> >> diff --git a/include/linux/msi.h b/include/linux/msi.h
> >> index 784fb52b9900..6458ab049852 100644
> >> --- a/include/linux/msi.h
> >> +++ b/include/linux/msi.h
> >> @@ -88,6 +88,7 @@ struct msi_desc {
> >> __u8 multi_cap : 3;
> >> __u8 maskbit : 1;
> >> __u8 is_64 : 1;
> >> + __u8 is_virtual : 1;
> >
> > You did the right thing by using the same style as what's already
> > here, but does anybody know why are we using __u8 and __u16 here?
> >
> > Those typedefs are in include/uapi/asm-generic/int-l64.h, which
> > suggests they're for things exported to user space, but I don't think
> > that's the case here, so I'm wondering if we could someday replace
> > these with u8 and u16. Obviously that wouldn't be part of *this*
> > series.
>
> Yes, I was also confused by this. But I always follow the "when-in-rome"
> rule.
Thanks for following the "when-in-rome" rule. That seems so obvious
that it wouldn't even need to be written down, but it is often
ignored.
> My understanding is the same as yours is that __u8 should be used
> for userspace compatibility which doesn't apply here. If there is
> consensus on this being wrong, I'd be happy to write a cleanup patch
> that fixes it separate from this series.
That'd be awesome. There are also a couple more in pci-driver.c that
could be fixed at the same time.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
Subject: [PATCH 2/9] PCI/MSI: Support allocating virtual MSI interrupts
Date: Fri, 1 Feb 2019 13:23:23 -0600 [thread overview]
Message-ID: <20190201192323.GS229773@google.com> (raw)
Message-ID: <20190201192323.gEauakk3mrprrTUtlI9skgjIWVhiTgKp7VH-LbK-fKA@z> (raw)
In-Reply-To: <74993e67-cdc5-234a-d26c-5c0177a0299a@deltatee.com>
On Thu, Jan 31, 2019@03:52:09PM -0700, Logan Gunthorpe wrote:
> On 2019-01-31 3:39 p.m., Bjorn Helgaas wrote:
> >> diff --git a/include/linux/msi.h b/include/linux/msi.h
> >> index 784fb52b9900..6458ab049852 100644
> >> --- a/include/linux/msi.h
> >> +++ b/include/linux/msi.h
> >> @@ -88,6 +88,7 @@ struct msi_desc {
> >> __u8 multi_cap : 3;
> >> __u8 maskbit : 1;
> >> __u8 is_64 : 1;
> >> + __u8 is_virtual : 1;
> >
> > You did the right thing by using the same style as what's already
> > here, but does anybody know why are we using __u8 and __u16 here?
> >
> > Those typedefs are in include/uapi/asm-generic/int-l64.h, which
> > suggests they're for things exported to user space, but I don't think
> > that's the case here, so I'm wondering if we could someday replace
> > these with u8 and u16. Obviously that wouldn't be part of *this*
> > series.
>
> Yes, I was also confused by this. But I always follow the "when-in-rome"
> rule.
Thanks for following the "when-in-rome" rule. That seems so obvious
that it wouldn't even need to be written down, but it is often
ignored.
> My understanding is the same as yours is that __u8 should be used
> for userspace compatibility which doesn't apply here. If there is
> consensus on this being wrong, I'd be happy to write a cleanup patch
> that fixes it separate from this series.
That'd be awesome. There are also a couple more in pci-driver.c that
could be fixed at the same time.
Bjorn
next prev parent reply other threads:[~2019-02-01 19:23 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:56 [PATCH 0/9] Support using MSI interrupts in ntb_transport Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-02-01 16:44 ` Joerg Roedel
2019-02-01 16:44 ` Joerg Roedel
2019-02-01 16:44 ` joro
2019-02-01 17:27 ` Logan Gunthorpe
2019-02-01 17:27 ` Logan Gunthorpe
2019-02-01 17:27 ` logang
2019-02-05 19:19 ` Jacob Pan
2019-02-05 19:19 ` Jacob Pan
2019-02-05 19:19 ` jacob.jun.pan
2019-02-05 20:40 ` Logan Gunthorpe
2019-02-05 20:40 ` Logan Gunthorpe
2019-02-05 20:40 ` logang
2019-02-05 23:58 ` Jacob Pan
2019-02-05 23:58 ` Jacob Pan
2019-02-05 23:58 ` jacob.jun.pan
2019-01-31 18:56 ` [PATCH 2/9] PCI/MSI: Support allocating virtual MSI interrupts Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 22:39 ` Bjorn Helgaas
2019-01-31 22:39 ` Bjorn Helgaas
2019-01-31 22:39 ` helgaas
2019-01-31 22:52 ` Logan Gunthorpe
2019-01-31 22:52 ` Logan Gunthorpe
2019-01-31 22:52 ` logang
2019-02-01 19:23 ` Bjorn Helgaas [this message]
2019-02-01 19:23 ` Bjorn Helgaas
2019-02-01 19:23 ` helgaas
2019-01-31 18:56 ` [PATCH 3/9] PCI/switchtec: Add module parameter to request more interrupts Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 4/9] NTB: Introduce functions to calculate multi-port resource index Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 5/9] NTB: Rename ntb.c to support multiple source files in the module Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 6/9] NTB: Introduce MSI library Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 7/9] NTB: Introduce NTB MSI Test Client Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 8/9] NTB: Add ntb_msi_test support to ntb_test Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 18:56 ` [PATCH 9/9] NTB: Add MSI interrupt support to ntb_transport Logan Gunthorpe
2019-01-31 18:56 ` Logan Gunthorpe
2019-01-31 18:56 ` logang
2019-01-31 20:20 ` [PATCH 0/9] Support using MSI interrupts in ntb_transport Dave Jiang
2019-01-31 20:20 ` Dave Jiang
2019-01-31 20:20 ` dave.jiang
2019-01-31 20:48 ` Logan Gunthorpe
2019-01-31 20:48 ` Logan Gunthorpe
2019-01-31 20:48 ` logang
2019-01-31 20:58 ` Dave Jiang
2019-01-31 20:58 ` Dave Jiang
2019-01-31 20:58 ` Dave Jiang
2019-01-31 20:58 ` dave.jiang
2019-01-31 22:39 ` Logan Gunthorpe
2019-01-31 22:39 ` Logan Gunthorpe
2019-01-31 22:39 ` Logan Gunthorpe
2019-01-31 22:39 ` logang
2019-01-31 22:46 ` Dave Jiang
2019-01-31 22:46 ` Dave Jiang
2019-01-31 22:46 ` Dave Jiang
2019-01-31 22:46 ` dave.jiang
2019-01-31 23:41 ` Logan Gunthorpe
2019-01-31 23:41 ` Logan Gunthorpe
2019-01-31 23:41 ` logang
2019-01-31 23:48 ` Dave Jiang
2019-01-31 23:48 ` Dave Jiang
2019-01-31 23:48 ` dave.jiang
2019-01-31 23:52 ` Logan Gunthorpe
2019-01-31 23:52 ` Logan Gunthorpe
2019-01-31 23:52 ` logang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201192323.GS229773@google.com \
--to=helgaas@kernel.org \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=epilmore@gigaio.com \
--cc=fancer.lancer@gmail.com \
--cc=g@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jdmason@kudzu.us \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.