From: Boris Brezillon <bbrezillon@kernel.org>
To: <Tudor.Ambarus@microchip.com>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<alexandre.belloni@bootlin.com>, <linux-kernel@vger.kernel.org>,
<Cyrille.Pitchen@microchip.com>, <Nicolas.Ferre@microchip.com>,
<robh+dt@kernel.org>, <linux-spi@vger.kernel.org>,
<Ludovic.Desroches@microchip.com>, <broonie@kernel.org>,
<linux-mtd@lists.infradead.org>, <bugalski.piotr@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses
Date: Sat, 2 Feb 2019 14:23:37 +0100 [thread overview]
Message-ID: <20190202142337.3c51947e@bbrezillon> (raw)
In-Reply-To: <53c9f4b2-7022-e13d-65a4-2e1bed4d76b1@microchip.com>
On Sat, 2 Feb 2019 08:44:27 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 02/02/2019 09:11 AM, Boris Brezillon wrote:
> > On Sat, 2 Feb 2019 04:07:19 +0000
> > <Tudor.Ambarus@microchip.com> wrote:
> >
> >> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> The wrappers hid that the accesses are relaxed. Drop them.
> >>
> >> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> ---
> >> v3: no change
> >> v2: new patch
> >>
> >> drivers/spi/atmel-quadspi.c | 47 +++++++++++++++++++--------------------------
> >> 1 file changed, 20 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> >> index feeddcb25e1f..131374db0db4 100644
> >> --- a/drivers/spi/atmel-quadspi.c
> >> +++ b/drivers/spi/atmel-quadspi.c
> >> @@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = {
> >> { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD },
> >> };
> >>
> >> -/* Register access functions */
> >> -static inline u32 qspi_readl(struct atmel_qspi *aq, u32 reg)
> >> -{
> >> - return readl_relaxed(aq->regs + reg);
> >> -}
> >> -
> >> -static inline void qspi_writel(struct atmel_qspi *aq, u32 reg, u32 value)
> >> -{
> >> - writel_relaxed(value, aq->regs + reg);
> >> -}
> >> -
> >> static inline bool is_compatible(const struct spi_mem_op *op,
> >> const struct qspi_mode *mode)
> >> {
> >> @@ -229,6 +218,7 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,
> >> static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >> {
> >> struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
> >> + void __iomem *base = aq->regs;
> >
> > Can we name this variable regs instead of base or even get rid of it
> > and dereference aq->regs in the xxx_relaxed() calls (doesn't look like
> > the lines would be over 80 chars even when doing that). With this
> > addressed, you can add:
> >
> > Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
>
> I chose to introduce the "base" variable when I have at least 2 dereferences in
> a function, as an optimization. In exec_op() for example, there are 6
> dereferences of aq->reqs. Why do you prefer keeping aq->regs?
I tend to not add local variables unless they help improve readability
or optimize things. In this case, I'd expect the compiler to be smart
enough to detect that aq->reqs is used several times and store it in a
register. When it comes to readability, I don't think it improve
things, but that's probably a matter of taste.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: Tudor.Ambarus@microchip.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Ludovic.Desroches@microchip.com, Cyrille.Pitchen@microchip.com,
linux-mtd@lists.infradead.org, bugalski.piotr@gmail.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses
Date: Sat, 2 Feb 2019 14:23:37 +0100 [thread overview]
Message-ID: <20190202142337.3c51947e@bbrezillon> (raw)
In-Reply-To: <53c9f4b2-7022-e13d-65a4-2e1bed4d76b1@microchip.com>
On Sat, 2 Feb 2019 08:44:27 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 02/02/2019 09:11 AM, Boris Brezillon wrote:
> > On Sat, 2 Feb 2019 04:07:19 +0000
> > <Tudor.Ambarus@microchip.com> wrote:
> >
> >> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> The wrappers hid that the accesses are relaxed. Drop them.
> >>
> >> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> ---
> >> v3: no change
> >> v2: new patch
> >>
> >> drivers/spi/atmel-quadspi.c | 47 +++++++++++++++++++--------------------------
> >> 1 file changed, 20 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> >> index feeddcb25e1f..131374db0db4 100644
> >> --- a/drivers/spi/atmel-quadspi.c
> >> +++ b/drivers/spi/atmel-quadspi.c
> >> @@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = {
> >> { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD },
> >> };
> >>
> >> -/* Register access functions */
> >> -static inline u32 qspi_readl(struct atmel_qspi *aq, u32 reg)
> >> -{
> >> - return readl_relaxed(aq->regs + reg);
> >> -}
> >> -
> >> -static inline void qspi_writel(struct atmel_qspi *aq, u32 reg, u32 value)
> >> -{
> >> - writel_relaxed(value, aq->regs + reg);
> >> -}
> >> -
> >> static inline bool is_compatible(const struct spi_mem_op *op,
> >> const struct qspi_mode *mode)
> >> {
> >> @@ -229,6 +218,7 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,
> >> static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >> {
> >> struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
> >> + void __iomem *base = aq->regs;
> >
> > Can we name this variable regs instead of base or even get rid of it
> > and dereference aq->regs in the xxx_relaxed() calls (doesn't look like
> > the lines would be over 80 chars even when doing that). With this
> > addressed, you can add:
> >
> > Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
>
> I chose to introduce the "base" variable when I have at least 2 dereferences in
> a function, as an optimization. In exec_op() for example, there are 6
> dereferences of aq->reqs. Why do you prefer keeping aq->regs?
I tend to not add local variables unless they help improve readability
or optimize things. In this case, I'd expect the compiler to be smart
enough to detect that aq->reqs is used several times and store it in a
register. When it comes to readability, I don't think it improve
things, but that's probably a matter of taste.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: <Tudor.Ambarus@microchip.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Ludovic.Desroches@microchip.com, Cyrille.Pitchen@microchip.com,
linux-mtd@lists.infradead.org, bugalski.piotr@gmail.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses
Date: Sat, 2 Feb 2019 14:23:37 +0100 [thread overview]
Message-ID: <20190202142337.3c51947e@bbrezillon> (raw)
In-Reply-To: <53c9f4b2-7022-e13d-65a4-2e1bed4d76b1@microchip.com>
On Sat, 2 Feb 2019 08:44:27 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 02/02/2019 09:11 AM, Boris Brezillon wrote:
> > On Sat, 2 Feb 2019 04:07:19 +0000
> > <Tudor.Ambarus@microchip.com> wrote:
> >
> >> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> The wrappers hid that the accesses are relaxed. Drop them.
> >>
> >> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> ---
> >> v3: no change
> >> v2: new patch
> >>
> >> drivers/spi/atmel-quadspi.c | 47 +++++++++++++++++++--------------------------
> >> 1 file changed, 20 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> >> index feeddcb25e1f..131374db0db4 100644
> >> --- a/drivers/spi/atmel-quadspi.c
> >> +++ b/drivers/spi/atmel-quadspi.c
> >> @@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = {
> >> { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD },
> >> };
> >>
> >> -/* Register access functions */
> >> -static inline u32 qspi_readl(struct atmel_qspi *aq, u32 reg)
> >> -{
> >> - return readl_relaxed(aq->regs + reg);
> >> -}
> >> -
> >> -static inline void qspi_writel(struct atmel_qspi *aq, u32 reg, u32 value)
> >> -{
> >> - writel_relaxed(value, aq->regs + reg);
> >> -}
> >> -
> >> static inline bool is_compatible(const struct spi_mem_op *op,
> >> const struct qspi_mode *mode)
> >> {
> >> @@ -229,6 +218,7 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,
> >> static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >> {
> >> struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
> >> + void __iomem *base = aq->regs;
> >
> > Can we name this variable regs instead of base or even get rid of it
> > and dereference aq->regs in the xxx_relaxed() calls (doesn't look like
> > the lines would be over 80 chars even when doing that). With this
> > addressed, you can add:
> >
> > Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
>
> I chose to introduce the "base" variable when I have at least 2 dereferences in
> a function, as an optimization. In exec_op() for example, there are 6
> dereferences of aq->reqs. Why do you prefer keeping aq->regs?
I tend to not add local variables unless they help improve readability
or optimize things. In this case, I'd expect the compiler to be smart
enough to detect that aq->reqs is used several times and store it in a
register. When it comes to readability, I don't think it improve
things, but that's probably a matter of taste.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: <Tudor.Ambarus@microchip.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Nicolas.Ferre@microchip.com, Ludovic.Desroches@microchip.com,
Cyrille.Pitchen@microchip.com, linux-mtd@lists.infradead.org,
bugalski.piotr@gmail.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses
Date: Sat, 2 Feb 2019 14:23:37 +0100 [thread overview]
Message-ID: <20190202142337.3c51947e@bbrezillon> (raw)
In-Reply-To: <53c9f4b2-7022-e13d-65a4-2e1bed4d76b1@microchip.com>
On Sat, 2 Feb 2019 08:44:27 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 02/02/2019 09:11 AM, Boris Brezillon wrote:
> > On Sat, 2 Feb 2019 04:07:19 +0000
> > <Tudor.Ambarus@microchip.com> wrote:
> >
> >> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> The wrappers hid that the accesses are relaxed. Drop them.
> >>
> >> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> ---
> >> v3: no change
> >> v2: new patch
> >>
> >> drivers/spi/atmel-quadspi.c | 47 +++++++++++++++++++--------------------------
> >> 1 file changed, 20 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> >> index feeddcb25e1f..131374db0db4 100644
> >> --- a/drivers/spi/atmel-quadspi.c
> >> +++ b/drivers/spi/atmel-quadspi.c
> >> @@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = {
> >> { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD },
> >> };
> >>
> >> -/* Register access functions */
> >> -static inline u32 qspi_readl(struct atmel_qspi *aq, u32 reg)
> >> -{
> >> - return readl_relaxed(aq->regs + reg);
> >> -}
> >> -
> >> -static inline void qspi_writel(struct atmel_qspi *aq, u32 reg, u32 value)
> >> -{
> >> - writel_relaxed(value, aq->regs + reg);
> >> -}
> >> -
> >> static inline bool is_compatible(const struct spi_mem_op *op,
> >> const struct qspi_mode *mode)
> >> {
> >> @@ -229,6 +218,7 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,
> >> static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >> {
> >> struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
> >> + void __iomem *base = aq->regs;
> >
> > Can we name this variable regs instead of base or even get rid of it
> > and dereference aq->regs in the xxx_relaxed() calls (doesn't look like
> > the lines would be over 80 chars even when doing that). With this
> > addressed, you can add:
> >
> > Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
>
> I chose to introduce the "base" variable when I have at least 2 dereferences in
> a function, as an optimization. In exec_op() for example, there are 6
> dereferences of aq->reqs. Why do you prefer keeping aq->regs?
I tend to not add local variables unless they help improve readability
or optimize things. In this case, I'd expect the compiler to be smart
enough to detect that aq->reqs is used several times and store it in a
register. When it comes to readability, I don't think it improve
things, but that's probably a matter of taste.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: <Tudor.Ambarus@microchip.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Ludovic.Desroches@microchip.com, Cyrille.Pitchen@microchip.com,
linux-mtd@lists.infradead.org, bugalski.piotr@gmail.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses
Date: Sat, 2 Feb 2019 14:23:37 +0100 [thread overview]
Message-ID: <20190202142337.3c51947e@bbrezillon> (raw)
In-Reply-To: <53c9f4b2-7022-e13d-65a4-2e1bed4d76b1@microchip.com>
On Sat, 2 Feb 2019 08:44:27 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 02/02/2019 09:11 AM, Boris Brezillon wrote:
> > On Sat, 2 Feb 2019 04:07:19 +0000
> > <Tudor.Ambarus@microchip.com> wrote:
> >
> >> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> The wrappers hid that the accesses are relaxed. Drop them.
> >>
> >> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> ---
> >> v3: no change
> >> v2: new patch
> >>
> >> drivers/spi/atmel-quadspi.c | 47 +++++++++++++++++++--------------------------
> >> 1 file changed, 20 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> >> index feeddcb25e1f..131374db0db4 100644
> >> --- a/drivers/spi/atmel-quadspi.c
> >> +++ b/drivers/spi/atmel-quadspi.c
> >> @@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = {
> >> { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD },
> >> };
> >>
> >> -/* Register access functions */
> >> -static inline u32 qspi_readl(struct atmel_qspi *aq, u32 reg)
> >> -{
> >> - return readl_relaxed(aq->regs + reg);
> >> -}
> >> -
> >> -static inline void qspi_writel(struct atmel_qspi *aq, u32 reg, u32 value)
> >> -{
> >> - writel_relaxed(value, aq->regs + reg);
> >> -}
> >> -
> >> static inline bool is_compatible(const struct spi_mem_op *op,
> >> const struct qspi_mode *mode)
> >> {
> >> @@ -229,6 +218,7 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,
> >> static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >> {
> >> struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
> >> + void __iomem *base = aq->regs;
> >
> > Can we name this variable regs instead of base or even get rid of it
> > and dereference aq->regs in the xxx_relaxed() calls (doesn't look like
> > the lines would be over 80 chars even when doing that). With this
> > addressed, you can add:
> >
> > Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
>
> I chose to introduce the "base" variable when I have at least 2 dereferences in
> a function, as an optimization. In exec_op() for example, there are 6
> dereferences of aq->reqs. Why do you prefer keeping aq->regs?
I tend to not add local variables unless they help improve readability
or optimize things. In this case, I'd expect the compiler to be smart
enough to detect that aq->reqs is used several times and store it in a
register. When it comes to readability, I don't think it improve
things, but that's probably a matter of taste.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-02 13:23 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 4:07 [PATCH v3 00/13] spi: atmel-quadspi: introduce sam9x60 qspi controller Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 01/13] spi: atmel-quadspi: cache MR value to avoid a write access Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 02/13] spi: atmel-quadspi: order header files inclusion alphabetically Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:11 ` Boris Brezillon
2019-02-02 7:11 ` Boris Brezillon
2019-02-02 7:11 ` Boris Brezillon
2019-02-02 7:11 ` Boris Brezillon
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 13:23 ` Boris Brezillon [this message]
2019-02-02 13:23 ` Boris Brezillon
2019-02-02 13:23 ` Boris Brezillon
2019-02-02 13:23 ` Boris Brezillon
2019-02-02 13:23 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 04/13] spi: atmel-quadspi: fix naming scheme Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:12 ` Boris Brezillon
2019-02-02 7:12 ` Boris Brezillon
2019-02-02 7:12 ` Boris Brezillon
2019-02-02 7:12 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 05/13] spi: atmel-quadspi: remove unnecessary cast Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 06/13] spi: atmel-quadspi: return appropriate error code Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 07/13] spi: atmel-quadspi: switch to SPDX license identifiers Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 08/13] spi: atmel-quadspi: drop unused and NOP transfer macros Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:13 ` Boris Brezillon
2019-02-02 7:13 ` Boris Brezillon
2019-02-02 7:13 ` Boris Brezillon
2019-02-02 7:13 ` Boris Brezillon
2019-02-02 8:46 ` Tudor.Ambarus
2019-02-02 8:46 ` Tudor.Ambarus
2019-02-02 8:46 ` Tudor.Ambarus
2019-02-02 8:46 ` Tudor.Ambarus
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 09/13] dt-bindings: spi: atmel-quadspi: update example to new clock binding Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:15 ` Boris Brezillon
2019-02-02 7:15 ` Boris Brezillon
2019-02-02 7:15 ` Boris Brezillon
2019-02-02 7:15 ` Boris Brezillon
2019-02-02 8:47 ` Tudor.Ambarus
2019-02-02 8:47 ` Tudor.Ambarus
2019-02-02 8:47 ` Tudor.Ambarus
2019-02-02 8:47 ` Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 11/13] spi: atmel-quadspi: add support for named peripheral clock Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:16 ` Boris Brezillon
2019-02-02 7:16 ` Boris Brezillon
2019-02-02 7:16 ` Boris Brezillon
2019-02-02 7:16 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 12/13] dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60 Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:17 ` Boris Brezillon
2019-02-02 7:17 ` Boris Brezillon
2019-02-02 7:17 ` Boris Brezillon
2019-02-02 7:17 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 4:07 ` Tudor.Ambarus
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 13:30 ` Boris Brezillon
2019-02-02 13:30 ` Boris Brezillon
2019-02-02 13:30 ` Boris Brezillon
2019-02-02 13:30 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202142337.3c51947e@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=Cyrille.Pitchen@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.