From: Jonathan Cameron <jic23@kernel.org> To: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Hartmut Knaack <knaack.h@gmx.de>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/5] iio:adc:lpc32xx Cleanup headers Date: Sat, 9 Feb 2019 17:16:46 +0000 [thread overview] Message-ID: <20190209171646.49c75afc@archlinux> (raw) In-Reply-To: <20190208160944.13281-5-gregory.clement@bootlin.com> On Fri, 8 Feb 2019 17:09:43 +0100 Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > A few headers was useless: remove them, and also sort them in alphabetic > order. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> Hmm. Given the headers in question are mostly only useless (I think) in the sense they are always included by something else, I'm not sure this patch is worth the churn. It's also tricky to see which ones were actually removed given the combination with sorting. I think it's just kernel.h, device.h, err.h all of which are used in various ways and often directly included. The other one is the iio/sysfs.h file. That one we could do to eventually kill off entirely, so happy to see that one alone go. Jonathan > --- > drivers/iio/adc/lpc32xx_adc.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c > index e361c1532a75..f391c1e10136 100644 > --- a/drivers/iio/adc/lpc32xx_adc.c > +++ b/drivers/iio/adc/lpc32xx_adc.c > @@ -7,20 +7,13 @@ > * Copyright (C) 2011, 2012 Roland Stigge <stigge@antcom.de> > */ > > -#include <linux/module.h> > -#include <linux/platform_device.h> > -#include <linux/interrupt.h> > -#include <linux/device.h> > -#include <linux/kernel.h> > -#include <linux/slab.h> > -#include <linux/io.h> > #include <linux/clk.h> > -#include <linux/err.h> > #include <linux/completion.h> > -#include <linux/of.h> > - > #include <linux/iio/iio.h> > -#include <linux/iio/sysfs.h> > +#include <linux/interrupt.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/platform_device.h> > > /* > * LPC32XX registers definitions
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Hartmut Knaack <knaack.h@gmx.de>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/5] iio:adc:lpc32xx Cleanup headers Date: Sat, 9 Feb 2019 17:16:46 +0000 [thread overview] Message-ID: <20190209171646.49c75afc@archlinux> (raw) In-Reply-To: <20190208160944.13281-5-gregory.clement@bootlin.com> On Fri, 8 Feb 2019 17:09:43 +0100 Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > A few headers was useless: remove them, and also sort them in alphabetic > order. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> Hmm. Given the headers in question are mostly only useless (I think) in the sense they are always included by something else, I'm not sure this patch is worth the churn. It's also tricky to see which ones were actually removed given the combination with sorting. I think it's just kernel.h, device.h, err.h all of which are used in various ways and often directly included. The other one is the iio/sysfs.h file. That one we could do to eventually kill off entirely, so happy to see that one alone go. Jonathan > --- > drivers/iio/adc/lpc32xx_adc.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c > index e361c1532a75..f391c1e10136 100644 > --- a/drivers/iio/adc/lpc32xx_adc.c > +++ b/drivers/iio/adc/lpc32xx_adc.c > @@ -7,20 +7,13 @@ > * Copyright (C) 2011, 2012 Roland Stigge <stigge@antcom.de> > */ > > -#include <linux/module.h> > -#include <linux/platform_device.h> > -#include <linux/interrupt.h> > -#include <linux/device.h> > -#include <linux/kernel.h> > -#include <linux/slab.h> > -#include <linux/io.h> > #include <linux/clk.h> > -#include <linux/err.h> > #include <linux/completion.h> > -#include <linux/of.h> > - > #include <linux/iio/iio.h> > -#include <linux/iio/sysfs.h> > +#include <linux/interrupt.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/platform_device.h> > > /* > * LPC32XX registers definitions _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-09 17:16 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 16:09 [PATCH 0/5] Adding scale support to the lpc32xx ADC driver Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-08 16:09 ` [PATCH 1/5] dt-bindings: iio: adc: move lpc32xx-adc out of staging Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:05 ` Jonathan Cameron 2019-02-09 17:05 ` Jonathan Cameron 2019-02-09 17:05 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 2/5] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 18:07 ` Vladimir Zapolskiy 2019-02-09 18:07 ` Vladimir Zapolskiy 2019-02-15 16:07 ` Gregory CLEMENT 2019-02-20 12:11 ` Sylvain Lemieux 2019-02-25 23:32 ` Rob Herring 2019-02-25 23:32 ` Rob Herring 2019-02-08 16:09 ` [PATCH 3/5] iio:adc:lpc32xx use SPDX-License-Identifier Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:10 ` Jonathan Cameron 2019-02-09 17:10 ` Jonathan Cameron 2019-02-09 17:10 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 4/5] iio:adc:lpc32xx Cleanup headers Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:16 ` Jonathan Cameron [this message] 2019-02-09 17:16 ` Jonathan Cameron 2019-02-15 15:42 ` Gregory CLEMENT 2019-02-18 14:07 ` Jonathan Cameron 2019-02-18 14:07 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 5/5] iio:adc:lpc32xx Add scale feature Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:23 ` Jonathan Cameron 2019-02-09 17:23 ` Jonathan Cameron 2019-02-15 15:35 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190209171646.49c75afc@archlinux \ --to=jic23@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.