From: Vladimir Zapolskiy <vz@mleia.com> To: Gregory CLEMENT <gregory.clement@bootlin.com>, Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH 2/5] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Date: Sat, 9 Feb 2019 20:07:36 +0200 [thread overview] Message-ID: <8bc7bfcf-ad04-0615-1735-c2bbf20b7861@mleia.com> (raw) In-Reply-To: <20190208160944.13281-3-gregory.clement@bootlin.com> Hi Gregory, On 02/08/2019 06:09 PM, Gregory CLEMENT wrote: > As most of the other ADC the lpc32xx one use a vref-supply property: > document it. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt b/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > index b3629d3a9adf..3a1bc669bd51 100644 > --- a/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > @@ -6,6 +6,10 @@ Required properties: > region. > - interrupts: The ADC interrupt > > +Optional: > + - vref-supply: The regulator supply ADC reference voltage, optional > + for legacy reason, but highly encouraging to us in new device tree > + here vref-supply voltage is 3.3v only, I think that might be a reason why the property is omitted. My concern is that the documentation shall not contain sections with description of properties found in the past for 'legacy reasons', if you like to support the backward compatibility in the driver, please update the documentation to the expected state and add a stub to care about legacy DTBs in the driver only. FWIW I personally don't mind about breaking the backward compatibility for NXP LPC32xx, it might be a concern when CONFIG_ARM_ATAG_DTB_COMPAT=y is removed from the lpc32xx_defconfig though. > Example: > > adc@40048000 { > @@ -13,4 +17,5 @@ Example: > reg = <0x40048000 0x1000>; > interrupt-parent = <&mic>; > interrupts = <39 0>; > + vref-supply = <&vcc>; > }; > I kindly ask you to include me to To: list, if you send another changes for NXP LPC32xx platform. Thank you. -- Best wishes, Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz@mleia.com> To: Gregory CLEMENT <gregory.clement@bootlin.com>, Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH 2/5] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Date: Sat, 9 Feb 2019 20:07:36 +0200 [thread overview] Message-ID: <8bc7bfcf-ad04-0615-1735-c2bbf20b7861@mleia.com> (raw) In-Reply-To: <20190208160944.13281-3-gregory.clement@bootlin.com> Hi Gregory, On 02/08/2019 06:09 PM, Gregory CLEMENT wrote: > As most of the other ADC the lpc32xx one use a vref-supply property: > document it. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt b/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > index b3629d3a9adf..3a1bc669bd51 100644 > --- a/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/lpc32xx-adc.txt > @@ -6,6 +6,10 @@ Required properties: > region. > - interrupts: The ADC interrupt > > +Optional: > + - vref-supply: The regulator supply ADC reference voltage, optional > + for legacy reason, but highly encouraging to us in new device tree > + here vref-supply voltage is 3.3v only, I think that might be a reason why the property is omitted. My concern is that the documentation shall not contain sections with description of properties found in the past for 'legacy reasons', if you like to support the backward compatibility in the driver, please update the documentation to the expected state and add a stub to care about legacy DTBs in the driver only. FWIW I personally don't mind about breaking the backward compatibility for NXP LPC32xx, it might be a concern when CONFIG_ARM_ATAG_DTB_COMPAT=y is removed from the lpc32xx_defconfig though. > Example: > > adc@40048000 { > @@ -13,4 +17,5 @@ Example: > reg = <0x40048000 0x1000>; > interrupt-parent = <&mic>; > interrupts = <39 0>; > + vref-supply = <&vcc>; > }; > I kindly ask you to include me to To: list, if you send another changes for NXP LPC32xx platform. Thank you. -- Best wishes, Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-09 18:07 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 16:09 [PATCH 0/5] Adding scale support to the lpc32xx ADC driver Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-08 16:09 ` [PATCH 1/5] dt-bindings: iio: adc: move lpc32xx-adc out of staging Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:05 ` Jonathan Cameron 2019-02-09 17:05 ` Jonathan Cameron 2019-02-09 17:05 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 2/5] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 17:09 ` Jonathan Cameron 2019-02-09 18:07 ` Vladimir Zapolskiy [this message] 2019-02-09 18:07 ` Vladimir Zapolskiy 2019-02-15 16:07 ` Gregory CLEMENT 2019-02-20 12:11 ` Sylvain Lemieux 2019-02-25 23:32 ` Rob Herring 2019-02-25 23:32 ` Rob Herring 2019-02-08 16:09 ` [PATCH 3/5] iio:adc:lpc32xx use SPDX-License-Identifier Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:10 ` Jonathan Cameron 2019-02-09 17:10 ` Jonathan Cameron 2019-02-09 17:10 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 4/5] iio:adc:lpc32xx Cleanup headers Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:16 ` Jonathan Cameron 2019-02-09 17:16 ` Jonathan Cameron 2019-02-15 15:42 ` Gregory CLEMENT 2019-02-18 14:07 ` Jonathan Cameron 2019-02-18 14:07 ` Jonathan Cameron 2019-02-08 16:09 ` [PATCH 5/5] iio:adc:lpc32xx Add scale feature Gregory CLEMENT 2019-02-08 16:09 ` Gregory CLEMENT 2019-02-09 17:23 ` Jonathan Cameron 2019-02-09 17:23 ` Jonathan Cameron 2019-02-15 15:35 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8bc7bfcf-ad04-0615-1735-c2bbf20b7861@mleia.com \ --to=vz@mleia.com \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.