From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: [PATCH v4 1/7] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Date: Sun, 17 Feb 2019 04:48:46 +0200 [thread overview] Message-ID: <20190217024852.23328-2-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <20190217024852.23328-1-laurent.pinchart+renesas@ideasonboard.com> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to the DU continuously") The DU output mode does not rely on frames being supplied on the WPF as its pipeline is supplied from DRM. For the upcoming WPF writeback functionality, we will choose to enable writeback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 7ceaf3222145..328d686189be 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -307,11 +307,6 @@ static int vsp1_video_pipeline_setup_partitions(struct vsp1_pipeline *pipe) * This function completes the current buffer by filling its sequence number, * time stamp and payload size, and hands it back to the videobuf core. * - * When operating in DU output mode (deep pipeline to the DU through the LIF), - * the VSP1 needs to constantly supply frames to the display. In that case, if - * no other buffer is queued, reuse the one that has just been processed instead - * of handing it back to the videobuf core. - * * Return the next queued buffer or NULL if the queue is empty. */ static struct vsp1_vb2_buffer * @@ -333,12 +328,6 @@ vsp1_video_complete_buffer(struct vsp1_video *video) done = list_first_entry(&video->irqqueue, struct vsp1_vb2_buffer, queue); - /* In DU output mode reuse the buffer if the list is singular. */ - if (pipe->lif && list_is_singular(&video->irqqueue)) { - spin_unlock_irqrestore(&video->irqlock, flags); - return done; - } - list_del(&done->queue); if (!list_empty(&video->irqqueue)) -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: [PATCH v4 1/7] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Date: Sun, 17 Feb 2019 04:48:46 +0200 [thread overview] Message-ID: <20190217024852.23328-2-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <20190217024852.23328-1-laurent.pinchart+renesas@ideasonboard.com> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to the DU continuously") The DU output mode does not rely on frames being supplied on the WPF as its pipeline is supplied from DRM. For the upcoming WPF writeback functionality, we will choose to enable writeback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 7ceaf3222145..328d686189be 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -307,11 +307,6 @@ static int vsp1_video_pipeline_setup_partitions(struct vsp1_pipeline *pipe) * This function completes the current buffer by filling its sequence number, * time stamp and payload size, and hands it back to the videobuf core. * - * When operating in DU output mode (deep pipeline to the DU through the LIF), - * the VSP1 needs to constantly supply frames to the display. In that case, if - * no other buffer is queued, reuse the one that has just been processed instead - * of handing it back to the videobuf core. - * * Return the next queued buffer or NULL if the queue is empty. */ static struct vsp1_vb2_buffer * @@ -333,12 +328,6 @@ vsp1_video_complete_buffer(struct vsp1_video *video) done = list_first_entry(&video->irqqueue, struct vsp1_vb2_buffer, queue); - /* In DU output mode reuse the buffer if the list is singular. */ - if (pipe->lif && list_is_singular(&video->irqqueue)) { - spin_unlock_irqrestore(&video->irqlock, flags); - return done; - } - list_del(&done->queue); if (!list_empty(&video->irqqueue)) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-17 2:49 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 2:48 [PATCH v4 0/7] VSP1: Display writeback support Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart [this message] 2019-02-17 2:48 ` [PATCH v4 1/7] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 2/7] media: vsp1: wpf: Fix partition configuration for display pipelines Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:16 ` Kieran Bingham 2019-02-17 20:16 ` Kieran Bingham 2019-02-18 23:24 ` Laurent Pinchart 2019-02-18 23:24 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:20 ` Kieran Bingham 2019-02-17 20:20 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 4/7] media: vsp1: Fix addresses of display-related registers for VSP-DL Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:27 ` Kieran Bingham 2019-02-17 20:27 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:35 ` Kieran Bingham 2019-02-17 20:35 ` Kieran Bingham 2019-02-18 23:43 ` Laurent Pinchart 2019-02-18 23:43 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 6/7] media: vsp1: Replace the display list internal flag with a flags field Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:38 ` Kieran Bingham 2019-02-17 20:38 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 7/7] media: vsp1: Provide a writeback video device Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:06 ` Kieran Bingham 2019-02-17 20:06 ` Kieran Bingham 2019-02-17 20:09 ` Kieran Bingham 2019-02-17 20:09 ` Kieran Bingham 2019-02-19 0:31 ` Laurent Pinchart 2019-02-19 0:31 ` Laurent Pinchart 2019-02-18 12:22 ` [PATCH v4 0/7] VSP1: Display writeback support Brian Starkey 2019-02-18 12:22 ` Brian Starkey 2019-02-18 23:04 ` Laurent Pinchart 2019-02-18 23:04 ` Laurent Pinchart 2019-02-21 8:23 ` Laurent Pinchart 2019-02-21 8:23 ` Laurent Pinchart 2019-02-21 9:50 ` Brian Starkey 2019-02-21 9:50 ` Brian Starkey 2019-02-21 10:02 ` Laurent Pinchart 2019-02-21 10:02 ` Laurent Pinchart 2019-02-21 12:19 ` Brian Starkey 2019-02-21 12:19 ` Brian Starkey 2019-02-21 12:23 ` Laurent Pinchart 2019-02-21 12:23 ` Laurent Pinchart 2019-02-21 13:44 ` Brian Starkey 2019-02-21 13:44 ` Brian Starkey 2019-02-21 23:12 ` Laurent Pinchart 2019-02-21 23:12 ` Laurent Pinchart 2019-02-21 14:15 ` Daniel Vetter 2019-02-21 14:15 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190217024852.23328-2-laurent.pinchart+renesas@ideasonboard.com \ --to=laurent.pinchart+renesas@ideasonboard.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kieran.bingham@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.