From: Kieran Bingham <kieran.bingham@ideasonboard.com> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body Date: Sun, 17 Feb 2019 20:20:53 +0000 [thread overview] Message-ID: <5f2885f8-7d45-1447-02ba-608fc7933169@ideasonboard.com> (raw) In-Reply-To: <20190217024852.23328-4-laurent.pinchart+renesas@ideasonboard.com> Hi Laurent, On 17/02/2019 02:48, Laurent Pinchart wrote: > Display list fragments have been renamed to bodies. Replace one last > occurrence of the word fragment in the documentation. > Interesting, this must have been a change that was written before the fragments were renamed, but got in /after/ they were removed or something. > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Regardless, it looks correct to fix this up. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c > index 26289adaf658..64af449791b0 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -699,8 +699,8 @@ struct vsp1_dl_body *vsp1_dl_list_get_body0(struct vsp1_dl_list *dl) > * which bodies are added. > * > * Adding a body to a display list passes ownership of the body to the list. The > - * caller retains its reference to the fragment when adding it to the display > - * list, but is not allowed to add new entries to the body. > + * caller retains its reference to the body when adding it to the display list, > + * but is not allowed to add new entries to the body. > * > * The reference must be explicitly released by a call to vsp1_dl_body_put() > * when the body isn't needed anymore. > -- Regards -- Kieran
WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham@ideasonboard.com> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body Date: Sun, 17 Feb 2019 20:20:53 +0000 [thread overview] Message-ID: <5f2885f8-7d45-1447-02ba-608fc7933169@ideasonboard.com> (raw) In-Reply-To: <20190217024852.23328-4-laurent.pinchart+renesas@ideasonboard.com> Hi Laurent, On 17/02/2019 02:48, Laurent Pinchart wrote: > Display list fragments have been renamed to bodies. Replace one last > occurrence of the word fragment in the documentation. > Interesting, this must have been a change that was written before the fragments were renamed, but got in /after/ they were removed or something. > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Regardless, it looks correct to fix this up. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c > index 26289adaf658..64af449791b0 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -699,8 +699,8 @@ struct vsp1_dl_body *vsp1_dl_list_get_body0(struct vsp1_dl_list *dl) > * which bodies are added. > * > * Adding a body to a display list passes ownership of the body to the list. The > - * caller retains its reference to the fragment when adding it to the display > - * list, but is not allowed to add new entries to the body. > + * caller retains its reference to the body when adding it to the display list, > + * but is not allowed to add new entries to the body. > * > * The reference must be explicitly released by a call to vsp1_dl_body_put() > * when the body isn't needed anymore. > -- Regards -- Kieran _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-17 20:20 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 2:48 [PATCH v4 0/7] VSP1: Display writeback support Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 1/7] Revert "[media] v4l: vsp1: Supply frames to the DU continuously" Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 2/7] media: vsp1: wpf: Fix partition configuration for display pipelines Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:16 ` Kieran Bingham 2019-02-17 20:16 ` Kieran Bingham 2019-02-18 23:24 ` Laurent Pinchart 2019-02-18 23:24 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:20 ` Kieran Bingham [this message] 2019-02-17 20:20 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 4/7] media: vsp1: Fix addresses of display-related registers for VSP-DL Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:27 ` Kieran Bingham 2019-02-17 20:27 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:35 ` Kieran Bingham 2019-02-17 20:35 ` Kieran Bingham 2019-02-18 23:43 ` Laurent Pinchart 2019-02-18 23:43 ` Laurent Pinchart 2019-02-17 2:48 ` [PATCH v4 6/7] media: vsp1: Replace the display list internal flag with a flags field Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:38 ` Kieran Bingham 2019-02-17 20:38 ` Kieran Bingham 2019-02-17 2:48 ` [PATCH v4 7/7] media: vsp1: Provide a writeback video device Laurent Pinchart 2019-02-17 2:48 ` Laurent Pinchart 2019-02-17 20:06 ` Kieran Bingham 2019-02-17 20:06 ` Kieran Bingham 2019-02-17 20:09 ` Kieran Bingham 2019-02-17 20:09 ` Kieran Bingham 2019-02-19 0:31 ` Laurent Pinchart 2019-02-19 0:31 ` Laurent Pinchart 2019-02-18 12:22 ` [PATCH v4 0/7] VSP1: Display writeback support Brian Starkey 2019-02-18 12:22 ` Brian Starkey 2019-02-18 23:04 ` Laurent Pinchart 2019-02-18 23:04 ` Laurent Pinchart 2019-02-21 8:23 ` Laurent Pinchart 2019-02-21 8:23 ` Laurent Pinchart 2019-02-21 9:50 ` Brian Starkey 2019-02-21 9:50 ` Brian Starkey 2019-02-21 10:02 ` Laurent Pinchart 2019-02-21 10:02 ` Laurent Pinchart 2019-02-21 12:19 ` Brian Starkey 2019-02-21 12:19 ` Brian Starkey 2019-02-21 12:23 ` Laurent Pinchart 2019-02-21 12:23 ` Laurent Pinchart 2019-02-21 13:44 ` Brian Starkey 2019-02-21 13:44 ` Brian Starkey 2019-02-21 23:12 ` Laurent Pinchart 2019-02-21 23:12 ` Laurent Pinchart 2019-02-21 14:15 ` Daniel Vetter 2019-02-21 14:15 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5f2885f8-7d45-1447-02ba-608fc7933169@ideasonboard.com \ --to=kieran.bingham@ideasonboard.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.