From: Mark Rutland <Mark.Rutland@arm.com> To: Steven Price <Steven.Price@arm.com> Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>, "Andy Lutomirski" <luto@kernel.org>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Arnd Bergmann" <arnd@arndb.de>, "Borislav Petkov" <bp@alien8.de>, "Catalin Marinas" <Catalin.Marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Ingo Molnar" <mingo@redhat.com>, "James Morse" <James.Morse@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <Will.Deacon@arm.com>, "x86@kernel.org" <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions Date: Mon, 18 Feb 2019 11:16:12 +0000 [thread overview] Message-ID: <20190218111610.GD8036@lakrids.cambridge.arm.com> (raw) In-Reply-To: <20190215170235.23360-2-steven.price@arm.com> On Fri, Feb 15, 2019 at 05:02:22PM +0000, Steven Price wrote: > From: James Morse <james.morse@arm.com> > > Exposing the pud/pgd levels of the page tables to walk_page_range() means > we may come across the exotic large mappings that come with large areas > of contiguous memory (such as the kernel's linear map). > > Expose p?d_large() from each architecture to detect these large mappings. > > arm64 already has these macros defined, but with a different name. > p?d_large() is used by s390, sparc and x86. Only arm/arm64 use p?d_sect(). > Add a macro to allow both names. > > By not providing a pgd_large(), we get the generic version that always > returns 0. This last sentence isn't true until a subsequent patch, so it's probably worth dropping it to avoid confusion. Thanks, Mark. > > Signed-off-by: James Morse <james.morse@arm.com> > Signed-off-by: Steven Price <steven.price@arm.com> > --- > arch/arm64/include/asm/pgtable.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index de70c1eabf33..09d308921625 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -428,6 +428,7 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, > PMD_TYPE_TABLE) > #define pmd_sect(pmd)((pmd_val(pmd) & PMD_TYPE_MASK) == \ > PMD_TYPE_SECT) > +#define pmd_large(x)pmd_sect(x) > > #if defined(CONFIG_ARM64_64K_PAGES) || CONFIG_PGTABLE_LEVELS < 3 > #define pud_sect(pud)(0) > @@ -435,6 +436,7 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, > #else > #define pud_sect(pud)((pud_val(pud) & PUD_TYPE_MASK) == \ > PUD_TYPE_SECT) > +#define pud_large(x)pud_sect(x) > #define pud_table(pud)((pud_val(pud) & PUD_TYPE_MASK) == \ > PUD_TYPE_TABLE) > #endif > -- > 2.20.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <Mark.Rutland@arm.com> To: Steven Price <Steven.Price@arm.com> Cc: "x86@kernel.org" <x86@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <Catalin.Marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Will Deacon" <Will.Deacon@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <James.Morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions Date: Mon, 18 Feb 2019 11:16:12 +0000 [thread overview] Message-ID: <20190218111610.GD8036@lakrids.cambridge.arm.com> (raw) In-Reply-To: <20190215170235.23360-2-steven.price@arm.com> On Fri, Feb 15, 2019 at 05:02:22PM +0000, Steven Price wrote: > From: James Morse <james.morse@arm.com> > > Exposing the pud/pgd levels of the page tables to walk_page_range() means > we may come across the exotic large mappings that come with large areas > of contiguous memory (such as the kernel's linear map). > > Expose p?d_large() from each architecture to detect these large mappings. > > arm64 already has these macros defined, but with a different name. > p?d_large() is used by s390, sparc and x86. Only arm/arm64 use p?d_sect(). > Add a macro to allow both names. > > By not providing a pgd_large(), we get the generic version that always > returns 0. This last sentence isn't true until a subsequent patch, so it's probably worth dropping it to avoid confusion. Thanks, Mark. > > Signed-off-by: James Morse <james.morse@arm.com> > Signed-off-by: Steven Price <steven.price@arm.com> > --- > arch/arm64/include/asm/pgtable.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index de70c1eabf33..09d308921625 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -428,6 +428,7 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, > PMD_TYPE_TABLE) > #define pmd_sect(pmd)((pmd_val(pmd) & PMD_TYPE_MASK) == \ > PMD_TYPE_SECT) > +#define pmd_large(x)pmd_sect(x) > > #if defined(CONFIG_ARM64_64K_PAGES) || CONFIG_PGTABLE_LEVELS < 3 > #define pud_sect(pud)(0) > @@ -435,6 +436,7 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, > #else > #define pud_sect(pud)((pud_val(pud) & PUD_TYPE_MASK) == \ > PUD_TYPE_SECT) > +#define pud_large(x)pud_sect(x) > #define pud_table(pud)((pud_val(pud) & PUD_TYPE_MASK) == \ > PUD_TYPE_TABLE) > #endif > -- > 2.20.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-18 11:16 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-15 17:02 [PATCH 00/13] Convert x86 & arm64 to use generic page walk Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 01/13] arm64: mm: Add p?d_large() definitions Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-18 11:16 ` Mark Rutland [this message] 2019-02-18 11:16 ` Mark Rutland 2019-02-18 11:29 ` Peter Zijlstra 2019-02-18 11:29 ` Peter Zijlstra 2019-02-18 13:45 ` Mark Rutland 2019-02-18 13:45 ` Mark Rutland 2019-02-18 14:11 ` Steven Price 2019-02-18 14:11 ` Steven Price 2019-02-18 14:29 ` Mark Rutland 2019-02-18 14:29 ` Mark Rutland 2019-02-18 15:06 ` Peter Zijlstra 2019-02-18 15:06 ` Peter Zijlstra 2019-02-18 15:30 ` Steven Price 2019-02-18 15:30 ` Steven Price 2019-02-18 17:04 ` Mark Rutland 2019-02-18 17:04 ` Mark Rutland 2019-02-18 17:22 ` Steven Price 2019-02-18 17:22 ` Steven Price 2019-02-15 17:02 ` [PATCH 02/13] x86/mm: " Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 03/13] mm: Add generic p?d_large() macros Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-18 11:14 ` Mark Rutland 2019-02-18 11:14 ` Mark Rutland 2019-02-18 12:53 ` Peter Zijlstra 2019-02-18 12:53 ` Peter Zijlstra 2019-02-18 14:20 ` Steven Price 2019-02-18 14:20 ` Steven Price 2019-02-18 11:31 ` Peter Zijlstra 2019-02-18 11:31 ` Peter Zijlstra 2019-02-18 14:19 ` Steven Price 2019-02-18 14:19 ` Steven Price 2019-02-19 3:44 ` Liang, Kan 2019-02-19 3:44 ` Liang, Kan 2019-02-20 13:56 ` Steven Price 2019-02-20 13:56 ` Steven Price 2019-02-15 17:02 ` [PATCH 04/13] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 05/13] mm: pagewalk: Allow walking without vma Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-18 11:23 ` Mark Rutland 2019-02-18 11:23 ` Mark Rutland 2019-02-18 15:23 ` Steven Price 2019-02-18 15:23 ` Steven Price 2019-02-20 11:35 ` William Kucharski 2019-02-20 11:35 ` William Kucharski 2019-02-20 14:10 ` Steven Price 2019-02-20 14:10 ` Steven Price 2019-02-15 17:02 ` [PATCH 07/13] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 08/13] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 09/13] x86/mm: Point to struct seq_file from struct pg_state Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 10/13] x86/mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 11/13] x86/mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 12/13] x86/mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:02 ` [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-02-15 17:02 ` Steven Price 2019-02-15 17:16 ` Dave Hansen 2019-02-15 17:16 ` Dave Hansen 2019-02-15 17:32 ` Steven Price 2019-02-15 17:32 ` Steven Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190218111610.GD8036@lakrids.cambridge.arm.com \ --to=mark.rutland@arm.com \ --cc=Catalin.Marinas@arm.com \ --cc=James.Morse@arm.com \ --cc=Steven.Price@arm.com \ --cc=Will.Deacon@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=jglisse@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.