From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <Mark.Rutland@arm.com>
Cc: "Steven Price" <Steven.Price@arm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"x86@kernel.org" <x86@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Catalin Marinas" <Catalin.Marinas@arm.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Will Deacon" <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Andy Lutomirski" <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"James Morse" <James.Morse@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/13] mm: Add generic p?d_large() macros
Date: Mon, 18 Feb 2019 13:53:27 +0100 [thread overview]
Message-ID: <20190218125327.GT32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190218111421.GC8036@lakrids.cambridge.arm.com>
On Mon, Feb 18, 2019 at 11:14:23AM +0000, Mark Rutland wrote:
> > +#ifndef pgd_large
> > +#define pgd_large(x)0
> > +#endif
> > +#ifndef pud_large
> > +#define pud_large(x)0
> > +#endif
> > +#ifndef pmd_large
> > +#define pmd_large(x)0
> > +#endif
>
> It might be worth a comment defining the semantics of these, e.g. how
> they differ from p?d_huge() and p?d_trans_huge().
Yes; I took it to mean any large page mapping, so it would explicitly
include huge and thp.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <Mark.Rutland@arm.com>
Cc: "Dave Hansen" <dave.hansen@linux.intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Catalin Marinas" <Catalin.Marinas@arm.com>,
"x86@kernel.org" <x86@kernel.org>,
"Will Deacon" <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Steven Price" <Steven.Price@arm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Andy Lutomirski" <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"James Morse" <James.Morse@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/13] mm: Add generic p?d_large() macros
Date: Mon, 18 Feb 2019 13:53:27 +0100 [thread overview]
Message-ID: <20190218125327.GT32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190218111421.GC8036@lakrids.cambridge.arm.com>
On Mon, Feb 18, 2019 at 11:14:23AM +0000, Mark Rutland wrote:
> > +#ifndef pgd_large
> > +#define pgd_large(x)0
> > +#endif
> > +#ifndef pud_large
> > +#define pud_large(x)0
> > +#endif
> > +#ifndef pmd_large
> > +#define pmd_large(x)0
> > +#endif
>
> It might be worth a comment defining the semantics of these, e.g. how
> they differ from p?d_huge() and p?d_trans_huge().
Yes; I took it to mean any large page mapping, so it would explicitly
include huge and thp.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-18 12:53 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 17:02 [PATCH 00/13] Convert x86 & arm64 to use generic page walk Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 01/13] arm64: mm: Add p?d_large() definitions Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-18 11:16 ` Mark Rutland
2019-02-18 11:16 ` Mark Rutland
2019-02-18 11:29 ` Peter Zijlstra
2019-02-18 11:29 ` Peter Zijlstra
2019-02-18 13:45 ` Mark Rutland
2019-02-18 13:45 ` Mark Rutland
2019-02-18 14:11 ` Steven Price
2019-02-18 14:11 ` Steven Price
2019-02-18 14:29 ` Mark Rutland
2019-02-18 14:29 ` Mark Rutland
2019-02-18 15:06 ` Peter Zijlstra
2019-02-18 15:06 ` Peter Zijlstra
2019-02-18 15:30 ` Steven Price
2019-02-18 15:30 ` Steven Price
2019-02-18 17:04 ` Mark Rutland
2019-02-18 17:04 ` Mark Rutland
2019-02-18 17:22 ` Steven Price
2019-02-18 17:22 ` Steven Price
2019-02-15 17:02 ` [PATCH 02/13] x86/mm: " Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 03/13] mm: Add generic p?d_large() macros Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-18 11:14 ` Mark Rutland
2019-02-18 11:14 ` Mark Rutland
2019-02-18 12:53 ` Peter Zijlstra [this message]
2019-02-18 12:53 ` Peter Zijlstra
2019-02-18 14:20 ` Steven Price
2019-02-18 14:20 ` Steven Price
2019-02-18 11:31 ` Peter Zijlstra
2019-02-18 11:31 ` Peter Zijlstra
2019-02-18 14:19 ` Steven Price
2019-02-18 14:19 ` Steven Price
2019-02-19 3:44 ` Liang, Kan
2019-02-19 3:44 ` Liang, Kan
2019-02-20 13:56 ` Steven Price
2019-02-20 13:56 ` Steven Price
2019-02-15 17:02 ` [PATCH 04/13] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 05/13] mm: pagewalk: Allow walking without vma Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-18 11:23 ` Mark Rutland
2019-02-18 11:23 ` Mark Rutland
2019-02-18 15:23 ` Steven Price
2019-02-18 15:23 ` Steven Price
2019-02-20 11:35 ` William Kucharski
2019-02-20 11:35 ` William Kucharski
2019-02-20 14:10 ` Steven Price
2019-02-20 14:10 ` Steven Price
2019-02-15 17:02 ` [PATCH 07/13] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 08/13] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 09/13] x86/mm: Point to struct seq_file from struct pg_state Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 10/13] x86/mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 11/13] x86/mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 12/13] x86/mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:02 ` [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-02-15 17:02 ` Steven Price
2019-02-15 17:16 ` Dave Hansen
2019-02-15 17:16 ` Dave Hansen
2019-02-15 17:32 ` Steven Price
2019-02-15 17:32 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218125327.GT32494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Catalin.Marinas@arm.com \
--cc=James.Morse@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Steven.Price@arm.com \
--cc=Will.Deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jglisse@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.