From: Boris Brezillon <bbrezillon@kernel.org> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Richard Weinberger <richard@nod.at>, Schrempf Frieder <frieder.schrempf@kontron.de>, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 17/27] mtd: nand: ecc: Let the software Hamming ECC engine be unselected Date: Thu, 21 Feb 2019 14:20:02 +0100 [thread overview] Message-ID: <20190221142002.5a160f87@kernel.org> (raw) In-Reply-To: <20190221125806.28875-5-miquel.raynal@bootlin.com> On Thu, 21 Feb 2019 13:57:56 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > There is no reason to always embed the software Hamming ECC engine > implementation. By default it is, but we can let the user decide. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/ecc/Kconfig | 10 +++++- > drivers/mtd/nand/raw/Kconfig | 2 +- > include/linux/mtd/nand-sw-hamming-engine.h | 38 ++++++++++++++++++++++ > 3 files changed, 48 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/ecc/Kconfig b/drivers/mtd/nand/ecc/Kconfig > index e0106b3a7ec1..ff20e621ffef 100644 > --- a/drivers/mtd/nand/ecc/Kconfig > +++ b/drivers/mtd/nand/ecc/Kconfig > @@ -1,7 +1,15 @@ > menu "ECC engine support" > > config MTD_NAND_ECC_SW_HAMMING > - tristate > + tristate "Software Hamming ECC engine" > + default y Same as for the NAND_CORE stuff, let users this option when they need it instead of having a "default y". Haven't made my mind yet on whether this option should be visible to users or not. I guess it could be with the new infrastructure, but it's probably too early in the patch series to change that. > + help > + This enables support for software Hamming error > + correction. This correction can correct up to 1 bit error > + per chunk and detect up to 2 bit errors. While it used to be > + widely used with old parts, newer NAND chips usually require > + more strength correction and in this case BCH or RS will be > + preferred. > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Richard Weinberger <richard@nod.at>, Schrempf Frieder <frieder.schrempf@kontron.de>, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 17/27] mtd: nand: ecc: Let the software Hamming ECC engine be unselected Date: Thu, 21 Feb 2019 14:20:02 +0100 [thread overview] Message-ID: <20190221142002.5a160f87@kernel.org> (raw) In-Reply-To: <20190221125806.28875-5-miquel.raynal@bootlin.com> On Thu, 21 Feb 2019 13:57:56 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > There is no reason to always embed the software Hamming ECC engine > implementation. By default it is, but we can let the user decide. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/ecc/Kconfig | 10 +++++- > drivers/mtd/nand/raw/Kconfig | 2 +- > include/linux/mtd/nand-sw-hamming-engine.h | 38 ++++++++++++++++++++++ > 3 files changed, 48 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/ecc/Kconfig b/drivers/mtd/nand/ecc/Kconfig > index e0106b3a7ec1..ff20e621ffef 100644 > --- a/drivers/mtd/nand/ecc/Kconfig > +++ b/drivers/mtd/nand/ecc/Kconfig > @@ -1,7 +1,15 @@ > menu "ECC engine support" > > config MTD_NAND_ECC_SW_HAMMING > - tristate > + tristate "Software Hamming ECC engine" > + default y Same as for the NAND_CORE stuff, let users this option when they need it instead of having a "default y". Haven't made my mind yet on whether this option should be visible to users or not. I guess it could be with the new infrastructure, but it's probably too early in the patch series to change that. > + help > + This enables support for software Hamming error > + correction. This correction can correct up to 1 bit error > + per chunk and detect up to 2 bit errors. While it used to be > + widely used with old parts, newer NAND chips usually require > + more strength correction and in this case BCH or RS will be > + preferred. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-21 13:20 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-21 12:57 [RFC PATCH 13/27] mtd: nand: ecc: Clarify the software Hamming introductory line Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 12:57 ` [RFC PATCH 14/27] mtd: nand: ecc: Turn the software Hamming implementation generic Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 13:22 ` Boris Brezillon 2019-02-21 13:22 ` Boris Brezillon 2019-02-21 12:57 ` [RFC PATCH 15/27] mtd: nand: Remove useless include about software Hamming ECC Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 12:57 ` [RFC PATCH 16/27] mtd: nand: ecc: Let the software BCH ECC engine be a module Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 13:48 ` Adam Ford 2019-02-21 13:48 ` Adam Ford 2019-02-21 14:02 ` Miquel Raynal 2019-02-21 14:02 ` Miquel Raynal 2019-02-22 14:24 ` Boris Brezillon 2019-02-22 14:24 ` Boris Brezillon 2019-02-21 12:57 ` [RFC PATCH 17/27] mtd: nand: ecc: Let the software Hamming ECC engine be unselected Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 13:20 ` Boris Brezillon [this message] 2019-02-21 13:20 ` Boris Brezillon 2019-02-21 13:35 ` Miquel Raynal 2019-02-21 13:35 ` Miquel Raynal 2019-02-21 13:41 ` Boris Brezillon 2019-02-21 13:41 ` Boris Brezillon 2019-02-21 13:46 ` Miquel Raynal 2019-02-21 13:46 ` Miquel Raynal 2019-02-21 12:57 ` [RFC PATCH 18/27] mtd: nand: ecc: Create the software BCH engine instance Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 12:57 ` [RFC PATCH 19/27] mtd: nand: ecc: Create the software Hamming " Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-21 12:57 ` [RFC PATCH 20/27] mtd: nand: Let software ECC engines be retrieved from the NAND core Miquel Raynal 2019-02-21 12:57 ` Miquel Raynal 2019-02-22 14:29 ` Boris Brezillon 2019-02-22 14:29 ` Boris Brezillon 2019-02-25 15:49 ` Miquel Raynal 2019-02-25 15:49 ` Miquel Raynal 2019-02-25 16:13 ` Boris Brezillon 2019-02-25 16:13 ` Boris Brezillon 2019-02-26 15:54 ` Miquel Raynal 2019-02-26 15:54 ` Miquel Raynal 2019-02-21 12:58 ` [RFC PATCH 21/27] mtd: spinand: Fix typo in comment Miquel Raynal 2019-02-21 12:58 ` Miquel Raynal 2019-02-22 14:31 ` Boris Brezillon 2019-02-22 14:31 ` Boris Brezillon 2019-02-21 12:58 ` [RFC PATCH 22/27] mtd: spinand: Let the SPI-NAND core flag a SPI-NAND chip Miquel Raynal 2019-02-21 12:58 ` Miquel Raynal 2019-02-22 14:33 ` Boris Brezillon 2019-02-22 14:33 ` Boris Brezillon 2019-02-21 12:58 ` [RFC PATCH 23/27] mtd: spinand: Move the ECC helper functions into a separate file Miquel Raynal 2019-02-21 12:58 ` Miquel Raynal 2019-02-21 12:58 ` [RFC PATCH 24/27] mtd: spinand: Instantiate a SPI-NAND on-die ECC engine Miquel Raynal 2019-02-21 12:58 ` Miquel Raynal 2019-02-22 14:38 ` Boris Brezillon 2019-02-22 14:38 ` Boris Brezillon 2019-02-21 12:58 ` [RFC PATCH 25/27] mtd: nand: Add helpers to manage ECC engines and configurations Miquel Raynal 2019-02-21 12:58 ` Miquel Raynal 2019-02-22 14:44 ` Boris Brezillon 2019-02-22 14:44 ` Boris Brezillon 2019-02-25 16:01 ` Miquel Raynal 2019-02-25 16:01 ` Miquel Raynal 2019-02-25 16:34 ` Boris Brezillon 2019-02-25 16:34 ` Boris Brezillon 2019-02-25 18:48 ` Boris Brezillon 2019-02-25 18:48 ` Boris Brezillon 2019-02-26 15:59 ` [RFC PATCH 25/27] mtd: nand: Add helpers to manage ECC engines and configurationsND Miquel Raynal 2019-02-26 15:59 ` Miquel Raynal 2019-02-26 16:04 ` Boris Brezillon 2019-02-26 16:04 ` Boris Brezillon 2019-02-27 14:07 ` [RFC PATCH 25/27] mtd: nand: Add helpers to manage ECC engines and configurations Miquel Raynal 2019-02-27 14:07 ` Miquel Raynal 2019-02-27 14:30 ` Boris Brezillon 2019-02-27 14:30 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190221142002.5a160f87@kernel.org \ --to=bbrezillon@kernel.org \ --cc=Tudor.Ambarus@microchip.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=frieder.schrempf@kontron.de \ --cc=juliensu@mxic.com.tw \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=masonccyang@mxic.com.tw \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.