From: kbuild test robot <lkp@intel.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-doc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
linux-mm@kvack.org, Eric Dumazet <edumazet@google.com>,
linux-kselftest@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, Jacob Bramley <Jacob.Bramley@arm.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
Evgeniy Stepanov <eugenis@google.com>,
Kevin Brodsky <kevin.brodsky@arm.com>
Subject: Re: [PATCH v11 09/14] kernel, arm64: untag user pointers in prctl_set_mm*
Date: Sun, 17 Mar 2019 03:31:52 +0800 [thread overview]
Message-ID: <201903170317.IWsOYXBe%lkp@intel.com> (raw)
In-Reply-To: <c4d65de9867cb3349af6800242da0de751260c6c.1552679409.git.andreyknvl@google.com>
[-- Attachment #1: Type: text/plain, Size: 6839 bytes --]
Hi Andrey,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/uaccess-add-untagged_addr-definition-for-other-arches/20190317-015913
config: x86_64-randconfig-x012-201911 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
kernel/sys.c: In function 'prctl_set_mm_map':
>> kernel/sys.c:1996:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_code = untagged_addr(prctl_map.start_code);
^~
kernel/sys.c:1997:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_code = untagged_addr(prctl_map.end_code);
^~
kernel/sys.c:1998:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_data = untagged_addr(prctl_map.start_data);
^~
kernel/sys.c:1999:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_data = untagged_addr(prctl_map.end_data);
^~
kernel/sys.c:2000:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
^~
kernel/sys.c:2001:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->brk = untagged_addr(prctl_map.brk);
^~
kernel/sys.c:2002:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
^~
kernel/sys.c:2003:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
^~
kernel/sys.c:2004:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
^~
kernel/sys.c:2005:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_start = untagged_addr(prctl_map.env_start);
^~
kernel/sys.c:2006:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_end = untagged_addr(prctl_map.env_end);
^~
vim +1996 kernel/sys.c
1974
1975 #ifdef CONFIG_CHECKPOINT_RESTORE
1976 static int prctl_set_mm_map(int opt, const void __user *addr, unsigned long data_size)
1977 {
1978 struct prctl_mm_map prctl_map = { .exe_fd = (u32)-1, };
1979 unsigned long user_auxv[AT_VECTOR_SIZE];
1980 struct mm_struct *mm = current->mm;
1981 int error;
1982
1983 BUILD_BUG_ON(sizeof(user_auxv) != sizeof(mm->saved_auxv));
1984 BUILD_BUG_ON(sizeof(struct prctl_mm_map) > 256);
1985
1986 if (opt == PR_SET_MM_MAP_SIZE)
1987 return put_user((unsigned int)sizeof(prctl_map),
1988 (unsigned int __user *)addr);
1989
1990 if (data_size != sizeof(prctl_map))
1991 return -EINVAL;
1992
1993 if (copy_from_user(&prctl_map, addr, sizeof(prctl_map)))
1994 return -EFAULT;
1995
> 1996 prctl_map->start_code = untagged_addr(prctl_map.start_code);
1997 prctl_map->end_code = untagged_addr(prctl_map.end_code);
1998 prctl_map->start_data = untagged_addr(prctl_map.start_data);
1999 prctl_map->end_data = untagged_addr(prctl_map.end_data);
2000 prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
2001 prctl_map->brk = untagged_addr(prctl_map.brk);
2002 prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
2003 prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
2004 prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
2005 prctl_map->env_start = untagged_addr(prctl_map.env_start);
2006 prctl_map->env_end = untagged_addr(prctl_map.env_end);
2007
2008 error = validate_prctl_map(&prctl_map);
2009 if (error)
2010 return error;
2011
2012 if (prctl_map.auxv_size) {
2013 memset(user_auxv, 0, sizeof(user_auxv));
2014 if (copy_from_user(user_auxv,
2015 (const void __user *)prctl_map.auxv,
2016 prctl_map.auxv_size))
2017 return -EFAULT;
2018
2019 /* Last entry must be AT_NULL as specification requires */
2020 user_auxv[AT_VECTOR_SIZE - 2] = AT_NULL;
2021 user_auxv[AT_VECTOR_SIZE - 1] = AT_NULL;
2022 }
2023
2024 if (prctl_map.exe_fd != (u32)-1) {
2025 error = prctl_set_mm_exe_file(mm, prctl_map.exe_fd);
2026 if (error)
2027 return error;
2028 }
2029
2030 /*
2031 * arg_lock protects concurent updates but we still need mmap_sem for
2032 * read to exclude races with sys_brk.
2033 */
2034 down_read(&mm->mmap_sem);
2035
2036 /*
2037 * We don't validate if these members are pointing to
2038 * real present VMAs because application may have correspond
2039 * VMAs already unmapped and kernel uses these members for statistics
2040 * output in procfs mostly, except
2041 *
2042 * - @start_brk/@brk which are used in do_brk but kernel lookups
2043 * for VMAs when updating these memvers so anything wrong written
2044 * here cause kernel to swear at userspace program but won't lead
2045 * to any problem in kernel itself
2046 */
2047
2048 spin_lock(&mm->arg_lock);
2049 mm->start_code = prctl_map.start_code;
2050 mm->end_code = prctl_map.end_code;
2051 mm->start_data = prctl_map.start_data;
2052 mm->end_data = prctl_map.end_data;
2053 mm->start_brk = prctl_map.start_brk;
2054 mm->brk = prctl_map.brk;
2055 mm->start_stack = prctl_map.start_stack;
2056 mm->arg_start = prctl_map.arg_start;
2057 mm->arg_end = prctl_map.arg_end;
2058 mm->env_start = prctl_map.env_start;
2059 mm->env_end = prctl_map.env_end;
2060 spin_unlock(&mm->arg_lock);
2061
2062 /*
2063 * Note this update of @saved_auxv is lockless thus
2064 * if someone reads this member in procfs while we're
2065 * updating -- it may get partly updated results. It's
2066 * known and acceptable trade off: we leave it as is to
2067 * not introduce additional locks here making the kernel
2068 * more complex.
2069 */
2070 if (prctl_map.auxv_size)
2071 memcpy(mm->saved_auxv, user_auxv, sizeof(user_auxv));
2072
2073 up_read(&mm->mmap_sem);
2074 return 0;
2075 }
2076 #endif /* CONFIG_CHECKPOINT_RESTORE */
2077
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27888 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: kbuild-all@01.org, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Kees Cook <keescook@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Shuah Khan <shuah@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>,
Kostya Serebryany <kcc@google.com>,
Evgeniy Stepanov <eugenis@google.com>,
Lee Smith <Lee.Smith@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Chintan Pandya <cpandya@codeaurora.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Dave Martin <Dave.Martin@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH v11 09/14] kernel, arm64: untag user pointers in prctl_set_mm*
Date: Sun, 17 Mar 2019 03:31:52 +0800 [thread overview]
Message-ID: <201903170317.IWsOYXBe%lkp@intel.com> (raw)
In-Reply-To: <c4d65de9867cb3349af6800242da0de751260c6c.1552679409.git.andreyknvl@google.com>
[-- Attachment #1: Type: text/plain, Size: 6839 bytes --]
Hi Andrey,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/uaccess-add-untagged_addr-definition-for-other-arches/20190317-015913
config: x86_64-randconfig-x012-201911 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
kernel/sys.c: In function 'prctl_set_mm_map':
>> kernel/sys.c:1996:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_code = untagged_addr(prctl_map.start_code);
^~
kernel/sys.c:1997:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_code = untagged_addr(prctl_map.end_code);
^~
kernel/sys.c:1998:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_data = untagged_addr(prctl_map.start_data);
^~
kernel/sys.c:1999:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_data = untagged_addr(prctl_map.end_data);
^~
kernel/sys.c:2000:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
^~
kernel/sys.c:2001:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->brk = untagged_addr(prctl_map.brk);
^~
kernel/sys.c:2002:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
^~
kernel/sys.c:2003:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
^~
kernel/sys.c:2004:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
^~
kernel/sys.c:2005:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_start = untagged_addr(prctl_map.env_start);
^~
kernel/sys.c:2006:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_end = untagged_addr(prctl_map.env_end);
^~
vim +1996 kernel/sys.c
1974
1975 #ifdef CONFIG_CHECKPOINT_RESTORE
1976 static int prctl_set_mm_map(int opt, const void __user *addr, unsigned long data_size)
1977 {
1978 struct prctl_mm_map prctl_map = { .exe_fd = (u32)-1, };
1979 unsigned long user_auxv[AT_VECTOR_SIZE];
1980 struct mm_struct *mm = current->mm;
1981 int error;
1982
1983 BUILD_BUG_ON(sizeof(user_auxv) != sizeof(mm->saved_auxv));
1984 BUILD_BUG_ON(sizeof(struct prctl_mm_map) > 256);
1985
1986 if (opt == PR_SET_MM_MAP_SIZE)
1987 return put_user((unsigned int)sizeof(prctl_map),
1988 (unsigned int __user *)addr);
1989
1990 if (data_size != sizeof(prctl_map))
1991 return -EINVAL;
1992
1993 if (copy_from_user(&prctl_map, addr, sizeof(prctl_map)))
1994 return -EFAULT;
1995
> 1996 prctl_map->start_code = untagged_addr(prctl_map.start_code);
1997 prctl_map->end_code = untagged_addr(prctl_map.end_code);
1998 prctl_map->start_data = untagged_addr(prctl_map.start_data);
1999 prctl_map->end_data = untagged_addr(prctl_map.end_data);
2000 prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
2001 prctl_map->brk = untagged_addr(prctl_map.brk);
2002 prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
2003 prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
2004 prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
2005 prctl_map->env_start = untagged_addr(prctl_map.env_start);
2006 prctl_map->env_end = untagged_addr(prctl_map.env_end);
2007
2008 error = validate_prctl_map(&prctl_map);
2009 if (error)
2010 return error;
2011
2012 if (prctl_map.auxv_size) {
2013 memset(user_auxv, 0, sizeof(user_auxv));
2014 if (copy_from_user(user_auxv,
2015 (const void __user *)prctl_map.auxv,
2016 prctl_map.auxv_size))
2017 return -EFAULT;
2018
2019 /* Last entry must be AT_NULL as specification requires */
2020 user_auxv[AT_VECTOR_SIZE - 2] = AT_NULL;
2021 user_auxv[AT_VECTOR_SIZE - 1] = AT_NULL;
2022 }
2023
2024 if (prctl_map.exe_fd != (u32)-1) {
2025 error = prctl_set_mm_exe_file(mm, prctl_map.exe_fd);
2026 if (error)
2027 return error;
2028 }
2029
2030 /*
2031 * arg_lock protects concurent updates but we still need mmap_sem for
2032 * read to exclude races with sys_brk.
2033 */
2034 down_read(&mm->mmap_sem);
2035
2036 /*
2037 * We don't validate if these members are pointing to
2038 * real present VMAs because application may have correspond
2039 * VMAs already unmapped and kernel uses these members for statistics
2040 * output in procfs mostly, except
2041 *
2042 * - @start_brk/@brk which are used in do_brk but kernel lookups
2043 * for VMAs when updating these memvers so anything wrong written
2044 * here cause kernel to swear at userspace program but won't lead
2045 * to any problem in kernel itself
2046 */
2047
2048 spin_lock(&mm->arg_lock);
2049 mm->start_code = prctl_map.start_code;
2050 mm->end_code = prctl_map.end_code;
2051 mm->start_data = prctl_map.start_data;
2052 mm->end_data = prctl_map.end_data;
2053 mm->start_brk = prctl_map.start_brk;
2054 mm->brk = prctl_map.brk;
2055 mm->start_stack = prctl_map.start_stack;
2056 mm->arg_start = prctl_map.arg_start;
2057 mm->arg_end = prctl_map.arg_end;
2058 mm->env_start = prctl_map.env_start;
2059 mm->env_end = prctl_map.env_end;
2060 spin_unlock(&mm->arg_lock);
2061
2062 /*
2063 * Note this update of @saved_auxv is lockless thus
2064 * if someone reads this member in procfs while we're
2065 * updating -- it may get partly updated results. It's
2066 * known and acceptable trade off: we leave it as is to
2067 * not introduce additional locks here making the kernel
2068 * more complex.
2069 */
2070 if (prctl_map.auxv_size)
2071 memcpy(mm->saved_auxv, user_auxv, sizeof(user_auxv));
2072
2073 up_read(&mm->mmap_sem);
2074 return 0;
2075 }
2076 #endif /* CONFIG_CHECKPOINT_RESTORE */
2077
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27888 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-doc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
linux-mm@kvack.org, Eric Dumazet <edumazet@google.com>,
linux-kselftest@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, Jacob Bramley <Jacob.Bramley@arm.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
Evgeniy Stepanov <eugenis@google.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Kees Cook <keescook@chromium.org>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Andrey Konovalov <andreyknvl@google.com>,
Lee Smith <Lee.Smith@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kostya Serebryany <kcc@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kbuild-all@01.org,
netdev@vger.kernel.org,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
"David S. Miller" <davem@davemloft.net>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v11 09/14] kernel, arm64: untag user pointers in prctl_set_mm*
Date: Sun, 17 Mar 2019 03:31:52 +0800 [thread overview]
Message-ID: <201903170317.IWsOYXBe%lkp@intel.com> (raw)
In-Reply-To: <c4d65de9867cb3349af6800242da0de751260c6c.1552679409.git.andreyknvl@google.com>
[-- Attachment #1: Type: text/plain, Size: 6839 bytes --]
Hi Andrey,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/uaccess-add-untagged_addr-definition-for-other-arches/20190317-015913
config: x86_64-randconfig-x012-201911 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
kernel/sys.c: In function 'prctl_set_mm_map':
>> kernel/sys.c:1996:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_code = untagged_addr(prctl_map.start_code);
^~
kernel/sys.c:1997:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_code = untagged_addr(prctl_map.end_code);
^~
kernel/sys.c:1998:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_data = untagged_addr(prctl_map.start_data);
^~
kernel/sys.c:1999:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->end_data = untagged_addr(prctl_map.end_data);
^~
kernel/sys.c:2000:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
^~
kernel/sys.c:2001:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->brk = untagged_addr(prctl_map.brk);
^~
kernel/sys.c:2002:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
^~
kernel/sys.c:2003:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
^~
kernel/sys.c:2004:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
^~
kernel/sys.c:2005:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_start = untagged_addr(prctl_map.env_start);
^~
kernel/sys.c:2006:11: error: invalid type argument of '->' (have 'struct prctl_mm_map')
prctl_map->env_end = untagged_addr(prctl_map.env_end);
^~
vim +1996 kernel/sys.c
1974
1975 #ifdef CONFIG_CHECKPOINT_RESTORE
1976 static int prctl_set_mm_map(int opt, const void __user *addr, unsigned long data_size)
1977 {
1978 struct prctl_mm_map prctl_map = { .exe_fd = (u32)-1, };
1979 unsigned long user_auxv[AT_VECTOR_SIZE];
1980 struct mm_struct *mm = current->mm;
1981 int error;
1982
1983 BUILD_BUG_ON(sizeof(user_auxv) != sizeof(mm->saved_auxv));
1984 BUILD_BUG_ON(sizeof(struct prctl_mm_map) > 256);
1985
1986 if (opt == PR_SET_MM_MAP_SIZE)
1987 return put_user((unsigned int)sizeof(prctl_map),
1988 (unsigned int __user *)addr);
1989
1990 if (data_size != sizeof(prctl_map))
1991 return -EINVAL;
1992
1993 if (copy_from_user(&prctl_map, addr, sizeof(prctl_map)))
1994 return -EFAULT;
1995
> 1996 prctl_map->start_code = untagged_addr(prctl_map.start_code);
1997 prctl_map->end_code = untagged_addr(prctl_map.end_code);
1998 prctl_map->start_data = untagged_addr(prctl_map.start_data);
1999 prctl_map->end_data = untagged_addr(prctl_map.end_data);
2000 prctl_map->start_brk = untagged_addr(prctl_map.start_brk);
2001 prctl_map->brk = untagged_addr(prctl_map.brk);
2002 prctl_map->start_stack = untagged_addr(prctl_map.start_stack);
2003 prctl_map->arg_start = untagged_addr(prctl_map.arg_start);
2004 prctl_map->arg_end = untagged_addr(prctl_map.arg_end);
2005 prctl_map->env_start = untagged_addr(prctl_map.env_start);
2006 prctl_map->env_end = untagged_addr(prctl_map.env_end);
2007
2008 error = validate_prctl_map(&prctl_map);
2009 if (error)
2010 return error;
2011
2012 if (prctl_map.auxv_size) {
2013 memset(user_auxv, 0, sizeof(user_auxv));
2014 if (copy_from_user(user_auxv,
2015 (const void __user *)prctl_map.auxv,
2016 prctl_map.auxv_size))
2017 return -EFAULT;
2018
2019 /* Last entry must be AT_NULL as specification requires */
2020 user_auxv[AT_VECTOR_SIZE - 2] = AT_NULL;
2021 user_auxv[AT_VECTOR_SIZE - 1] = AT_NULL;
2022 }
2023
2024 if (prctl_map.exe_fd != (u32)-1) {
2025 error = prctl_set_mm_exe_file(mm, prctl_map.exe_fd);
2026 if (error)
2027 return error;
2028 }
2029
2030 /*
2031 * arg_lock protects concurent updates but we still need mmap_sem for
2032 * read to exclude races with sys_brk.
2033 */
2034 down_read(&mm->mmap_sem);
2035
2036 /*
2037 * We don't validate if these members are pointing to
2038 * real present VMAs because application may have correspond
2039 * VMAs already unmapped and kernel uses these members for statistics
2040 * output in procfs mostly, except
2041 *
2042 * - @start_brk/@brk which are used in do_brk but kernel lookups
2043 * for VMAs when updating these memvers so anything wrong written
2044 * here cause kernel to swear at userspace program but won't lead
2045 * to any problem in kernel itself
2046 */
2047
2048 spin_lock(&mm->arg_lock);
2049 mm->start_code = prctl_map.start_code;
2050 mm->end_code = prctl_map.end_code;
2051 mm->start_data = prctl_map.start_data;
2052 mm->end_data = prctl_map.end_data;
2053 mm->start_brk = prctl_map.start_brk;
2054 mm->brk = prctl_map.brk;
2055 mm->start_stack = prctl_map.start_stack;
2056 mm->arg_start = prctl_map.arg_start;
2057 mm->arg_end = prctl_map.arg_end;
2058 mm->env_start = prctl_map.env_start;
2059 mm->env_end = prctl_map.env_end;
2060 spin_unlock(&mm->arg_lock);
2061
2062 /*
2063 * Note this update of @saved_auxv is lockless thus
2064 * if someone reads this member in procfs while we're
2065 * updating -- it may get partly updated results. It's
2066 * known and acceptable trade off: we leave it as is to
2067 * not introduce additional locks here making the kernel
2068 * more complex.
2069 */
2070 if (prctl_map.auxv_size)
2071 memcpy(mm->saved_auxv, user_auxv, sizeof(user_auxv));
2072
2073 up_read(&mm->mmap_sem);
2074 return 0;
2075 }
2076 #endif /* CONFIG_CHECKPOINT_RESTORE */
2077
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27888 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-16 19:31 UTC|newest]
Thread overview: 224+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 19:51 [PATCH v11 00/14] arm64: untag user pointers passed to the kernel Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` [PATCH v11 01/14] uaccess: add untagged_addr definition for other arches Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 02/14] arm64: untag user pointers in access_ok and __uaccess_mask_ptr Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 03/14] lib, arm64: untag user pointers in strn*_user Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-18 11:33 ` Kevin Brodsky
2019-03-18 11:33 ` Kevin Brodsky
2019-03-18 11:33 ` Kevin Brodsky
2019-03-18 11:33 ` kevin.brodsky
2019-03-18 11:33 ` Kevin Brodsky
2019-03-15 19:51 ` [PATCH v11 04/14] mm, arm64: untag user pointers passed to memory syscalls Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 05/14] mm, arm64: untag user pointers in mm/gup.c Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` [PATCH v11 06/14] fs, arm64: untag user pointers in copy_mount_options Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 07/14] fs, arm64: untag user pointers in fs/userfaultfd.c Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` [PATCH v11 08/14] net, arm64: untag user pointers in tcp_zerocopy_receive Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 20:03 ` Eric Dumazet
2019-03-15 20:03 ` Eric Dumazet
2019-03-15 20:03 ` Eric Dumazet
2019-03-15 20:03 ` eric.dumazet
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` Andrey Konovalov
2019-03-18 13:14 ` andreyknvl
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` Andrey Konovalov
2019-03-18 13:16 ` andreyknvl
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` Eric Dumazet
2019-03-18 14:44 ` edumazet
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` Andrey Konovalov
2019-03-18 16:08 ` andreyknvl
2019-03-15 20:03 ` Eric Dumazet
2019-03-15 19:51 ` [PATCH v11 09/14] kernel, arm64: untag user pointers in prctl_set_mm* Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-16 19:31 ` kbuild test robot [this message]
2019-03-16 19:31 ` kbuild test robot
2019-03-16 19:31 ` kbuild test robot
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` andreyknvl
2019-03-18 11:47 ` Kevin Brodsky
2019-03-18 11:47 ` Kevin Brodsky
2019-03-18 11:47 ` Kevin Brodsky
2019-03-18 11:47 ` kevin.brodsky
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` Andrey Konovalov
2019-03-18 16:53 ` andreyknvl
2019-03-18 11:47 ` Kevin Brodsky
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 10/14] tracing, arm64: untag user pointers in seq_print_user_ip Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 20:14 ` Steven Rostedt
2019-03-15 20:14 ` Steven Rostedt
2019-03-15 20:14 ` Steven Rostedt
2019-03-15 20:14 ` Steven Rostedt
2019-03-15 20:14 ` rostedt
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` Andrey Konovalov
2019-03-18 13:11 ` andreyknvl
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 11/14] uprobes, arm64: untag user pointers in find_active_uprobe Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` [PATCH v11 12/14] bpf, arm64: untag user pointers in stack_map_get_build_id_offset Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-15 19:51 ` [PATCH v11 13/14] arm64: update Documentation/arm64/tagged-pointers.txt Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-18 13:26 ` Kevin Brodsky
2019-03-18 13:26 ` Kevin Brodsky
2019-03-18 13:26 ` Kevin Brodsky
2019-03-18 13:26 ` kevin.brodsky
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` Andrey Konovalov
2019-03-18 16:59 ` andreyknvl
2019-03-18 13:26 ` Kevin Brodsky
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` [PATCH v11 14/14] selftests, arm64: add a selftest for passing tagged pointers to kernel Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` Andrey Konovalov
2019-03-15 19:51 ` andreyknvl
2019-03-18 16:35 ` [PATCH v2 0/4] arm64 relaxed ABI Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` vincenzo.frascino
2019-03-18 16:35 ` [PATCH v2 1/4] elf: Make AT_FLAGS arch configurable Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` vincenzo.frascino
2019-03-18 16:35 ` [PATCH v2 2/4] arm64: Define Documentation/arm64/elf_at_flags.txt Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` vincenzo.frascino
2019-03-22 6:22 ` Amit Daniel Kachhap
2019-03-22 6:22 ` Amit Daniel Kachhap
2019-03-22 6:22 ` Amit Daniel Kachhap
2019-03-22 6:22 ` Amit Daniel Kachhap
2019-03-22 6:22 ` Amit Daniel Kachhap
2019-03-22 6:22 ` amit.kachhap
2019-03-22 10:48 ` Catalin Marinas
2019-03-22 10:48 ` Catalin Marinas
2019-03-22 10:48 ` Catalin Marinas
2019-03-22 10:48 ` Catalin Marinas
2019-03-22 10:48 ` catalin.marinas
2019-03-22 15:52 ` Kevin Brodsky
2019-03-22 15:52 ` Kevin Brodsky
2019-03-22 15:52 ` Kevin Brodsky
2019-03-22 15:52 ` Kevin Brodsky
2019-03-22 15:52 ` kevin.brodsky
2019-04-03 16:50 ` Catalin Marinas
2019-04-03 16:50 ` Catalin Marinas
2019-04-03 16:50 ` Catalin Marinas
2019-04-03 16:50 ` Catalin Marinas
2019-04-03 16:50 ` catalin.marinas
2019-04-12 14:16 ` Kevin Brodsky
2019-04-12 14:16 ` Kevin Brodsky
2019-04-12 14:16 ` Kevin Brodsky
2019-04-12 14:16 ` Kevin Brodsky
2019-04-12 14:16 ` kevin.brodsky
2019-03-18 16:35 ` [PATCH v2 3/4] arm64: Relax Documentation/arm64/tagged-pointers.txt Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` vincenzo.frascino
2019-03-18 16:35 ` [PATCH v2 4/4] arm64: elf: Advertise relaxed ABI Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` Vincenzo Frascino
2019-03-18 16:35 ` vincenzo.frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903170317.IWsOYXBe%lkp@intel.com \
--to=lkp@intel.com \
--cc=Dave.Martin@arm.com \
--cc=Jacob.Bramley@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=andreyknvl@google.com \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=daniel@iogearbox.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eugenis@google.com \
--cc=kevin.brodsky@arm.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.