From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com,
jonathanh@nvidia.com, kishon@ti.com, catalin.marinas@arm.com,
will.deacon@arm.com, lorenzo.pieralisi@arm.com,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
mperttunen@nvidia.com, tiwai@suse.de, spujar@nvidia.com,
skomatineni@nvidia.com, liviu.dudau@arm.com, krzk@kernel.org,
heiko@sntech.de, horms+renesas@verge.net.au, olof@lixom.net,
maxime.ripard@bootlin.com, andy.gross@linaro.org,
bjorn.andersson@linaro.org, jagan@amarulasolutions.com,
enric.balletbo@collabora.com, ezequiel@collabora.com,
stefan.wahren@i2se.com, marc.w.gonzalez@free.fr,
l.stach@pengutronix.de, tpiepho@impinj.com,
hayashi.kunihiko@socionext.com, yue.wang@amlogic.com,
shawn.lin@rock-chips.com, xiaowei.bao@nxp.com,
linux-pci@vger.kernel.or
Subject: Re: [PATCH 03/10] PCI: dwc: Move config space capability search API
Date: Thu, 28 Mar 2019 13:33:20 +0100 [thread overview]
Message-ID: <20190328123320.GA5518@ulmo> (raw)
In-Reply-To: <1553613207-3988-4-git-send-email-vidyas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Tue, Mar 26, 2019 at 08:43:20PM +0530, Vidya Sagar wrote:
> move PCIe config space capability search API to common designware file
> as this can be used by both host and ep mode codes.
> It also adds extended capability search APIs.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 37 +------------
> drivers/pci/controller/dwc/pcie-designware.c | 73 +++++++++++++++++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 3 +
> 3 files changed, 78 insertions(+), 35 deletions(-)
Just out of curiosity: is there any reason why this driver needs to
reimplement this? Couldn't this be made to work using the standard
pci_find_next_capability() function?
Other than that it might be a good idea to split this into two patches,
one that moves the existing functionality to the common code and another
that adds the extra functionality.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com,
jonathanh@nvidia.com, kishon@ti.com, catalin.marinas@arm.com,
will.deacon@arm.com, lorenzo.pieralisi@arm.com,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
mperttunen@nvidia.com, tiwai@suse.de, spujar@nvidia.com,
skomatineni@nvidia.com, liviu.dudau@arm.com, krzk@kernel.org,
heiko@sntech.de, horms+renesas@verge.net.au, olof@lixom.net,
maxime.ripard@bootlin.com, andy.gross@linaro.org,
bjorn.andersson@linaro.org, jagan@amarulasolutions.com,
enric.balletbo@collabora.com, ezequiel@collabora.com,
stefan.wahren@i2se.com, marc.w.gonzalez@free.fr,
l.stach@pengutronix.de, tpiepho@impinj.com,
hayashi.kunihiko@socionext.com, yue.wang@amlogic.com,
shawn.lin@rock-chips.com, xiaowei.bao@nxp.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kthota@nvidia.com,
mmaddireddy@nvidia.com
Subject: Re: [PATCH 03/10] PCI: dwc: Move config space capability search API
Date: Thu, 28 Mar 2019 13:33:20 +0100 [thread overview]
Message-ID: <20190328123320.GA5518@ulmo> (raw)
In-Reply-To: <1553613207-3988-4-git-send-email-vidyas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Tue, Mar 26, 2019 at 08:43:20PM +0530, Vidya Sagar wrote:
> move PCIe config space capability search API to common designware file
> as this can be used by both host and ep mode codes.
> It also adds extended capability search APIs.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 37 +------------
> drivers/pci/controller/dwc/pcie-designware.c | 73 +++++++++++++++++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 3 +
> 3 files changed, 78 insertions(+), 35 deletions(-)
Just out of curiosity: is there any reason why this driver needs to
reimplement this? Couldn't this be made to work using the standard
pci_find_next_capability() function?
Other than that it might be a good idea to split this into two patches,
one that moves the existing functionality to the common code and another
that adds the extra functionality.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: mark.rutland@arm.com, heiko@sntech.de,
hayashi.kunihiko@socionext.com, maxime.ripard@bootlin.com,
catalin.marinas@arm.com, spujar@nvidia.com, will.deacon@arm.com,
kthota@nvidia.com, mperttunen@nvidia.com,
linux-tegra@vger.kernel.org, jonathanh@nvidia.com,
stefan.wahren@i2se.com, lorenzo.pieralisi@arm.com,
krzk@kernel.org, kishon@ti.com, tiwai@suse.de,
jagan@amarulasolutions.com, linux-pci@vger.kernel.org,
andy.gross@linaro.org, shawn.lin@rock-chips.com,
devicetree@vger.kernel.org, mmaddireddy@nvidia.com,
marc.w.gonzalez@free.fr, liviu.dudau@arm.com,
yue.wang@amlogic.com, enric.balletbo@collabora.com,
robh+dt@kernel.org, bhelgaas@google.com,
horms+renesas@verge.net.au, bjorn.andersson@linaro.org,
ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org,
xiaowei.bao@nxp.com, gustavo.pimentel@synopsys.com,
linux-kernel@vger.kernel.org, skomatineni@nvidia.com,
jingoohan1@gmail.com, olof@lixom.net, tpiepho@impinj.com,
l.stach@pengutronix.de
Subject: Re: [PATCH 03/10] PCI: dwc: Move config space capability search API
Date: Thu, 28 Mar 2019 13:33:20 +0100 [thread overview]
Message-ID: <20190328123320.GA5518@ulmo> (raw)
In-Reply-To: <1553613207-3988-4-git-send-email-vidyas@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 942 bytes --]
On Tue, Mar 26, 2019 at 08:43:20PM +0530, Vidya Sagar wrote:
> move PCIe config space capability search API to common designware file
> as this can be used by both host and ep mode codes.
> It also adds extended capability search APIs.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 37 +------------
> drivers/pci/controller/dwc/pcie-designware.c | 73 +++++++++++++++++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 3 +
> 3 files changed, 78 insertions(+), 35 deletions(-)
Just out of curiosity: is there any reason why this driver needs to
reimplement this? Couldn't this be made to work using the standard
pci_find_next_capability() function?
Other than that it might be a good idea to split this into two patches,
one that moves the existing functionality to the common code and another
that adds the extra functionality.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-28 12:33 UTC|newest]
Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:13 [PATCH 00/10] Add Tegra194 PCIe support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 01/10] PCI: save pci_bus pointer in pcie_port structure Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 7:18 ` Jisheng Zhang
2019-03-28 7:18 ` Jisheng Zhang
2019-03-28 7:38 ` Vidya Sagar
2019-03-28 7:38 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 02/10] PCI: perform dbi regs write lock towards the end Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 03/10] PCI: dwc: Move config space capability search API Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 12:33 ` Thierry Reding [this message]
2019-03-28 12:33 ` Thierry Reding
2019-03-28 12:33 ` Thierry Reding
2019-04-01 11:46 ` Vidya Sagar
2019-04-01 11:46 ` Vidya Sagar
2019-04-01 11:46 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 04/10] PCI: Add #defines for PCIe spec r4.0 features Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 05/10] dt-bindings: PCI: tegra: Add device tree support for T194 Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:53 ` Vidya Sagar
2019-03-27 10:53 ` Vidya Sagar
2019-03-27 10:53 ` Vidya Sagar
2019-03-28 13:15 ` Thierry Reding
2019-03-28 13:15 ` Thierry Reding
2019-03-28 13:15 ` Thierry Reding
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 15:07 ` Thierry Reding
2019-04-01 15:07 ` Thierry Reding
2019-04-01 15:07 ` Thierry Reding
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 14:35 ` Thierry Reding
2019-04-02 14:35 ` Thierry Reding
2019-04-02 14:35 ` Thierry Reding
2019-04-03 6:22 ` Vidya Sagar
2019-04-03 6:22 ` Vidya Sagar
2019-04-03 6:22 ` Vidya Sagar
2019-04-02 19:21 ` Bjorn Helgaas
2019-04-02 19:21 ` Bjorn Helgaas
2019-04-02 19:21 ` Bjorn Helgaas
2019-03-31 6:42 ` Rob Herring
2019-03-31 6:42 ` Rob Herring
2019-03-31 6:42 ` Rob Herring
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 14:31 ` Thierry Reding
2019-04-01 14:31 ` Thierry Reding
2019-04-01 14:31 ` Thierry Reding
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 14:20 ` Thierry Reding
2019-04-02 14:20 ` Thierry Reding
2019-04-02 14:20 ` Thierry Reding
2019-04-03 5:29 ` Vidya Sagar
2019-04-03 5:29 ` Vidya Sagar
2019-04-03 5:29 ` Vidya Sagar
2019-04-08 18:29 ` Trent Piepho
2019-04-08 18:29 ` Trent Piepho
2019-04-09 11:07 ` Vidya Sagar
2019-04-09 11:07 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 06/10] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 16:59 ` Thierry Reding
2019-03-28 16:59 ` Thierry Reding
2019-03-28 16:59 ` Thierry Reding
2019-04-01 12:37 ` Vidya Sagar
2019-04-01 12:37 ` Vidya Sagar
2019-04-01 12:37 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 07/10] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 08/10] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 10:45 ` Vidya Sagar
2019-04-03 10:45 ` Vidya Sagar
2019-04-03 10:45 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:07 ` Jon Hunter
2019-03-27 10:07 ` Jon Hunter
2019-03-27 10:07 ` Jon Hunter
2019-03-29 20:52 ` Bjorn Helgaas
2019-03-29 20:52 ` Bjorn Helgaas
2019-03-29 20:52 ` Bjorn Helgaas
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 14:14 ` Thierry Reding
2019-04-02 14:14 ` Thierry Reding
2019-04-02 14:14 ` Thierry Reding
2019-04-03 9:15 ` Vidya Sagar
2019-04-03 9:15 ` Vidya Sagar
2019-04-03 9:15 ` Vidya Sagar
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-04 19:53 ` Vidya Sagar
2019-04-04 19:53 ` Vidya Sagar
2019-04-04 19:53 ` Vidya Sagar
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 11:35 ` Liviu Dudau
2019-04-10 11:35 ` Liviu Dudau
2019-04-10 11:35 ` Liviu Dudau
2019-03-26 15:13 ` [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 12:26 ` Jon Hunter
2019-03-27 12:26 ` Jon Hunter
2019-03-27 12:26 ` Jon Hunter
2019-03-28 8:19 ` Jisheng Zhang
2019-03-28 8:19 ` Jisheng Zhang
2019-04-01 12:45 ` Vidya Sagar
2019-04-01 12:45 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328123320.GA5518@ulmo \
--to=thierry.reding@gmail.com \
--cc=andy.gross@linaro.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.or \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mperttunen@nvidia.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=skomatineni@nvidia.com \
--cc=spujar@nvidia.com \
--cc=stefan.wahren@i2se.com \
--cc=tiwai@suse.de \
--cc=tpiepho@impinj.com \
--cc=vidyas@nvidia.com \
--cc=will.deacon@arm.com \
--cc=xiaowei.bao@nxp.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.