From: Jon Hunter <jonathanh@nvidia.com>
To: Vidya Sagar <vidyas@nvidia.com>,
bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, kishon@ti.com, catalin.marinas@arm.com,
will.deacon@arm.com, lorenzo.pieralisi@arm.com,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
mperttunen@nvidia.com, tiwai@suse.de, spujar@nvidia.com,
skomatineni@nvidia.com, liviu.dudau@arm.com, krzk@kernel.org,
heiko@sntech.de, horms+renesas@verge.net.au, olof@lixom.net,
maxime.ripard@bootlin.com, andy.gross@linaro.org,
bjorn.andersson@linaro.org, jagan@amarulasolutions.com,
enric.balletbo@collabora.com, ezequiel@collabora.com,
stefan.wahren@i2se.com, marc.w.gonzalez@free.fr,
l.stach@pengutronix.de, tpiepho@impinj.com,
hayashi.kunihiko@socionext.co
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kthota@nvidia.com,
mmaddireddy@nvidia.com
Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig
Date: Wed, 27 Mar 2019 12:26:49 +0000 [thread overview]
Message-ID: <c5ca34fe-4290-d9b7-cda3-23b4a11ec5d8@nvidia.com> (raw)
In-Reply-To: <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com>
On 27/03/2019 10:12, Vidya Sagar wrote:
> On 3/27/2019 3:38 PM, Jon Hunter wrote:
>>
>> On 26/03/2019 15:13, Vidya Sagar wrote:
>>> Add PCIe host controller driver for DesignWare core based
>>> PCIe controller IP present in Tegra194.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 2d9c39033c1a..2ddea5c4e87d 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y
>>> CONFIG_PCIE_ARMADA_8K=y
>>> CONFIG_PCIE_KIRIN=y
>>> CONFIG_PCIE_HISI_STB=y
>>> +CONFIG_PCIE_TEGRA194=y
>>> CONFIG_ARM64_VA_BITS_48=y
>>> CONFIG_SCHED_MC=y
>>> CONFIG_NUMA=y
>>
>> Maybe building as a module is more appropriate here as I am not sure
>> that anyone else will want this built-in and it is not critical to
>> booting AFAIK.
> Since the DesignWare core framework doesn't yet have support for making
> this
> as a module, I added it as a built-in driver. I'll switch it to a module
> once support is available.
Ah I see. We often get reports/patches if a driver has a removal
function but is defined in the Kconfig to only support being built-in.
Does the designware core just need to export some symbols to support it
being a module? If so it maybe worth adding these as part of the series
to see if it is acceptable, otherwise it might not get done and there is
no point us supporting it as a module.
Cheers
Jon
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Vidya Sagar <vidyas@nvidia.com>, <bhelgaas@google.com>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<thierry.reding@gmail.com>, <kishon@ti.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<lorenzo.pieralisi@arm.com>, <jingoohan1@gmail.com>,
<gustavo.pimentel@synopsys.com>, <mperttunen@nvidia.com>,
<tiwai@suse.de>, <spujar@nvidia.com>, <skomatineni@nvidia.com>,
<liviu.dudau@arm.com>, <krzk@kernel.org>, <heiko@sntech.de>,
<horms+renesas@verge.net.au>, <olof@lixom.net>,
<maxime.ripard@bootlin.com>, <andy.gross@linaro.org>,
<bjorn.andersson@linaro.org>, <jagan@amarulasolutions.com>,
<enric.balletbo@collabora.com>, <ezequiel@collabora.com>,
<stefan.wahren@i2se.com>, <marc.w.gonzalez@free.fr>,
<l.stach@pengutronix.de>, <tpiepho@impinj.com>,
<hayashi.kunihiko@socionext.com>, <yue.wang@amlogic.com>,
<shawn.lin@rock-chips.com>, <xiaowei.bao@nxp.com>
Cc: <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>
Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig
Date: Wed, 27 Mar 2019 12:26:49 +0000 [thread overview]
Message-ID: <c5ca34fe-4290-d9b7-cda3-23b4a11ec5d8@nvidia.com> (raw)
In-Reply-To: <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com>
On 27/03/2019 10:12, Vidya Sagar wrote:
> On 3/27/2019 3:38 PM, Jon Hunter wrote:
>>
>> On 26/03/2019 15:13, Vidya Sagar wrote:
>>> Add PCIe host controller driver for DesignWare core based
>>> PCIe controller IP present in Tegra194.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 2d9c39033c1a..2ddea5c4e87d 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y
>>> CONFIG_PCIE_ARMADA_8K=y
>>> CONFIG_PCIE_KIRIN=y
>>> CONFIG_PCIE_HISI_STB=y
>>> +CONFIG_PCIE_TEGRA194=y
>>> CONFIG_ARM64_VA_BITS_48=y
>>> CONFIG_SCHED_MC=y
>>> CONFIG_NUMA=y
>>
>> Maybe building as a module is more appropriate here as I am not sure
>> that anyone else will want this built-in and it is not critical to
>> booting AFAIK.
> Since the DesignWare core framework doesn't yet have support for making
> this
> as a module, I added it as a built-in driver. I'll switch it to a module
> once support is available.
Ah I see. We often get reports/patches if a driver has a removal
function but is defined in the Kconfig to only support being built-in.
Does the designware core just need to export some symbols to support it
being a module? If so it maybe worth adding these as part of the series
to see if it is acceptable, otherwise it might not get done and there is
no point us supporting it as a module.
Cheers
Jon
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Vidya Sagar <vidyas@nvidia.com>, <bhelgaas@google.com>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<thierry.reding@gmail.com>, <kishon@ti.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<lorenzo.pieralisi@arm.com>, <jingoohan1@gmail.com>,
<gustavo.pimentel@synopsys.com>, <mperttunen@nvidia.com>,
<tiwai@suse.de>, <spujar@nvidia.com>, <skomatineni@nvidia.com>,
<liviu.dudau@arm.com>, <krzk@kernel.org>, <heiko@sntech.de>,
<horms+renesas@verge.net.au>, <olof@lixom.net>,
<maxime.ripard@bootlin.com>, <andy.gross@linaro.org>,
<bjorn.andersson@linaro.org>, <jagan@amarulasolutions.com>,
<enric.balletbo@collabora.com>, <ezequiel@collabora.com>,
<stefan.wahren@i2se.com>, <marc.w.gonzalez@free.fr>,
<l.stach@pengutronix.de>, <tpiepho@impinj.com>,
<hayashi.kunihiko@socionext.com>, <yue.wang@amlogic.com>,
<shawn.lin@rock-chips.com>, <xiaowei.bao@nxp.com>
Cc: devicetree@vger.kernel.org, mmaddireddy@nvidia.com,
kthota@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig
Date: Wed, 27 Mar 2019 12:26:49 +0000 [thread overview]
Message-ID: <c5ca34fe-4290-d9b7-cda3-23b4a11ec5d8@nvidia.com> (raw)
In-Reply-To: <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com>
On 27/03/2019 10:12, Vidya Sagar wrote:
> On 3/27/2019 3:38 PM, Jon Hunter wrote:
>>
>> On 26/03/2019 15:13, Vidya Sagar wrote:
>>> Add PCIe host controller driver for DesignWare core based
>>> PCIe controller IP present in Tegra194.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 2d9c39033c1a..2ddea5c4e87d 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y
>>> CONFIG_PCIE_ARMADA_8K=y
>>> CONFIG_PCIE_KIRIN=y
>>> CONFIG_PCIE_HISI_STB=y
>>> +CONFIG_PCIE_TEGRA194=y
>>> CONFIG_ARM64_VA_BITS_48=y
>>> CONFIG_SCHED_MC=y
>>> CONFIG_NUMA=y
>>
>> Maybe building as a module is more appropriate here as I am not sure
>> that anyone else will want this built-in and it is not critical to
>> booting AFAIK.
> Since the DesignWare core framework doesn't yet have support for making
> this
> as a module, I added it as a built-in driver. I'll switch it to a module
> once support is available.
Ah I see. We often get reports/patches if a driver has a removal
function but is defined in the Kconfig to only support being built-in.
Does the designware core just need to export some symbols to support it
being a module? If so it maybe worth adding these as part of the series
to see if it is acceptable, otherwise it might not get done and there is
no point us supporting it as a module.
Cheers
Jon
--
nvpublic
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-27 12:26 UTC|newest]
Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:13 [PATCH 00/10] Add Tegra194 PCIe support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 01/10] PCI: save pci_bus pointer in pcie_port structure Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 7:18 ` Jisheng Zhang
2019-03-28 7:18 ` Jisheng Zhang
2019-03-28 7:38 ` Vidya Sagar
2019-03-28 7:38 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 02/10] PCI: perform dbi regs write lock towards the end Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 03/10] PCI: dwc: Move config space capability search API Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 12:33 ` Thierry Reding
2019-03-28 12:33 ` Thierry Reding
2019-03-28 12:33 ` Thierry Reding
2019-04-01 11:46 ` Vidya Sagar
2019-04-01 11:46 ` Vidya Sagar
2019-04-01 11:46 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 04/10] PCI: Add #defines for PCIe spec r4.0 features Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 05/10] dt-bindings: PCI: tegra: Add device tree support for T194 Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:53 ` Vidya Sagar
2019-03-27 10:53 ` Vidya Sagar
2019-03-27 10:53 ` Vidya Sagar
2019-03-28 13:15 ` Thierry Reding
2019-03-28 13:15 ` Thierry Reding
2019-03-28 13:15 ` Thierry Reding
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 15:07 ` Thierry Reding
2019-04-01 15:07 ` Thierry Reding
2019-04-01 15:07 ` Thierry Reding
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 14:35 ` Thierry Reding
2019-04-02 14:35 ` Thierry Reding
2019-04-02 14:35 ` Thierry Reding
2019-04-03 6:22 ` Vidya Sagar
2019-04-03 6:22 ` Vidya Sagar
2019-04-03 6:22 ` Vidya Sagar
2019-04-02 19:21 ` Bjorn Helgaas
2019-04-02 19:21 ` Bjorn Helgaas
2019-04-02 19:21 ` Bjorn Helgaas
2019-03-31 6:42 ` Rob Herring
2019-03-31 6:42 ` Rob Herring
2019-03-31 6:42 ` Rob Herring
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 14:31 ` Thierry Reding
2019-04-01 14:31 ` Thierry Reding
2019-04-01 14:31 ` Thierry Reding
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 14:20 ` Thierry Reding
2019-04-02 14:20 ` Thierry Reding
2019-04-02 14:20 ` Thierry Reding
2019-04-03 5:29 ` Vidya Sagar
2019-04-03 5:29 ` Vidya Sagar
2019-04-03 5:29 ` Vidya Sagar
2019-04-08 18:29 ` Trent Piepho
2019-04-08 18:29 ` Trent Piepho
2019-04-09 11:07 ` Vidya Sagar
2019-04-09 11:07 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 06/10] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-28 16:59 ` Thierry Reding
2019-03-28 16:59 ` Thierry Reding
2019-03-28 16:59 ` Thierry Reding
2019-04-01 12:37 ` Vidya Sagar
2019-04-01 12:37 ` Vidya Sagar
2019-04-01 12:37 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 07/10] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 08/10] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 10:45 ` Vidya Sagar
2019-04-03 10:45 ` Vidya Sagar
2019-04-03 10:45 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:07 ` Jon Hunter
2019-03-27 10:07 ` Jon Hunter
2019-03-27 10:07 ` Jon Hunter
2019-03-29 20:52 ` Bjorn Helgaas
2019-03-29 20:52 ` Bjorn Helgaas
2019-03-29 20:52 ` Bjorn Helgaas
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 14:14 ` Thierry Reding
2019-04-02 14:14 ` Thierry Reding
2019-04-02 14:14 ` Thierry Reding
2019-04-03 9:15 ` Vidya Sagar
2019-04-03 9:15 ` Vidya Sagar
2019-04-03 9:15 ` Vidya Sagar
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-04 19:53 ` Vidya Sagar
2019-04-04 19:53 ` Vidya Sagar
2019-04-04 19:53 ` Vidya Sagar
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 11:35 ` Liviu Dudau
2019-04-10 11:35 ` Liviu Dudau
2019-04-10 11:35 ` Liviu Dudau
2019-03-26 15:13 ` [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-26 15:13 ` Vidya Sagar
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 12:26 ` Jon Hunter [this message]
2019-03-27 12:26 ` Jon Hunter
2019-03-27 12:26 ` Jon Hunter
2019-03-28 8:19 ` Jisheng Zhang
2019-03-28 8:19 ` Jisheng Zhang
2019-04-01 12:45 ` Vidya Sagar
2019-04-01 12:45 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ca34fe-4290-d9b7-cda3-23b4a11ec5d8@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andy.gross@linaro.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hayashi.kunihiko@socionext.co \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=kthota@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=spujar@nvidia.com \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.de \
--cc=tpiepho@impinj.com \
--cc=vidyas@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.