All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Yangtao Li <tiny.windzz@gmail.com>,
	vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
	rjw@rjwysocki.net, davem@davemloft.net,
	mchehab+samsung@kernel.org, gregkh@linuxfoundation.org,
	nicolas.ferre@microchip.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver
Date: Wed, 17 Apr 2019 10:31:16 +0200	[thread overview]
Message-ID: <20190417083116.xgwglxogy2zqdghh@flea> (raw)
In-Reply-To: <20190417020830.f5empr3rr3ifbstl@vireshk-mac-ubuntu>

[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

On Wed, Apr 17, 2019 at 07:38:30AM +0530, Viresh Kumar wrote:
> On 16-04-19, 11:52, Yangtao Li wrote:
> > Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo.
> >
> > Yangtao Li (2):
> >   cpufreq: Add sunxi nvmem based CPU scaling driver
> >   dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points
> >
> >  .../bindings/opp/sun50i-nvmem-cpufreq.txt     | 167 +++++++++++++
> >  MAINTAINERS                                   |   7 +
> >  drivers/cpufreq/Kconfig.arm                   |  12 +
> >  drivers/cpufreq/Makefile                      |   1 +
> >  drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +
> >  drivers/cpufreq/sun50i-cpufreq-nvmem.c        | 226 ++++++++++++++++++
> >  6 files changed, 415 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/opp/sun50i-nvmem-cpufreq.txt
> >  create mode 100644 drivers/cpufreq/sun50i-cpufreq-nvmem.c
> >
> > ---
> > v4:
> > -I removed this sunxi_cpufreq_soc_data structure for now.
>
> Why this change ?

It's used on a single SoC for now, so it's impossible to know at this
point what to put in that structure in the first place.

Of course, that would need to be brought back if we ever have two SoCs
to support and that we know which differences there is.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: nm@ti.com, mark.rutland@arm.com, linux-pm@vger.kernel.org,
	Yangtao Li <tiny.windzz@gmail.com>,
	vireshk@kernel.org, rjw@rjwysocki.net,
	linux-kernel@vger.kernel.org, sboyd@kernel.org, wens@csie.org,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	gregkh@linuxfoundation.org, mchehab+samsung@kernel.org,
	davem@davemloft.net, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver
Date: Wed, 17 Apr 2019 10:31:16 +0200	[thread overview]
Message-ID: <20190417083116.xgwglxogy2zqdghh@flea> (raw)
In-Reply-To: <20190417020830.f5empr3rr3ifbstl@vireshk-mac-ubuntu>


[-- Attachment #1.1: Type: text/plain, Size: 1360 bytes --]

On Wed, Apr 17, 2019 at 07:38:30AM +0530, Viresh Kumar wrote:
> On 16-04-19, 11:52, Yangtao Li wrote:
> > Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo.
> >
> > Yangtao Li (2):
> >   cpufreq: Add sunxi nvmem based CPU scaling driver
> >   dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points
> >
> >  .../bindings/opp/sun50i-nvmem-cpufreq.txt     | 167 +++++++++++++
> >  MAINTAINERS                                   |   7 +
> >  drivers/cpufreq/Kconfig.arm                   |  12 +
> >  drivers/cpufreq/Makefile                      |   1 +
> >  drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +
> >  drivers/cpufreq/sun50i-cpufreq-nvmem.c        | 226 ++++++++++++++++++
> >  6 files changed, 415 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/opp/sun50i-nvmem-cpufreq.txt
> >  create mode 100644 drivers/cpufreq/sun50i-cpufreq-nvmem.c
> >
> > ---
> > v4:
> > -I removed this sunxi_cpufreq_soc_data structure for now.
>
> Why this change ?

It's used on a single SoC for now, so it's impossible to know at this
point what to put in that structure in the first place.

Of course, that would need to be brought back if we ever have two SoCs
to support and that we know which differences there is.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-17  8:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 15:52 [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver Yangtao Li
2019-04-16 15:52 ` Yangtao Li
2019-04-16 15:52 ` [PATCH v4 1/2] " Yangtao Li
2019-04-16 15:52   ` Yangtao Li
2019-04-17  8:32   ` Maxime Ripard
2019-04-17  8:32     ` Maxime Ripard
2019-04-16 15:52 ` [PATCH v4 2/2] dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points Yangtao Li
2019-04-16 15:52   ` [PATCH v4 2/2] dt-bindings: cpufreq: Document allwinner, sun50i-h6-operating-points Yangtao Li
2019-04-17  2:09   ` [PATCH v4 2/2] dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points Viresh Kumar
2019-04-17  2:09     ` Viresh Kumar
2019-04-17  8:30   ` Maxime Ripard
2019-04-17  8:30     ` Maxime Ripard
2019-04-18 13:10     ` Frank Lee
2019-04-18 13:10       ` [PATCH v4 2/2] dt-bindings: cpufreq: Document allwinner, sun50i-h6-operating-points Frank Lee
2019-04-17  2:08 ` [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver Viresh Kumar
2019-04-17  2:08   ` Viresh Kumar
2019-04-17  8:31   ` Maxime Ripard [this message]
2019-04-17  8:31     ` Maxime Ripard
2019-04-17 14:27     ` Viresh Kumar
2019-04-17 14:27       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417083116.xgwglxogy2zqdghh@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tiny.windzz@gmail.com \
    --cc=viresh.kumar@linaro.org \
    --cc=vireshk@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.