From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: grygorii.strashko@ti.com, linux-omap@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Linux Netdev List <netdev@vger.kernel.org>,
ilias.apalodimas@linaro.org, hawk@kernel.org,
xdp-newbies@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
aniel@iogearbox.net, John Fastabend <john.fastabend@gmail.com>
Subject: Re: [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support
Date: Thu, 18 Apr 2019 21:30:44 +0300 [thread overview]
Message-ID: <20190418183043.GD27879@khorivan> (raw)
In-Reply-To: <20190418104111.559a0e74@cakuba.netronome.com>
On Thu, Apr 18, 2019 at 10:41:11AM -0700, Jakub Kicinski wrote:
>On Thu, 18 Apr 2019 12:40:10 +0300, Ivan Khoronzhuk wrote:
>> >work? The stack's TX ring has a lock, and can be used from any CPU,
>> >while XDP TX rings are per-PCU, no?
>> Yes and no.
>> am572 has more queues then CPU num, How I can choose tx queue not based on CPU
>> num? It's always shared and has to have lock, and cpdma is done in this way.
>
>Oh, I see, you already have another lock.
>
>> Here another thing bothering me, I send it to queue 0 always, instead of
>> taking cpu num. Not sure about this, but I expect to have some tx queue
>> not bind to cpu and didn't find a way it can be changed dynamically in
>> redirect.
>
>Not sure I understand :)
I mean, is there a capability to choose tx queue while XDP_REDIRECT or XDP_TX.
From what I've seen it's taken by:
qidx = smp_processor_id();
What if I need to send classified traffic to hw queue 4 for instance...
--
Regards,
Ivan Khoronzhuk
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: grygorii.strashko@ti.com, linux-omap@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Linux Netdev List <netdev@vger.kernel.org>,
ilias.apalodimas@linaro.org, hawk@kernel.org,
xdp-newbies@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
aniel@iogearbox.net, John Fastabend <john.fastabend@gmail.com>
Subject: Re: [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support
Date: Thu, 18 Apr 2019 21:30:44 +0300 [thread overview]
Message-ID: <20190418183043.GD27879@khorivan> (raw)
In-Reply-To: <20190418104111.559a0e74@cakuba.netronome.com>
On Thu, Apr 18, 2019 at 10:41:11AM -0700, Jakub Kicinski wrote:
>On Thu, 18 Apr 2019 12:40:10 +0300, Ivan Khoronzhuk wrote:
>> >work? The stack's TX ring has a lock, and can be used from any CPU,
>> >while XDP TX rings are per-PCU, no?
>> Yes and no.
>> am572 has more queues then CPU num, How I can choose tx queue not based on CPU
>> num? It's always shared and has to have lock, and cpdma is done in this way.
>
>Oh, I see, you already have another lock.
>
>> Here another thing bothering me, I send it to queue 0 always, instead of
>> taking cpu num. Not sure about this, but I expect to have some tx queue
>> not bind to cpu and didn't find a way it can be changed dynamically in
>> redirect.
>
>Not sure I understand :)
I mean, is there a capability to choose tx queue while XDP_REDIRECT or XDP_TX.
>From what I've seen it's taken by:
qidx = smp_processor_id();
What if I need to send classified traffic to hw queue 4 for instance...
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2019-04-18 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 17:49 [RFC PATCH 0/3] net: ethernet: ti: cpsw: Add XDP support Ivan Khoronzhuk
2019-04-17 17:49 ` [RFC PATCH 1/3] net: ethernet: ti: davinci_cpdma: add dma mapped submit Ivan Khoronzhuk
2019-04-17 17:49 ` [RFC PATCH 2/3] net: ethernet: ti: davinci_cpdma: return handler status Ivan Khoronzhuk
2019-04-17 17:49 ` [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support Ivan Khoronzhuk
2019-04-17 22:46 ` Jakub Kicinski
2019-04-18 9:40 ` Ivan Khoronzhuk
2019-04-18 17:41 ` Jakub Kicinski
2019-04-18 18:30 ` Ivan Khoronzhuk [this message]
2019-04-18 18:30 ` Ivan Khoronzhuk
2019-04-18 18:44 ` Jakub Kicinski
2019-04-19 8:31 ` Ilias Apalodimas
2019-04-19 10:42 ` Ivan Khoronzhuk
2019-04-18 6:12 ` [RFC PATCH 0/3] net: ethernet: ti: cpsw: Add " Björn Töpel
2019-04-18 9:47 ` Ivan Khoronzhuk
2019-04-19 8:24 ` Grygorii Strashko
2019-04-19 8:24 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418183043.GD27879@khorivan \
--to=ivan.khoronzhuk@linaro.org \
--cc=aniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.