From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical
Date: Tue, 23 Apr 2019 11:15:00 +0200 [thread overview]
Message-ID: <20190423091503.10847-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20190423091503.10847-1-narmstrong@baylibre.com>
On Amlogic Meson G12b platform, the fclk_div3 seems to be necessary for
the system to operate correctly.
Disabling it cause the entire system to freeze, including peripherals.
This patch patch marks this clock as critical, fixing boot on G12b platforms.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/clk/meson/g12a.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 4bc16868b471..2e16cdf71ab4 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -1060,6 +1060,16 @@ static struct clk_regmap g12a_fclk_div3 = {
.ops = &clk_regmap_gate_ops,
.parent_names = (const char *[]){ "fclk_div3_div" },
.num_parents = 1,
+ /*
+ * This clock is used by the resident firmware and is required
+ * by the platform to operate correctly.
+ * Until the following condition are met, we need this clock to
+ * be marked as critical:
+ * a) Mark the clock used by a firmware resource, if possible
+ * b) CCF has a clock hand-off mechanism to make the sure the
+ * clock stays on until the proper driver comes along
+ */
+ .flags = CLK_IS_CRITICAL,
},
};
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical
Date: Tue, 23 Apr 2019 11:15:00 +0200 [thread overview]
Message-ID: <20190423091503.10847-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20190423091503.10847-1-narmstrong@baylibre.com>
On Amlogic Meson G12b platform, the fclk_div3 seems to be necessary for
the system to operate correctly.
Disabling it cause the entire system to freeze, including peripherals.
This patch patch marks this clock as critical, fixing boot on G12b platforms.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/clk/meson/g12a.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 4bc16868b471..2e16cdf71ab4 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -1060,6 +1060,16 @@ static struct clk_regmap g12a_fclk_div3 = {
.ops = &clk_regmap_gate_ops,
.parent_names = (const char *[]){ "fclk_div3_div" },
.num_parents = 1,
+ /*
+ * This clock is used by the resident firmware and is required
+ * by the platform to operate correctly.
+ * Until the following condition are met, we need this clock to
+ * be marked as critical:
+ * a) Mark the clock used by a firmware resource, if possible
+ * b) CCF has a clock hand-off mechanism to make the sure the
+ * clock stays on until the proper driver comes along
+ */
+ .flags = CLK_IS_CRITICAL,
},
};
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical
Date: Tue, 23 Apr 2019 11:15:00 +0200 [thread overview]
Message-ID: <20190423091503.10847-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20190423091503.10847-1-narmstrong@baylibre.com>
On Amlogic Meson G12b platform, the fclk_div3 seems to be necessary for
the system to operate correctly.
Disabling it cause the entire system to freeze, including peripherals.
This patch patch marks this clock as critical, fixing boot on G12b platforms.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/clk/meson/g12a.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 4bc16868b471..2e16cdf71ab4 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -1060,6 +1060,16 @@ static struct clk_regmap g12a_fclk_div3 = {
.ops = &clk_regmap_gate_ops,
.parent_names = (const char *[]){ "fclk_div3_div" },
.num_parents = 1,
+ /*
+ * This clock is used by the resident firmware and is required
+ * by the platform to operate correctly.
+ * Until the following condition are met, we need this clock to
+ * be marked as critical:
+ * a) Mark the clock used by a firmware resource, if possible
+ * b) CCF has a clock hand-off mechanism to make the sure the
+ * clock stays on until the proper driver comes along
+ */
+ .flags = CLK_IS_CRITICAL,
},
};
--
2.21.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-23 9:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:14 [PATCH v2 0/6] arm64: Add initial support for Odroid-N2 Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` [PATCH v2 1/6] dt-bindings: clk: meson: add g12b periph clock controller bindings Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-23 9:14 ` [PATCH v2 2/6] clk: meson: g12a: Add support for G12B CPUB clocks Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-23 9:15 ` Neil Armstrong [this message]
2019-04-23 9:15 ` [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 9:15 ` [PATCH v2 4/6] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 5/6] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:26 ` Martin Blumenstingl
2019-04-27 20:26 ` Martin Blumenstingl
2019-04-27 20:26 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423091503.10847-4-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.