From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, jbrunet@baylibre.com,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2
Date: Sat, 27 Apr 2019 22:26:05 +0200 [thread overview]
Message-ID: <CAFBinCDOGyP5pwcmV_4ZjhY4hiBaTesrgfEMyQ6yfx+T0Uo1hg@mail.gmail.com> (raw)
In-Reply-To: <20190423091503.10847-7-narmstrong@baylibre.com>
Hi Neil,
On Tue, Apr 23, 2019 at 11:16 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> This patch adds basic support for :
> - Amlogic G12B, which is very similar to G12A
> - The HardKernel Odroid-N2 based on the S922X SoC
>
> The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> most of the features and architecture, but with these differences :
> - The first CPU cluster only has 2xCortex-A53 instead of 4
> - G12B has a second cluster of 4xCortex-A73
> - Both cluster can achieve 2GHz instead of 1,8GHz for G12A
> - CPU Clock architecture is difference, thus needing a different
> compatible to handle this slight difference
> - Supports a MIPI CSI input
> - Embeds a Mali-G52 instead of a Mali-G31, but integration is the same
>
> Actual support is done in the same way as for the GXM support, including
> the G12A dtsi and redefining the CPU clusters.
> Unlike GXM, the first cluster is different, thus needing to remove
> the last 2 cpu nodes of the first cluster.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I don't have the board myself so I can't test it. However, apart from
one comment below this is looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...]
> +&usb {
> + status = "okay";
> +};
> +
> +&usb2_phy0 {
> + phy-supply = <&usb_pwr_en>;
> +};
is usb_pwr_en really the phy-supply or is it the vbus-supply of the
USB top control block (&usb node)?
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2
Date: Sat, 27 Apr 2019 22:26:05 +0200 [thread overview]
Message-ID: <CAFBinCDOGyP5pwcmV_4ZjhY4hiBaTesrgfEMyQ6yfx+T0Uo1hg@mail.gmail.com> (raw)
In-Reply-To: <20190423091503.10847-7-narmstrong@baylibre.com>
Hi Neil,
On Tue, Apr 23, 2019 at 11:16 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> This patch adds basic support for :
> - Amlogic G12B, which is very similar to G12A
> - The HardKernel Odroid-N2 based on the S922X SoC
>
> The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> most of the features and architecture, but with these differences :
> - The first CPU cluster only has 2xCortex-A53 instead of 4
> - G12B has a second cluster of 4xCortex-A73
> - Both cluster can achieve 2GHz instead of 1,8GHz for G12A
> - CPU Clock architecture is difference, thus needing a different
> compatible to handle this slight difference
> - Supports a MIPI CSI input
> - Embeds a Mali-G52 instead of a Mali-G31, but integration is the same
>
> Actual support is done in the same way as for the GXM support, including
> the G12A dtsi and redefining the CPU clusters.
> Unlike GXM, the first cluster is different, thus needing to remove
> the last 2 cpu nodes of the first cluster.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I don't have the board myself so I can't test it. However, apart from
one comment below this is looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...]
> +&usb {
> + status = "okay";
> +};
> +
> +&usb2_phy0 {
> + phy-supply = <&usb_pwr_en>;
> +};
is usb_pwr_en really the phy-supply or is it the vbus-supply of the
USB top control block (&usb node)?
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2
Date: Sat, 27 Apr 2019 22:26:05 +0200 [thread overview]
Message-ID: <CAFBinCDOGyP5pwcmV_4ZjhY4hiBaTesrgfEMyQ6yfx+T0Uo1hg@mail.gmail.com> (raw)
In-Reply-To: <20190423091503.10847-7-narmstrong@baylibre.com>
Hi Neil,
On Tue, Apr 23, 2019 at 11:16 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> This patch adds basic support for :
> - Amlogic G12B, which is very similar to G12A
> - The HardKernel Odroid-N2 based on the S922X SoC
>
> The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> most of the features and architecture, but with these differences :
> - The first CPU cluster only has 2xCortex-A53 instead of 4
> - G12B has a second cluster of 4xCortex-A73
> - Both cluster can achieve 2GHz instead of 1,8GHz for G12A
> - CPU Clock architecture is difference, thus needing a different
> compatible to handle this slight difference
> - Supports a MIPI CSI input
> - Embeds a Mali-G52 instead of a Mali-G31, but integration is the same
>
> Actual support is done in the same way as for the GXM support, including
> the G12A dtsi and redefining the CPU clusters.
> Unlike GXM, the first cluster is different, thus needing to remove
> the last 2 cpu nodes of the first cluster.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I don't have the board myself so I can't test it. However, apart from
one comment below this is looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...]
> +&usb {
> + status = "okay";
> +};
> +
> +&usb2_phy0 {
> + phy-supply = <&usb_pwr_en>;
> +};
is usb_pwr_en really the phy-supply or is it the vbus-supply of the
USB top control block (&usb node)?
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-27 20:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:14 [PATCH v2 0/6] arm64: Add initial support for Odroid-N2 Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` [PATCH v2 1/6] dt-bindings: clk: meson: add g12b periph clock controller bindings Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-23 9:14 ` [PATCH v2 2/6] clk: meson: g12a: Add support for G12B CPUB clocks Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-23 9:14 ` Neil Armstrong
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 9:15 ` [PATCH v2 4/6] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 5/6] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-23 9:15 ` Neil Armstrong
2019-04-27 20:26 ` Martin Blumenstingl [this message]
2019-04-27 20:26 ` Martin Blumenstingl
2019-04-27 20:26 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDOGyP5pwcmV_4ZjhY4hiBaTesrgfEMyQ6yfx+T0Uo1hg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.