Re: [PATCH 4/4] INSTALL: remove duplicate sentence

From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4/4] INSTALL: remove duplicate sentence
Date: Mon, 13 May 2019 15:34:34 +0100	[thread overview]
Message-ID: <20190513143434.GP2798@zion.uk.xensource.com> (raw)
In-Reply-To: <5CD97F3A020000780022E2E7@prv1-mh.provo.novell.com>

On Mon, May 13, 2019 at 08:29:14AM -0600, Jan Beulich wrote:
> >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
> >  SMBIOS_REL_DATE=mm/dd/yyyy
> >  VGABIOS_REL_DATE="dd Mon yyyy"
> >  
> > -During tools build external repos will be cloned into the source tree.
> >  This variable can be used to point to a different git binary to be used.
> >  GIT=
> 
> To me it would seem more logical to delete the other, later
> instance of the sentence. You wouldn't need $(GIT) if there
> was no cloning.

But deleting that one would be wrong -- it would make that paragraph
seems to be only about stubdom, while in fact most of those envars are
about tools build.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel