All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4/4] INSTALL: remove duplicate sentence
Date: Mon, 13 May 2019 08:29:14 -0600	[thread overview]
Message-ID: <5CD97F3A020000780022E2E7@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190513134714.3124-5-wei.liu2@citrix.com>

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/INSTALL
> +++ b/INSTALL
> @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
>  VGABIOS_REL_DATE="dd Mon yyyy"
>  
> -During tools build external repos will be cloned into the source tree.
>  This variable can be used to point to a different git binary to be used.
>  GIT=

To me it would seem more logical to delete the other, later
instance of the sentence. You wouldn't need $(GIT) if there
was no cloning.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Wei Liu" <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 4/4] INSTALL: remove duplicate sentence
Date: Mon, 13 May 2019 08:29:14 -0600	[thread overview]
Message-ID: <5CD97F3A020000780022E2E7@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190513142914.hFIy81ZFUz7TlpJpTGq3q8qwPn_THw_Wy-QVTj1WFVg@z> (raw)
In-Reply-To: <20190513134714.3124-5-wei.liu2@citrix.com>

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/INSTALL
> +++ b/INSTALL
> @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
>  VGABIOS_REL_DATE="dd Mon yyyy"
>  
> -During tools build external repos will be cloned into the source tree.
>  This variable can be used to point to a different git binary to be used.
>  GIT=

To me it would seem more logical to delete the other, later
instance of the sentence. You wouldn't need $(GIT) if there
was no cloning.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-13 14:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 13:47 [PATCH 0/4] Misc patches Wei Liu
2019-05-13 13:47 ` [Xen-devel] " Wei Liu
2019-05-13 13:47 ` [PATCH 1/4] gitignore: ignore .vscode directory Wei Liu
2019-05-13 13:47   ` [Xen-devel] " Wei Liu
2019-05-13 14:13   ` Anthony PERARD
2019-05-13 14:13     ` [Xen-devel] " Anthony PERARD
2019-05-13 14:16     ` Wei Liu
2019-05-13 14:16       ` [Xen-devel] " Wei Liu
2019-05-13 13:47 ` [PATCH 2/4] public/tmem.h: fix version number in comment Wei Liu
2019-05-13 13:47   ` [Xen-devel] " Wei Liu
2019-05-13 14:25   ` Jan Beulich
2019-05-13 14:25     ` [Xen-devel] " Jan Beulich
2019-05-13 13:47 ` [PATCH 3/4] README: document that `python` is required Wei Liu
2019-05-13 13:47   ` [Xen-devel] " Wei Liu
2019-05-13 14:27   ` Jan Beulich
2019-05-13 14:27     ` [Xen-devel] " Jan Beulich
2019-05-13 14:36     ` Wei Liu
2019-05-13 14:36       ` [Xen-devel] " Wei Liu
2019-05-13 14:38   ` George Dunlap
2019-05-13 14:38     ` [Xen-devel] " George Dunlap
2019-05-13 14:40     ` Wei Liu
2019-05-13 14:40       ` [Xen-devel] " Wei Liu
2019-05-13 13:47 ` [PATCH 4/4] INSTALL: remove duplicate sentence Wei Liu
2019-05-13 13:47   ` [Xen-devel] " Wei Liu
2019-05-13 14:29   ` Jan Beulich [this message]
2019-05-13 14:29     ` Jan Beulich
2019-05-13 14:34     ` Wei Liu
2019-05-13 14:34       ` [Xen-devel] " Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CD97F3A020000780022E2E7@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.