All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Torsten Duwe <duwe@lst.de>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Icenowy Zheng <icenowy@aosc.io>,
	Sean Paul <seanpaul@chromium.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Harald Geyer <harald@ccbib.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] drm/bridge: extract some Analogix I2C DP common code
Date: Mon, 27 May 2019 22:11:39 +0200	[thread overview]
Message-ID: <20190527201139.GA27782@ravnborg.org> (raw)
In-Reply-To: <20190523065352.8FD7668B05@newverein.lst.de>

Hi Torsten.

> index 000000000000..9cb30962032e
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
> @@ -0,0 +1,169 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright(c) 2017 Icenowy Zheng <icenowy@aosc.io>
> + *
> + * Based on analogix-anx78xx.c, which is:
> + *   Copyright(c) 2016, Analogix Semiconductor. All rights reserved.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/regmap.h>
> +
> +#include <drm/drm.h>
> +#include <drm/drmP.h>

Can we please avoid drmP.h in new files.
The header file is deprecated and we try to get rid of it.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Torsten Duwe <duwe@lst.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Daniel Vetter <daniel@ffwll.ch>, Harald Geyer <harald@ccbib.org>,
	Sean Paul <seanpaul@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 3/6] drm/bridge: extract some Analogix I2C DP common code
Date: Mon, 27 May 2019 22:11:39 +0200	[thread overview]
Message-ID: <20190527201139.GA27782@ravnborg.org> (raw)
In-Reply-To: <20190523065352.8FD7668B05@newverein.lst.de>

Hi Torsten.

> index 000000000000..9cb30962032e
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
> @@ -0,0 +1,169 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright(c) 2017 Icenowy Zheng <icenowy@aosc.io>
> + *
> + * Based on analogix-anx78xx.c, which is:
> + *   Copyright(c) 2016, Analogix Semiconductor. All rights reserved.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/regmap.h>
> +
> +#include <drm/drm.h>
> +#include <drm/drmP.h>

Can we please avoid drmP.h in new files.
The header file is deprecated and we try to get rid of it.

	Sam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-05-27 20:11 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  6:50 [PATCH 0/6] Add anx6345 DP/eDP bridge for Olimex Teres-I Torsten Duwe
2019-05-23  6:50 ` Torsten Duwe
2019-05-23  6:53 ` [PATCH 1/6] drm/bridge: move ANA78xx driver to analogix subdirectory Torsten Duwe
2019-05-23  6:53   ` Torsten Duwe
2019-05-23  6:53 ` [PATCH 2/6] drm/bridge: split some definitions of ANX78xx to dedicated headers Torsten Duwe
2019-05-23  6:53   ` Torsten Duwe
2019-05-23  6:53 ` [PATCH 3/6] drm/bridge: extract some Analogix I2C DP common code Torsten Duwe
2019-05-23  6:53   ` Torsten Duwe
2019-05-23  7:40   ` Chen-Yu Tsai
2019-05-23  7:40     ` Chen-Yu Tsai
2019-05-23  7:50     ` Laurent Pinchart
2019-05-23  7:50       ` Laurent Pinchart
2019-05-23 11:52       ` Torsten Duwe
2019-05-23 11:52         ` Torsten Duwe
2019-05-23  7:54   ` Laurent Pinchart
2019-05-23  7:54     ` Laurent Pinchart
2019-05-27 20:11   ` Sam Ravnborg [this message]
2019-05-27 20:11     ` Sam Ravnborg
2019-05-23  6:53 ` [PATCH 4/6] drm/bridge: Add Analogix anx6345 support Torsten Duwe
2019-05-23  6:53   ` Torsten Duwe
2019-05-23  7:50   ` Laurent Pinchart
2019-05-23  7:50     ` Laurent Pinchart
2019-05-23 12:45     ` Torsten Duwe
2019-05-23 12:45       ` Torsten Duwe
2019-05-23  6:54 ` [PATCH 5/6] dt-bindings: Add ANX6345 DP/eDP transmitter binding Torsten Duwe
2019-05-23  6:54   ` Torsten Duwe
2019-05-23  7:31   ` Laurent Pinchart
2019-05-23  7:31     ` Laurent Pinchart
2019-05-23  9:05   ` Maxime Ripard
2019-05-23  9:05     ` Maxime Ripard
2019-05-23 12:30     ` Torsten Duwe
2019-05-23 12:30       ` Torsten Duwe
2019-05-23  6:54 ` [PATCH 6/6] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I Torsten Duwe
2019-05-23  6:54   ` Torsten Duwe
2019-05-23 14:48   ` Vasily Khoruzhick
2019-05-23 14:48     ` Vasily Khoruzhick
2019-05-24 12:13     ` Torsten Duwe
2019-05-24 12:13       ` Torsten Duwe
2019-05-24 13:06       ` Maxime Ripard
2019-05-24 13:06         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527201139.GA27782@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=anarsoul@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=duwe@lst.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=harald@ccbib.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.