From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 07/10] drm: rcar-du: Skip LVDS1 output on Gen3 when using dual-link LVDS mode
Date: Thu, 6 Jun 2019 11:29:59 +0200 [thread overview]
Message-ID: <20190606092959.GB17442@ravnborg.org> (raw)
In-Reply-To: <20190606075750.GE4931@pendragon.ideasonboard.com>
Hi Laurent.
> > > Gen3 is the newest generation :-) We thus use >= through the DU and LVDS
> > > drivers to prepare for support of Gen4, just in case.
> >
> > OK, but I guess we agree that the comment needs a small update them.
> >
> > Actually I implicitly reads that it is only from Gen3 onwards that the
> > LVDS1 encoder can be used as a companion.
> > My initial understanding reading the comment was that this implmented a
> > workaround for Gen3 - but it is a workarounf for missing features in
> > older than Gen3.
>
> I wouldn't say workaround, it just makes sure that we don't try to
> support LVDS dual-mode on older SoCs as the feature was added in Gen3
> hardware.
>
> > So, assuming this is correct, when trying to specify a companion on
> > older then Gen3 should result in some kind of error/warning?
> > (Maybe it does).
>
> The property is ignored in that case. I could add an error message, but
> I'm not sure I should, as we don't usually check that DT nodes don't
> contain any other property than the ones specified in the DT bindings
> (an automatic DT runtime validator based on the YAML bindings could be
> interesting ;-)).
Again, thanks for taking your time.
This clarifies it nicely.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 07/10] drm: rcar-du: Skip LVDS1 output on Gen3 when using dual-link LVDS mode
Date: Thu, 6 Jun 2019 11:29:59 +0200 [thread overview]
Message-ID: <20190606092959.GB17442@ravnborg.org> (raw)
In-Reply-To: <20190606075750.GE4931@pendragon.ideasonboard.com>
Hi Laurent.
> > > Gen3 is the newest generation :-) We thus use >= through the DU and LVDS
> > > drivers to prepare for support of Gen4, just in case.
> >
> > OK, but I guess we agree that the comment needs a small update them.
> >
> > Actually I implicitly reads that it is only from Gen3 onwards that the
> > LVDS1 encoder can be used as a companion.
> > My initial understanding reading the comment was that this implmented a
> > workaround for Gen3 - but it is a workarounf for missing features in
> > older than Gen3.
>
> I wouldn't say workaround, it just makes sure that we don't try to
> support LVDS dual-mode on older SoCs as the feature was added in Gen3
> hardware.
>
> > So, assuming this is correct, when trying to specify a companion on
> > older then Gen3 should result in some kind of error/warning?
> > (Maybe it does).
>
> The property is ignored in that case. I could add an error message, but
> I'm not sure I should, as we don't usually check that DT nodes don't
> contain any other property than the ones specified in the DT bindings
> (an automatic DT runtime validator based on the YAML bindings could be
> interesting ;-)).
Again, thanks for taking your time.
This clarifies it nicely.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-06 9:30 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 14:12 [PATCH v3 00/10] R-Car DU: LVDS dual-link mode support Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-05-28 14:12 ` [PATCH v3 01/10] drm: bridge: Add dual_link field to the drm_bridge_timings structure Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-07-30 12:12 ` Neil Armstrong
2019-07-30 12:12 ` Neil Armstrong
2019-05-28 14:12 ` [PATCH v3 02/10] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-06-07 22:15 ` Kieran Bingham
2019-06-07 22:15 ` Kieran Bingham
2019-06-07 22:30 ` Laurent Pinchart
2019-06-07 22:30 ` Laurent Pinchart
2019-06-07 22:36 ` Kieran Bingham
2019-06-07 22:36 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 03/10] drm: bridge: thc63: Report input bus mode through bridge timings Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-06-07 22:51 ` Kieran Bingham
2019-06-07 22:51 ` Kieran Bingham
2019-07-30 12:13 ` Neil Armstrong
2019-07-30 12:13 ` Neil Armstrong
2019-05-28 14:12 ` [PATCH v3 04/10] dt-bindings: display: renesas: lvds: Add renesas, companion property Laurent Pinchart
2019-05-28 14:12 ` [PATCH v3 04/10] dt-bindings: display: renesas: lvds: Add renesas,companion property Laurent Pinchart
2019-05-28 16:37 ` [PATCH v3 04/10] dt-bindings: display: renesas: lvds: Add renesas, companion property Sam Ravnborg
2019-05-28 16:37 ` Sam Ravnborg
2019-05-28 16:49 ` Laurent Pinchart
2019-05-28 16:49 ` Laurent Pinchart
2019-05-28 16:59 ` Sam Ravnborg
2019-05-28 16:59 ` Sam Ravnborg
2019-06-06 7:54 ` Laurent Pinchart
2019-06-06 7:54 ` Laurent Pinchart
2019-06-06 9:27 ` Sam Ravnborg
2019-06-06 9:27 ` Sam Ravnborg
2019-06-07 22:33 ` [PATCH v3 04/10] dt-bindings: display: renesas: lvds: Add renesas,companion property Kieran Bingham
2019-06-07 22:33 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 05/10] drm: rcar-du: lvds: Remove LVDS double-enable checks Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-06-07 22:09 ` Kieran Bingham
2019-06-07 22:09 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 06/10] drm: rcar-du: lvds: Add support for dual-link mode Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-06-07 23:11 ` Kieran Bingham
2019-06-07 23:11 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 07/10] drm: rcar-du: Skip LVDS1 output on Gen3 when using dual-link LVDS mode Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-05-28 16:42 ` Sam Ravnborg
2019-05-28 16:42 ` Sam Ravnborg
2019-05-28 16:50 ` Laurent Pinchart
2019-05-28 16:50 ` Laurent Pinchart
2019-05-28 17:02 ` Sam Ravnborg
2019-05-28 17:02 ` Sam Ravnborg
2019-06-06 7:57 ` Laurent Pinchart
2019-06-06 7:57 ` Laurent Pinchart
2019-06-06 9:29 ` Sam Ravnborg [this message]
2019-06-06 9:29 ` Sam Ravnborg
2019-06-07 23:19 ` Kieran Bingham
2019-06-07 23:19 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 08/10] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1 Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-06-03 11:40 ` Simon Horman
2019-06-03 11:40 ` Simon Horman
2019-06-06 7:59 ` Laurent Pinchart
2019-06-06 7:59 ` Laurent Pinchart
2019-06-06 8:51 ` Simon Horman
2019-06-06 8:51 ` Simon Horman
2019-06-12 10:21 ` Laurent Pinchart
2019-06-12 10:21 ` Laurent Pinchart
2019-06-12 11:52 ` Simon Horman
2019-06-12 11:52 ` Simon Horman
2019-06-07 23:15 ` Kieran Bingham
2019-06-07 23:15 ` Kieran Bingham
2019-05-28 14:12 ` [PATCH v3 09/10] [HACK] arm64: dts: renesas: draak: Enable LVDS dual-link operation Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-05-28 14:12 ` [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: " Laurent Pinchart
2019-05-28 14:12 ` Laurent Pinchart
2019-07-22 11:27 ` Fabrizio Castro
2019-07-22 11:27 ` Fabrizio Castro
2019-07-23 10:30 ` Jacopo Mondi
2019-07-23 10:30 ` Jacopo Mondi
2019-07-23 12:16 ` Fabrizio Castro
2019-07-23 12:16 ` Fabrizio Castro
2019-05-28 16:46 ` [PATCH v3 00/10] R-Car DU: LVDS dual-link mode support Sam Ravnborg
2019-05-28 16:46 ` Sam Ravnborg
2019-06-07 22:16 ` Kieran Bingham
2019-06-07 22:16 ` Kieran Bingham
2019-06-07 22:21 ` Laurent Pinchart
2019-06-07 22:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606092959.GB17442@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.