From: Sudeep Holla <sudeep.holla@arm.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, linux-arm-kernel@lists.infradead.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, Amit Kucheria <amit.kucheria@linaro.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Niklas Cassel <niklas.cassel@linaro.org>, Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@kernel.org>, Lina Iyer <ilina@codeaurora.org>, Viresh Kumar <viresh.kumar@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Sudeep Holla <sudeep.holla@arm.com>, Souvik Chakravarty <souvik.chakravarty@arm.com>, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/18] drivers: firmware: psci: Prepare to support PM domains Date: Fri, 7 Jun 2019 16:21:14 +0100 [thread overview] Message-ID: <20190607152114.GG15577@e107155-lin> (raw) In-Reply-To: <20190513192300.653-9-ulf.hansson@linaro.org> On Mon, May 13, 2019 at 09:22:50PM +0200, Ulf Hansson wrote: > Subsequent changes implements support for PM domains to PSCI. Those changes > are mainly implemented in a new separate c-file, hence a couple of the > internal PSCI functions needs to be shared to be accessible. Let's do that > via adding a new PSCI header file. > > Moreover, to implement support for PM domains, switching the PSCI FW into > the OS initiated mode is sometimes needed. Therefore, let's share a new > function that implement this. > This looks fine. -- Regards, Sudeep > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes: > - Convert psci_set_osi_mode() to return an int. > - Don't share psci_get_domain_state() as that's no longer needed. > - Update changelog. > > --- > drivers/firmware/psci/psci.c | 17 ++++++++++++++--- > drivers/firmware/psci/psci.h | 16 ++++++++++++++++ > 2 files changed, 30 insertions(+), 3 deletions(-) > create mode 100644 drivers/firmware/psci/psci.h > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 4aec513136e4..0e91d864e346 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -34,6 +34,8 @@ > #include <asm/smp_plat.h> > #include <asm/suspend.h> > > +#include "psci.h" > + > /* > * While a 64-bit OS can make calls with SMC32 calling conventions, for some > * calls it is necessary to use SMC64 to pass or return 64-bit values. > @@ -96,7 +98,7 @@ static inline bool psci_has_ext_power_state(void) > PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; > } > > -static inline bool psci_has_osi_support(void) > +bool psci_has_osi_support(void) > { > return psci_cpu_suspend_feature & PSCI_1_0_OS_INITIATED; > } > @@ -161,6 +163,15 @@ static u32 psci_get_version(void) > return invoke_psci_fn(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); > } > > +int psci_set_osi_mode(void) > +{ > + int err; > + > + err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, > + PSCI_1_0_SUSPEND_MODE_OSI, 0, 0); > + return psci_to_linux_errno(err); > +} > + > static int psci_cpu_suspend(u32 state, unsigned long entry_point) > { > int err; > @@ -292,12 +303,12 @@ static inline u32 psci_get_domain_state(void) > return __this_cpu_read(domain_state); > } > > -static inline void psci_set_domain_state(u32 state) > +void psci_set_domain_state(u32 state) > { > __this_cpu_write(domain_state, state); > } > > -static int psci_dt_parse_state_node(struct device_node *np, u32 *state) > +int psci_dt_parse_state_node(struct device_node *np, u32 *state) > { > int err = of_property_read_u32(np, "arm,psci-suspend-param", state); > > diff --git a/drivers/firmware/psci/psci.h b/drivers/firmware/psci/psci.h > new file mode 100644 > index 000000000000..f2277c3ad405 > --- /dev/null > +++ b/drivers/firmware/psci/psci.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __PSCI_H > +#define __PSCI_H > + > +struct device_node; > + > +int psci_set_osi_mode(void); > +bool psci_has_osi_support(void); > + > +#ifdef CONFIG_CPU_IDLE > +void psci_set_domain_state(u32 state); > +int psci_dt_parse_state_node(struct device_node *np, u32 *state); > +#endif > + > +#endif /* __PSCI_H */ > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kevin Hilman <khilman@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, Daniel Lezcano <daniel.lezcano@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-kernel@vger.kernel.org, Amit Kucheria <amit.kucheria@linaro.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Tony Lindgren <tony@atomide.com>, linux-arm-msm@vger.kernel.org, Lina Iyer <ilina@codeaurora.org>, Sudeep Holla <sudeep.holla@arm.com>, Niklas Cassel <niklas.cassel@linaro.org>, Souvik Chakravarty <souvik.chakravarty@arm.com>, "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 08/18] drivers: firmware: psci: Prepare to support PM domains Date: Fri, 7 Jun 2019 16:21:14 +0100 [thread overview] Message-ID: <20190607152114.GG15577@e107155-lin> (raw) In-Reply-To: <20190513192300.653-9-ulf.hansson@linaro.org> On Mon, May 13, 2019 at 09:22:50PM +0200, Ulf Hansson wrote: > Subsequent changes implements support for PM domains to PSCI. Those changes > are mainly implemented in a new separate c-file, hence a couple of the > internal PSCI functions needs to be shared to be accessible. Let's do that > via adding a new PSCI header file. > > Moreover, to implement support for PM domains, switching the PSCI FW into > the OS initiated mode is sometimes needed. Therefore, let's share a new > function that implement this. > This looks fine. -- Regards, Sudeep > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes: > - Convert psci_set_osi_mode() to return an int. > - Don't share psci_get_domain_state() as that's no longer needed. > - Update changelog. > > --- > drivers/firmware/psci/psci.c | 17 ++++++++++++++--- > drivers/firmware/psci/psci.h | 16 ++++++++++++++++ > 2 files changed, 30 insertions(+), 3 deletions(-) > create mode 100644 drivers/firmware/psci/psci.h > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 4aec513136e4..0e91d864e346 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -34,6 +34,8 @@ > #include <asm/smp_plat.h> > #include <asm/suspend.h> > > +#include "psci.h" > + > /* > * While a 64-bit OS can make calls with SMC32 calling conventions, for some > * calls it is necessary to use SMC64 to pass or return 64-bit values. > @@ -96,7 +98,7 @@ static inline bool psci_has_ext_power_state(void) > PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; > } > > -static inline bool psci_has_osi_support(void) > +bool psci_has_osi_support(void) > { > return psci_cpu_suspend_feature & PSCI_1_0_OS_INITIATED; > } > @@ -161,6 +163,15 @@ static u32 psci_get_version(void) > return invoke_psci_fn(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); > } > > +int psci_set_osi_mode(void) > +{ > + int err; > + > + err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, > + PSCI_1_0_SUSPEND_MODE_OSI, 0, 0); > + return psci_to_linux_errno(err); > +} > + > static int psci_cpu_suspend(u32 state, unsigned long entry_point) > { > int err; > @@ -292,12 +303,12 @@ static inline u32 psci_get_domain_state(void) > return __this_cpu_read(domain_state); > } > > -static inline void psci_set_domain_state(u32 state) > +void psci_set_domain_state(u32 state) > { > __this_cpu_write(domain_state, state); > } > > -static int psci_dt_parse_state_node(struct device_node *np, u32 *state) > +int psci_dt_parse_state_node(struct device_node *np, u32 *state) > { > int err = of_property_read_u32(np, "arm,psci-suspend-param", state); > > diff --git a/drivers/firmware/psci/psci.h b/drivers/firmware/psci/psci.h > new file mode 100644 > index 000000000000..f2277c3ad405 > --- /dev/null > +++ b/drivers/firmware/psci/psci.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __PSCI_H > +#define __PSCI_H > + > +struct device_node; > + > +int psci_set_osi_mode(void); > +bool psci_has_osi_support(void); > + > +#ifdef CONFIG_CPU_IDLE > +void psci_set_domain_state(u32 state); > +int psci_dt_parse_state_node(struct device_node *np, u32 *state); > +#endif > + > +#endif /* __PSCI_H */ > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-07 15:21 UTC|newest] Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-13 19:22 [PATCH 00/18] ARM/ARM64: Support hierarchical CPU arrangement for PSCI Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 01/18] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-07-19 11:29 ` Lorenzo Pieralisi 2019-07-19 11:29 ` Lorenzo Pieralisi 2019-05-13 19:22 ` [PATCH 02/18] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 03/18] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 04/18] ARM/ARM64: cpuidle: Let back-end init ops take the driver as input Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:00 ` Sudeep Holla 2019-06-07 15:00 ` Sudeep Holla 2019-06-10 10:20 ` Ulf Hansson 2019-06-10 10:20 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 05/18] drivers: firmware: psci: Simplify state node parsing Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:01 ` Sudeep Holla 2019-06-07 15:01 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 06/18] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:03 ` Sudeep Holla 2019-06-07 15:03 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 07/18] drivers: firmware: psci: Prepare to use OS initiated suspend mode Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:17 ` Sudeep Holla 2019-06-07 15:17 ` Sudeep Holla 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 10:42 ` Sudeep Holla 2019-06-10 10:42 ` Sudeep Holla 2019-07-16 14:53 ` Sudeep Holla 2019-07-16 14:53 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 08/18] drivers: firmware: psci: Prepare to support PM domains Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:21 ` Sudeep Holla [this message] 2019-06-07 15:21 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 09/18] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:27 ` Sudeep Holla 2019-06-07 15:27 ` Sudeep Holla 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 10:59 ` Sudeep Holla 2019-06-10 10:59 ` Sudeep Holla 2019-07-16 15:05 ` Sudeep Holla 2019-07-16 15:05 ` Sudeep Holla 2019-07-18 11:04 ` Ulf Hansson 2019-07-18 11:04 ` Ulf Hansson 2019-07-18 13:19 ` Sudeep Holla 2019-07-18 13:19 ` Sudeep Holla 2019-07-18 17:57 ` Lina Iyer 2019-07-18 17:57 ` Lina Iyer 2019-07-19 9:45 ` Sudeep Holla 2019-07-19 9:45 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 10/18] drivers: firmware: psci: Add hierarchical domain idle states converter Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-07-09 15:31 ` Lorenzo Pieralisi 2019-07-09 15:31 ` Lorenzo Pieralisi 2019-07-16 8:45 ` Ulf Hansson 2019-07-16 8:45 ` Ulf Hansson 2019-07-16 14:51 ` Lorenzo Pieralisi 2019-07-16 14:51 ` Lorenzo Pieralisi 2019-07-18 11:43 ` Ulf Hansson 2019-07-18 11:43 ` Ulf Hansson 2019-07-18 13:36 ` Lorenzo Pieralisi 2019-07-18 13:36 ` Lorenzo Pieralisi 2019-05-13 19:22 ` [PATCH 11/18] drivers: firmware: psci: Introduce psci_dt_topology_init() Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 12/18] drivers: firmware: psci: Add a helper to attach a CPU to its PM domain Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 13/18] drivers: firmware: psci: Attach the CPU's device " Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 14/18] drivers: firmware: psci: Manage runtime PM in the idle path for CPUs Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-07-16 15:53 ` Lorenzo Pieralisi 2019-07-16 15:53 ` Lorenzo Pieralisi 2019-07-18 10:35 ` Ulf Hansson 2019-07-18 10:35 ` Ulf Hansson 2019-07-18 13:30 ` Lorenzo Pieralisi 2019-07-18 13:30 ` Lorenzo Pieralisi 2019-07-18 16:54 ` Ulf Hansson 2019-07-18 16:54 ` Ulf Hansson 2019-07-18 17:41 ` Lina Iyer 2019-07-18 17:41 ` Lina Iyer 2019-07-18 21:49 ` Ulf Hansson 2019-07-18 21:49 ` Ulf Hansson 2019-07-19 10:02 ` Lorenzo Pieralisi 2019-07-19 10:02 ` Lorenzo Pieralisi 2019-05-13 19:22 ` [PATCH 15/18] drivers: firmware: psci: Support CPU hotplug for the hierarchical model Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-06-07 15:31 ` Sudeep Holla 2019-06-07 15:31 ` Sudeep Holla 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 10:21 ` Ulf Hansson 2019-06-10 11:02 ` Sudeep Holla 2019-06-10 11:02 ` Sudeep Holla 2019-05-13 19:22 ` [PATCH 16/18] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` [PATCH 17/18] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-05-13 19:22 ` Ulf Hansson 2019-07-16 14:47 ` Sudeep Holla 2019-07-16 14:47 ` Sudeep Holla 2019-07-16 20:36 ` Lina Iyer 2019-07-16 20:36 ` Lina Iyer 2019-07-17 17:18 ` Sudeep Holla 2019-07-17 17:18 ` Sudeep Holla 2019-05-13 19:23 ` [PATCH 18/18] arm64: dts: hikey: Convert to the hierarchical CPU topology layout Ulf Hansson 2019-05-13 19:23 ` Ulf Hansson 2019-05-13 19:23 ` Ulf Hansson 2019-07-16 14:47 ` Sudeep Holla 2019-07-16 14:47 ` Sudeep Holla 2019-07-18 10:48 ` Ulf Hansson 2019-07-18 10:48 ` Ulf Hansson 2019-07-18 13:11 ` Sudeep Holla 2019-07-18 13:11 ` Sudeep Holla 2019-05-14 8:08 ` [PATCH 00/18] ARM/ARM64: Support hierarchical CPU arrangement for PSCI Rafael J. Wysocki 2019-05-14 8:08 ` Rafael J. Wysocki 2019-05-14 8:08 ` Rafael J. Wysocki 2019-05-14 8:58 ` Ulf Hansson 2019-05-14 8:58 ` Ulf Hansson 2019-05-14 8:58 ` Ulf Hansson 2019-06-07 15:42 ` Sudeep Holla 2019-06-07 15:42 ` Sudeep Holla 2019-06-07 19:34 ` Bjorn Andersson 2019-06-07 19:34 ` Bjorn Andersson 2019-06-10 10:32 ` Sudeep Holla 2019-06-10 10:32 ` Sudeep Holla 2019-06-10 15:54 ` Ulf Hansson 2019-06-10 15:54 ` Ulf Hansson 2019-06-10 17:16 ` Lorenzo Pieralisi 2019-06-10 17:16 ` Lorenzo Pieralisi 2019-06-10 18:57 ` Ulf Hansson 2019-06-10 18:57 ` Ulf Hansson 2019-06-18 11:56 ` Ulf Hansson 2019-06-18 11:56 ` Ulf Hansson 2019-06-07 11:19 ` Ulf Hansson 2019-06-07 11:19 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190607152114.GG15577@e107155-lin \ --to=sudeep.holla@arm.com \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=amit.kucheria@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=daniel.lezcano@linaro.org \ --cc=geert+renesas@glider.be \ --cc=ilina@codeaurora.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=niklas.cassel@linaro.org \ --cc=rjw@rjwysocki.net \ --cc=rplsssn@codeaurora.org \ --cc=sboyd@kernel.org \ --cc=souvik.chakravarty@arm.com \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.