Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()

From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, rafael@kernel.org,
	viresh.kumar@linaro.org, mingo@redhat.com,
	quentin.perret@arm.com
Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()
Date: Tue, 18 Jun 2019 11:34:53 +0200	[thread overview]
Message-ID: <20190618093453.GN3436@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <c8030f30-0899-070b-df3c-3839ec7e1909@arm.com>

On Mon, Jun 17, 2019 at 06:07:29PM +0100, Valentin Schneider wrote:
> Hi,
> 
> On 17/06/2019 16:00, Vincent Guittot wrote:
> > struct sched_domain *sd parameter is not used anymore in
> > arch_scale_cpu_capacity() so we can remove it.
> > 
> 
> I think it can't hurt to give a bit of background. The *sd parameter used
> to be there for smt_gain, which got snipped out by:
> 
>   765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")
> 
> I'd appreciate having that commit mentioned in the log.
> 
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> 
> Other than that, the changes look fine to me.
> 
> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

The commit log now reads:

---
The 'struct sched_domain *sd' argument to arch_scale_cpu_capacity() is
unused since commit:

  765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")

remove it.
---