All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, rafael@kernel.org,
	viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org
Cc: quentin.perret@arm.com
Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()
Date: Mon, 17 Jun 2019 18:07:29 +0100	[thread overview]
Message-ID: <c8030f30-0899-070b-df3c-3839ec7e1909@arm.com> (raw)
In-Reply-To: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org>

Hi,

On 17/06/2019 16:00, Vincent Guittot wrote:
> struct sched_domain *sd parameter is not used anymore in
> arch_scale_cpu_capacity() so we can remove it.
> 

I think it can't hurt to give a bit of background. The *sd parameter used
to be there for smt_gain, which got snipped out by:

  765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")

I'd appreciate having that commit mentioned in the log.

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

Other than that, the changes look fine to me.

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

[...]

WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, rafael@kernel.org,
	viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org
Cc: quentin.perret@arm.com
Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()
Date: Mon, 17 Jun 2019 18:07:29 +0100	[thread overview]
Message-ID: <c8030f30-0899-070b-df3c-3839ec7e1909@arm.com> (raw)
In-Reply-To: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org>

Hi,

On 17/06/2019 16:00, Vincent Guittot wrote:
> struct sched_domain *sd parameter is not used anymore in
> arch_scale_cpu_capacity() so we can remove it.
> 

I think it can't hurt to give a bit of background. The *sd parameter used
to be there for smt_gain, which got snipped out by:

  765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")

I'd appreciate having that commit mentioned in the log.

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

Other than that, the changes look fine to me.

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

[...]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-17 17:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 15:00 [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity() Vincent Guittot
2019-06-17 15:00 ` Vincent Guittot
2019-06-17 17:07 ` Valentin Schneider [this message]
2019-06-17 17:07   ` Valentin Schneider
2019-06-18  9:34   ` Peter Zijlstra
2019-06-18  9:34     ` Peter Zijlstra
2019-06-18  9:37     ` Valentin Schneider
2019-06-18  9:37       ` Valentin Schneider
2019-06-18  9:45     ` Vincent Guittot
2019-06-18  9:45       ` Vincent Guittot
2019-06-18  9:26 ` Viresh Kumar
2019-06-18  9:26   ` Viresh Kumar
2019-06-25  8:23 ` [tip:sched/core] sched/topology: Remove unused 'sd' parameter " tip-bot for Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8030f30-0899-070b-df3c-3839ec7e1909@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=quentin.perret@arm.com \
    --cc=rafael@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.