From: Will Deacon <will@kernel.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Peter Collingbourne <pcc@google.com>
Subject: Re: [PATCH v2 2/2] arm64/vdso: fix flip/flop vdso build bug
Date: Fri, 12 Jul 2019 16:37:46 +0100 [thread overview]
Message-ID: <20190712153746.5dwwptgrle3z25m7@willie-the-truck> (raw)
In-Reply-To: <20190712101556.17833-2-naohiro.aota@wdc.com>
On Fri, Jul 12, 2019 at 07:15:56PM +0900, Naohiro Aota wrote:
> Running "make" on an already compiled kernel tree will rebuild the kernel
> even without any modifications:
>
> $ make ARCH=arm64 CROSS_COMPILE=/usr/bin/aarch64-unknown-linux-gnu-
> arch/arm64/Makefile:58: CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built
> CALL scripts/checksyscalls.sh
> CALL scripts/atomic/check-atomics.sh
> VDSOCHK arch/arm64/kernel/vdso/vdso.so.dbg
> VDSOSYM include/generated/vdso-offsets.h
> CHK include/generated/compile.h
> CC arch/arm64/kernel/signal.o
> CC arch/arm64/kernel/vdso.o
> CC arch/arm64/kernel/signal32.o
> LD arch/arm64/kernel/vdso/vdso.so.dbg
> OBJCOPY arch/arm64/kernel/vdso/vdso.so
> AS arch/arm64/kernel/vdso/vdso.o
> AR arch/arm64/kernel/vdso/built-in.a
> AR arch/arm64/kernel/built-in.a
> GEN .version
> CHK include/generated/compile.h
> UPD include/generated/compile.h
> CC init/version.o
> AR init/built-in.a
> LD vmlinux.o
>
> This is the same bug fixed in commit 92a4728608a8 ("x86/boot: Fix
> if_changed build flip/flop bug"). We cannot use two "if_changed" in one
> target. Fix this build bug by merging two commands into one function.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Fixes: 28b1a824a4f4 ("arm64: vdso: Substitute gettimeofday() with C implementation")
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
> arch/arm64/kernel/vdso/Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Thanks. I've merged in Vincenzo's compat change too, so I'll send this at
-rc1 for arm64.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Peter Collingbourne <pcc@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64/vdso: fix flip/flop vdso build bug
Date: Fri, 12 Jul 2019 16:37:46 +0100 [thread overview]
Message-ID: <20190712153746.5dwwptgrle3z25m7@willie-the-truck> (raw)
In-Reply-To: <20190712101556.17833-2-naohiro.aota@wdc.com>
On Fri, Jul 12, 2019 at 07:15:56PM +0900, Naohiro Aota wrote:
> Running "make" on an already compiled kernel tree will rebuild the kernel
> even without any modifications:
>
> $ make ARCH=arm64 CROSS_COMPILE=/usr/bin/aarch64-unknown-linux-gnu-
> arch/arm64/Makefile:58: CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built
> CALL scripts/checksyscalls.sh
> CALL scripts/atomic/check-atomics.sh
> VDSOCHK arch/arm64/kernel/vdso/vdso.so.dbg
> VDSOSYM include/generated/vdso-offsets.h
> CHK include/generated/compile.h
> CC arch/arm64/kernel/signal.o
> CC arch/arm64/kernel/vdso.o
> CC arch/arm64/kernel/signal32.o
> LD arch/arm64/kernel/vdso/vdso.so.dbg
> OBJCOPY arch/arm64/kernel/vdso/vdso.so
> AS arch/arm64/kernel/vdso/vdso.o
> AR arch/arm64/kernel/vdso/built-in.a
> AR arch/arm64/kernel/built-in.a
> GEN .version
> CHK include/generated/compile.h
> UPD include/generated/compile.h
> CC init/version.o
> AR init/built-in.a
> LD vmlinux.o
>
> This is the same bug fixed in commit 92a4728608a8 ("x86/boot: Fix
> if_changed build flip/flop bug"). We cannot use two "if_changed" in one
> target. Fix this build bug by merging two commands into one function.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Fixes: 28b1a824a4f4 ("arm64: vdso: Substitute gettimeofday() with C implementation")
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
> arch/arm64/kernel/vdso/Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Thanks. I've merged in Vincenzo's compat change too, so I'll send this at
-rc1 for arm64.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-12 15:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 10:15 [PATCH v2 1/2] x86/vdso: fix flip/flop vdso build bug Naohiro Aota
2019-07-12 10:15 ` Naohiro Aota
2019-07-12 10:15 ` [PATCH v2 2/2] arm64/vdso: " Naohiro Aota
2019-07-12 10:15 ` Naohiro Aota
2019-07-12 12:06 ` [PATCH] arm64: compat: Fix flip/flop vdso building bug Vincenzo Frascino
2019-07-12 12:06 ` Vincenzo Frascino
2019-07-12 12:10 ` [PATCH v2 2/2] arm64/vdso: fix flip/flop vdso build bug Vincenzo Frascino
2019-07-12 12:10 ` Vincenzo Frascino
2019-07-12 14:55 ` Masahiro Yamada
2019-07-12 14:55 ` Masahiro Yamada
2019-07-12 15:37 ` Will Deacon [this message]
2019-07-12 15:37 ` Will Deacon
2019-07-18 11:41 ` [PATCH] arm64: vdso: Cleanup Makefiles Vincenzo Frascino
2019-07-18 11:41 ` Vincenzo Frascino
2019-07-19 8:04 ` Will Deacon
2019-07-19 8:04 ` Will Deacon
2019-07-19 9:49 ` Vincenzo Frascino
2019-07-19 9:49 ` Vincenzo Frascino
2019-07-19 10:10 ` [PATCH v2] " Vincenzo Frascino
2019-07-19 10:10 ` Vincenzo Frascino
2019-07-22 9:41 ` Will Deacon
2019-07-22 9:41 ` Will Deacon
2019-07-12 12:09 ` [PATCH v2 1/2] x86/vdso: fix flip/flop vdso build bug Vincenzo Frascino
2019-07-12 12:09 ` Vincenzo Frascino
2019-07-12 14:54 ` Masahiro Yamada
2019-07-12 14:54 ` Masahiro Yamada
2019-07-12 15:41 ` [tip:x86/urgent] x86/vdso: Fix " tip-bot for Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712153746.5dwwptgrle3z25m7@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=pcc@google.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.