From: Will Deacon <will@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, arnd@arndb.de, linux@armlinux.org.uk,
daniel.lezcano@linaro.org, tglx@linutronix.de,
salyzyn@android.com, pcc@google.com, 0x7f454c46@gmail.com,
linux@rasmusvillemoes.dk, huw@codeweavers.com,
sthotton@marvell.com, andre.przywara@arm.com, luto@kernel.org,
john.stultz@linaro.org, naohiro.aota@wdc.com,
yamada.masahiro@socionext.com
Subject: Re: [PATCH] arm64: vdso: Cleanup Makefiles.
Date: Fri, 19 Jul 2019 09:04:36 +0100 [thread overview]
Message-ID: <20190719080435.f3nlecyu3ysnsnpv@willie-the-truck> (raw)
In-Reply-To: <20190718114121.33024-1-vincenzo.frascino@arm.com>
On Thu, Jul 18, 2019 at 12:41:21PM +0100, Vincenzo Frascino wrote:
> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
> index 21009ed5a755..6c4e496309c4 100644
> --- a/arch/arm64/kernel/vdso32/Makefile
> +++ b/arch/arm64/kernel/vdso32/Makefile
> @@ -155,17 +155,17 @@ $(asm-obj-vdso): %.o: %.S FORCE
> $(call if_changed_dep,vdsoas)
>
> # Actual build commands
> -quiet_cmd_vdsold_and_vdso_check = LD $@
> +quiet_cmd_vdsold_and_vdso_check = VDSOLIB $@
> cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check)
>
> -quiet_cmd_vdsold = VDSOL $@
> +quiet_cmd_vdsold = VDSOLD $@
I think we should be more consistent about whether or not we prefix things
with VDSO, so either go with "VDSOLD, VDSOCC and VDSOAS" or stick to "LD,
CC and AS" rather than mixing between them.
I think my suggestion would be something along the lines of CC, LD, AS for
the native vdso and CC32, LD32, AS32 for the compat vdso.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, naohiro.aota@wdc.com,
sthotton@marvell.com, luto@kernel.org, arnd@arndb.de,
huw@codeweavers.com, catalin.marinas@arm.com,
daniel.lezcano@linaro.org, will.deacon@arm.com,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
yamada.masahiro@socionext.com, andre.przywara@arm.com,
john.stultz@linaro.org, 0x7f454c46@gmail.com,
linux@rasmusvillemoes.dk, tglx@linutronix.de,
salyzyn@android.com, pcc@google.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: vdso: Cleanup Makefiles.
Date: Fri, 19 Jul 2019 09:04:36 +0100 [thread overview]
Message-ID: <20190719080435.f3nlecyu3ysnsnpv@willie-the-truck> (raw)
In-Reply-To: <20190718114121.33024-1-vincenzo.frascino@arm.com>
On Thu, Jul 18, 2019 at 12:41:21PM +0100, Vincenzo Frascino wrote:
> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
> index 21009ed5a755..6c4e496309c4 100644
> --- a/arch/arm64/kernel/vdso32/Makefile
> +++ b/arch/arm64/kernel/vdso32/Makefile
> @@ -155,17 +155,17 @@ $(asm-obj-vdso): %.o: %.S FORCE
> $(call if_changed_dep,vdsoas)
>
> # Actual build commands
> -quiet_cmd_vdsold_and_vdso_check = LD $@
> +quiet_cmd_vdsold_and_vdso_check = VDSOLIB $@
> cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check)
>
> -quiet_cmd_vdsold = VDSOL $@
> +quiet_cmd_vdsold = VDSOLD $@
I think we should be more consistent about whether or not we prefix things
with VDSO, so either go with "VDSOLD, VDSOCC and VDSOAS" or stick to "LD,
CC and AS" rather than mixing between them.
I think my suggestion would be something along the lines of CC, LD, AS for
the native vdso and CC32, LD32, AS32 for the compat vdso.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-19 8:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 10:15 [PATCH v2 1/2] x86/vdso: fix flip/flop vdso build bug Naohiro Aota
2019-07-12 10:15 ` Naohiro Aota
2019-07-12 10:15 ` [PATCH v2 2/2] arm64/vdso: " Naohiro Aota
2019-07-12 10:15 ` Naohiro Aota
2019-07-12 12:06 ` [PATCH] arm64: compat: Fix flip/flop vdso building bug Vincenzo Frascino
2019-07-12 12:06 ` Vincenzo Frascino
2019-07-12 12:10 ` [PATCH v2 2/2] arm64/vdso: fix flip/flop vdso build bug Vincenzo Frascino
2019-07-12 12:10 ` Vincenzo Frascino
2019-07-12 14:55 ` Masahiro Yamada
2019-07-12 14:55 ` Masahiro Yamada
2019-07-12 15:37 ` Will Deacon
2019-07-12 15:37 ` Will Deacon
2019-07-18 11:41 ` [PATCH] arm64: vdso: Cleanup Makefiles Vincenzo Frascino
2019-07-18 11:41 ` Vincenzo Frascino
2019-07-19 8:04 ` Will Deacon [this message]
2019-07-19 8:04 ` Will Deacon
2019-07-19 9:49 ` Vincenzo Frascino
2019-07-19 9:49 ` Vincenzo Frascino
2019-07-19 10:10 ` [PATCH v2] " Vincenzo Frascino
2019-07-19 10:10 ` Vincenzo Frascino
2019-07-22 9:41 ` Will Deacon
2019-07-22 9:41 ` Will Deacon
2019-07-12 12:09 ` [PATCH v2 1/2] x86/vdso: fix flip/flop vdso build bug Vincenzo Frascino
2019-07-12 12:09 ` Vincenzo Frascino
2019-07-12 14:54 ` Masahiro Yamada
2019-07-12 14:54 ` Masahiro Yamada
2019-07-12 15:41 ` [tip:x86/urgent] x86/vdso: Fix " tip-bot for Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719080435.f3nlecyu3ysnsnpv@willie-the-truck \
--to=will@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=huw@codeweavers.com \
--cc=john.stultz@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=pcc@google.com \
--cc=salyzyn@android.com \
--cc=sthotton@marvell.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.