All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
To: linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	skunberg.kelsey@gmail.com
Subject: [PATCH v3] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 14:34:16 -0600	[thread overview]
Message-ID: <20190715203416.37547-1-skunberg.kelsey@gmail.com> (raw)
In-Reply-To: <20190715181312.31403-1-skunberg.kelsey@gmail.com>

Remove the following uncalled functions from include/linux/pci.h:

        pci_block_cfg_access()
        pci_block_cfg_access_in_atomic()
        pci_unblock_cfg_access()

Functions were added in commit fb51ccbf217c ("PCI: Rework config space
blocking services"), though no callers were added. Code continues to be
unused and should be removed.

Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
---

Changes since v1:
  - Fixed Signed-off-by line to show full name

Changes since v2:
  - Change commit message to reference prior commit properly with the
    following format:
	commit <12-character sha prefix> ("<commit message>")

 include/linux/pci.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index cf380544c700..3c9ba6133bea 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1656,11 +1656,6 @@ static inline void pci_release_regions(struct pci_dev *dev) { }
 
 static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }
 
-static inline void pci_block_cfg_access(struct pci_dev *dev) { }
-static inline int pci_block_cfg_access_in_atomic(struct pci_dev *dev)
-{ return 0; }
-static inline void pci_unblock_cfg_access(struct pci_dev *dev) { }
-
 static inline struct pci_bus *pci_find_next_bus(const struct pci_bus *from)
 { return NULL; }
 static inline struct pci_dev *pci_get_slot(struct pci_bus *bus,
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey at gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v3] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 14:34:16 -0600	[thread overview]
Message-ID: <20190715203416.37547-1-skunberg.kelsey@gmail.com> (raw)
In-Reply-To: <20190715181312.31403-1-skunberg.kelsey@gmail.com>

Remove the following uncalled functions from include/linux/pci.h:

        pci_block_cfg_access()
        pci_block_cfg_access_in_atomic()
        pci_unblock_cfg_access()

Functions were added in commit fb51ccbf217c ("PCI: Rework config space
blocking services"), though no callers were added. Code continues to be
unused and should be removed.

Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---

Changes since v1:
  - Fixed Signed-off-by line to show full name

Changes since v2:
  - Change commit message to reference prior commit properly with the
    following format:
	commit <12-character sha prefix> ("<commit message>")

 include/linux/pci.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index cf380544c700..3c9ba6133bea 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1656,11 +1656,6 @@ static inline void pci_release_regions(struct pci_dev *dev) { }
 
 static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }
 
-static inline void pci_block_cfg_access(struct pci_dev *dev) { }
-static inline int pci_block_cfg_access_in_atomic(struct pci_dev *dev)
-{ return 0; }
-static inline void pci_unblock_cfg_access(struct pci_dev *dev) { }
-
 static inline struct pci_bus *pci_find_next_bus(const struct pci_bus *from)
 { return NULL; }
 static inline struct pci_dev *pci_get_slot(struct pci_bus *bus,
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey@gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v3] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 14:34:16 -0600	[thread overview]
Message-ID: <20190715203416.37547-1-skunberg.kelsey@gmail.com> (raw)
Message-ID: <20190715203416.dB7T8DwZkGBotk0_t68SXD8tPBBvCVcjkRzl3guxjUI@z> (raw)
In-Reply-To: <20190715181312.31403-1-skunberg.kelsey@gmail.com>

Remove the following uncalled functions from include/linux/pci.h:

        pci_block_cfg_access()
        pci_block_cfg_access_in_atomic()
        pci_unblock_cfg_access()

Functions were added in commit fb51ccbf217c ("PCI: Rework config space
blocking services"), though no callers were added. Code continues to be
unused and should be removed.

Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---

Changes since v1:
  - Fixed Signed-off-by line to show full name

Changes since v2:
  - Change commit message to reference prior commit properly with the
    following format:
	commit <12-character sha prefix> ("<commit message>")

 include/linux/pci.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index cf380544c700..3c9ba6133bea 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1656,11 +1656,6 @@ static inline void pci_release_regions(struct pci_dev *dev) { }
 
 static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }
 
-static inline void pci_block_cfg_access(struct pci_dev *dev) { }
-static inline int pci_block_cfg_access_in_atomic(struct pci_dev *dev)
-{ return 0; }
-static inline void pci_unblock_cfg_access(struct pci_dev *dev) { }
-
 static inline struct pci_bus *pci_find_next_bus(const struct pci_bus *from)
 { return NULL; }
 static inline struct pci_dev *pci_get_slot(struct pci_bus *bus,
-- 
2.20.1

  parent reply	other threads:[~2019-07-15 20:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 17:56 [PATCH] PCI: Remove functions not called in include/linux/pci.h Kelsey
2019-07-15 17:56 ` [Linux-kernel-mentees] " Kelsey
2019-07-15 17:56 ` skunberg.kelsey
2019-07-15 18:13 ` [PATCH v2] " Kelsey Skunberg
2019-07-15 18:13   ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-15 18:13   ` skunberg.kelsey
2019-07-15 19:42   ` Lukas Bulwahn
2019-07-15 19:42     ` Lukas Bulwahn
2019-07-15 19:42     ` lukas.bulwahn
2019-07-15 20:19     ` Kelsey Skunberg
2019-07-15 20:19       ` Kelsey Skunberg
2019-07-15 20:19       ` skunberg.kelsey
2019-07-15 23:37     ` Bjorn Helgaas
2019-07-15 23:37       ` Bjorn Helgaas
2019-07-15 23:37       ` helgaas
2019-07-16  3:57       ` Kelsey Skunberg
2019-07-16  3:57         ` Kelsey Skunberg
2019-07-16  3:57         ` skunberg.kelsey
2019-07-15 20:34   ` Kelsey Skunberg [this message]
2019-07-15 20:34     ` [Linux-kernel-mentees] [PATCH v3] " Kelsey Skunberg
2019-07-15 20:34     ` skunberg.kelsey
2019-07-16  4:58     ` Lukas Bulwahn
2019-07-16  4:58       ` Lukas Bulwahn
2019-07-16  4:58       ` lukas.bulwahn
2019-07-23 23:34     ` Bjorn Helgaas
2019-07-23 23:34       ` Bjorn Helgaas
2019-07-23 23:34       ` helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715203416.37547-1-skunberg.kelsey@gmail.com \
    --to=skunberg.kelsey@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.