From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-pci@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 21:57:01 -0600 [thread overview]
Message-ID: <20190716035701.GA57724@JATN> (raw)
In-Reply-To: <20190715233717.GA79424@google.com>
On Mon, Jul 15, 2019 at 06:37:17PM -0500, Bjorn Helgaas wrote:
> On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote:
> > On Mon, 15 Jul 2019, Kelsey Skunberg wrote:
> >
> > > Remove the following uncalled functions from include/linux/pci.h:
> > >
> > > pci_block_cfg_access()
> > > pci_block_cfg_access_in_atomic()
> > > pci_unblock_cfg_access()
> > >
> > > Functions were added in patch fb51ccbf217c "PCI: Rework config space
> > > blocking services", ...
>
> > Also note that commits are referred to with this format:
> >
> > commit <12-character sha prefix> ("<commit message>")
>
> FWIW, I use this shell alias to generate these references:
>
> gsr is aliased to `git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
>
> $ gsr fb51ccb
> fb51ccbf217c ("PCI: Rework config space blocking services")
>
> Documentation/process/submitting-patches.rst mentions a 12-char (at
> least) SHA-1 but the e21d2170f36 example shows a *20*-char SHA-1,
> which seems excessive to me.
>
> I personally skip the word "commit" because I figure it's pretty
> obvious what it is, but it's fine either way.
>
> Bjorn
This is very useful! I definitely like the use of the alias. Thank you!
-Kelsey
WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey at gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 21:57:01 -0600 [thread overview]
Message-ID: <20190716035701.GA57724@JATN> (raw)
In-Reply-To: <20190715233717.GA79424@google.com>
On Mon, Jul 15, 2019 at 06:37:17PM -0500, Bjorn Helgaas wrote:
> On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote:
> > On Mon, 15 Jul 2019, Kelsey Skunberg wrote:
> >
> > > Remove the following uncalled functions from include/linux/pci.h:
> > >
> > > pci_block_cfg_access()
> > > pci_block_cfg_access_in_atomic()
> > > pci_unblock_cfg_access()
> > >
> > > Functions were added in patch fb51ccbf217c "PCI: Rework config space
> > > blocking services", ...
>
> > Also note that commits are referred to with this format:
> >
> > commit <12-character sha prefix> ("<commit message>")
>
> FWIW, I use this shell alias to generate these references:
>
> gsr is aliased to `git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
>
> $ gsr fb51ccb
> fb51ccbf217c ("PCI: Rework config space blocking services")
>
> Documentation/process/submitting-patches.rst mentions a 12-char (at
> least) SHA-1 but the e21d2170f36 example shows a *20*-char SHA-1,
> which seems excessive to me.
>
> I personally skip the word "commit" because I figure it's pretty
> obvious what it is, but it's fine either way.
>
> Bjorn
This is very useful! I definitely like the use of the alias. Thank you!
-Kelsey
WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey@gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 21:57:01 -0600 [thread overview]
Message-ID: <20190716035701.GA57724@JATN> (raw)
Message-ID: <20190716035701.xgSVJem6uKn2MA5gUx9MxJfOlq6EJO_RJM2EsG3yHhg@z> (raw)
In-Reply-To: <20190715233717.GA79424@google.com>
On Mon, Jul 15, 2019 at 06:37:17PM -0500, Bjorn Helgaas wrote:
> On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote:
> > On Mon, 15 Jul 2019, Kelsey Skunberg wrote:
> >
> > > Remove the following uncalled functions from include/linux/pci.h:
> > >
> > > pci_block_cfg_access()
> > > pci_block_cfg_access_in_atomic()
> > > pci_unblock_cfg_access()
> > >
> > > Functions were added in patch fb51ccbf217c "PCI: Rework config space
> > > blocking services", ...
>
> > Also note that commits are referred to with this format:
> >
> > commit <12-character sha prefix> ("<commit message>")
>
> FWIW, I use this shell alias to generate these references:
>
> gsr is aliased to `git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
>
> $ gsr fb51ccb
> fb51ccbf217c ("PCI: Rework config space blocking services")
>
> Documentation/process/submitting-patches.rst mentions a 12-char (at
> least) SHA-1 but the e21d2170f36 example shows a *20*-char SHA-1,
> which seems excessive to me.
>
> I personally skip the word "commit" because I figure it's pretty
> obvious what it is, but it's fine either way.
>
> Bjorn
This is very useful! I definitely like the use of the alias. Thank you!
-Kelsey
next prev parent reply other threads:[~2019-07-16 3:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:56 [PATCH] PCI: Remove functions not called in include/linux/pci.h Kelsey
2019-07-15 17:56 ` [Linux-kernel-mentees] " Kelsey
2019-07-15 17:56 ` skunberg.kelsey
2019-07-15 18:13 ` [PATCH v2] " Kelsey Skunberg
2019-07-15 18:13 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-15 18:13 ` skunberg.kelsey
2019-07-15 19:42 ` Lukas Bulwahn
2019-07-15 19:42 ` Lukas Bulwahn
2019-07-15 19:42 ` lukas.bulwahn
2019-07-15 20:19 ` Kelsey Skunberg
2019-07-15 20:19 ` Kelsey Skunberg
2019-07-15 20:19 ` skunberg.kelsey
2019-07-15 23:37 ` Bjorn Helgaas
2019-07-15 23:37 ` Bjorn Helgaas
2019-07-15 23:37 ` helgaas
2019-07-16 3:57 ` Kelsey Skunberg [this message]
2019-07-16 3:57 ` Kelsey Skunberg
2019-07-16 3:57 ` skunberg.kelsey
2019-07-15 20:34 ` [PATCH v3] " Kelsey Skunberg
2019-07-15 20:34 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-15 20:34 ` skunberg.kelsey
2019-07-16 4:58 ` Lukas Bulwahn
2019-07-16 4:58 ` Lukas Bulwahn
2019-07-16 4:58 ` lukas.bulwahn
2019-07-23 23:34 ` Bjorn Helgaas
2019-07-23 23:34 ` Bjorn Helgaas
2019-07-23 23:34 ` helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716035701.GA57724@JATN \
--to=skunberg.kelsey@gmail.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.