All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Riedmueller <s.riedmueller@phytec.de>
Cc: s.hauer@pengutronix.de, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, martyn.welch@collabora.com,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/10] ARM: dts: imx6ul: segin: Add boot media to dts filename
Date: Tue, 23 Jul 2019 11:10:33 +0800	[thread overview]
Message-ID: <20190723031032.GM3738@dragon> (raw)
In-Reply-To: <1562656767-273566-3-git-send-email-s.riedmueller@phytec.de>

On Tue, Jul 09, 2019 at 09:19:19AM +0200, Stefan Riedmueller wrote:
> There is now a PHYTEC phyCORE-i.MX 6UL with eMMC instead of NAND flash
> available. The dts filename needs to reflect that to differentiate both.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
>  arch/arm/boot/dts/Makefile                                           | 2 +-
>  ...l-phytec-segin-ff-rdk.dts => imx6ul-phytec-segin-ff-rdk-nand.dts} | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>  rename arch/arm/boot/dts/{imx6ul-phytec-segin-ff-rdk.dts => imx6ul-phytec-segin-ff-rdk-nand.dts} (85%)
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index e1924b06f3cb..668b57c8cc57 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -573,7 +573,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ul-opos6uldev.dtb \
>  	imx6ul-pico-hobbit.dtb \
>  	imx6ul-pico-pi.dtb \
> -	imx6ul-phytec-segin-ff-rdk.dtb \
> +	imx6ul-phytec-segin-ff-rdk-nand.dtb \
>  	imx6ul-tx6ul-0010.dtb \
>  	imx6ul-tx6ul-0011.dtb \
>  	imx6ul-tx6ul-mainboard.dtb \
> diff --git a/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts b/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> similarity index 85%
> rename from arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts
> rename to arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> index 1e59183a2f7c..dc06029c5701 100644
> --- a/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts
> +++ b/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> @@ -10,8 +10,9 @@
>  #include "imx6ul-phytec-segin-peb-eval-01.dtsi"
>  
>  / {
> -	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured";
> -	compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063", "fsl,imx6ul";
> +	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with NAND";
> +	compatible = "phytec,imx6ul-pbacd10-nand", "phytec,imx6ul-pbacd10",

The board compatibles need to be documented.

Shawn

> +		     "phytec,imx6ul-pcl063", "fsl,imx6ul";
>  };
>  
>  &adc1 {
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Riedmueller <s.riedmueller@phytec.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	martyn.welch@collabora.com, s.hauer@pengutronix.de,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/10] ARM: dts: imx6ul: segin: Add boot media to dts filename
Date: Tue, 23 Jul 2019 11:10:33 +0800	[thread overview]
Message-ID: <20190723031032.GM3738@dragon> (raw)
In-Reply-To: <1562656767-273566-3-git-send-email-s.riedmueller@phytec.de>

On Tue, Jul 09, 2019 at 09:19:19AM +0200, Stefan Riedmueller wrote:
> There is now a PHYTEC phyCORE-i.MX 6UL with eMMC instead of NAND flash
> available. The dts filename needs to reflect that to differentiate both.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
>  arch/arm/boot/dts/Makefile                                           | 2 +-
>  ...l-phytec-segin-ff-rdk.dts => imx6ul-phytec-segin-ff-rdk-nand.dts} | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>  rename arch/arm/boot/dts/{imx6ul-phytec-segin-ff-rdk.dts => imx6ul-phytec-segin-ff-rdk-nand.dts} (85%)
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index e1924b06f3cb..668b57c8cc57 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -573,7 +573,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ul-opos6uldev.dtb \
>  	imx6ul-pico-hobbit.dtb \
>  	imx6ul-pico-pi.dtb \
> -	imx6ul-phytec-segin-ff-rdk.dtb \
> +	imx6ul-phytec-segin-ff-rdk-nand.dtb \
>  	imx6ul-tx6ul-0010.dtb \
>  	imx6ul-tx6ul-0011.dtb \
>  	imx6ul-tx6ul-mainboard.dtb \
> diff --git a/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts b/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> similarity index 85%
> rename from arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts
> rename to arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> index 1e59183a2f7c..dc06029c5701 100644
> --- a/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk.dts
> +++ b/arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts
> @@ -10,8 +10,9 @@
>  #include "imx6ul-phytec-segin-peb-eval-01.dtsi"
>  
>  / {
> -	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured";
> -	compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063", "fsl,imx6ul";
> +	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with NAND";
> +	compatible = "phytec,imx6ul-pbacd10-nand", "phytec,imx6ul-pbacd10",

The board compatibles need to be documented.

Shawn

> +		     "phytec,imx6ul-pcl063", "fsl,imx6ul";
>  };
>  
>  &adc1 {
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-23  3:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  7:19 [PATCH 00/10] Add further support for PHYTEC phyBOARD-Segin Stefan Riedmueller
2019-07-09  7:19 ` Stefan Riedmueller
2019-07-09  7:19 ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 01/10] ARM: dts: imx6ul: phyboard-segin: Rename dts to PHYTEC name scheme Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 02/10] ARM: dts: imx6ul: segin: Add boot media to dts filename Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-23  3:10   ` Shawn Guo [this message]
2019-07-23  3:10     ` Shawn Guo
2019-07-09  7:19 ` [PATCH 03/10] ARM: dts: imx6ul: segin: Reduce eth drive strength Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 04/10] ARM: dts: imx6ul: segin: Fix LED naming for phyCORE and PEB-EVAL-01 Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 05/10] ARM: dts: imx6ul: segin: Make FEC and ethphy configurable in dts Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 06/10] ARM: dts: imx6ul: segin: Only enable NAND if it is populated Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 07/10] ARM: dts: imx6ul: phycore: Add eMMC at usdhc2 Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 08/10] ARM: dts: imx6ul: segin: Move ECSPI interface to board include file Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 09/10] ARM: dts: imx6ul: segin: Move machine include to dts files Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19 ` [PATCH 10/10] ARM: dts: imx6ull: Add support for PHYTEC phyBOARD-Segin with i.MX 6ULL Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-09  7:19   ` Stefan Riedmueller
2019-07-23  5:39 ` [PATCH 00/10] Add further support for PHYTEC phyBOARD-Segin Shawn Guo
2019-07-23  5:39   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723031032.GM3738@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martyn.welch@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.riedmueller@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.