From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: broonie@kernel.org, lgirdwood@gmail.com Cc: alsa-devel@alsa-project.org, nsekhar@ti.com, kuninori.morimoto.gx@renesas.com Subject: [PATCH 0/4] ASoC: ti: davinci: Fixes for daVinci boards with McBSP Date: Fri, 30 Aug 2019 13:38:37 +0300 [thread overview] Message-ID: <20190830103841.25128-1-peter.ujfalusi@ti.com> (raw) Hi, Morimoto-san pointed out in a private thread that the davinci-i2s driver is using snd_soc_rtdcom_lookup(), which is should not really. It took a while to get access to a daVinci board which uses McBSP, but eventually I got access to a remote dm644x-evm and dma365-evm. Initially the audio was not even probing on them (fixes sent for mach-davinci), but then the driver was still crashing and not behaving correctly. With the 4 patch dm644x-evm have working audio and the offending snd_soc_rtdcom_lookup() is gone from the driver. dm365-evm still have some issues regarding to EDMA, but it looks like a system issue which can be fixed later. Regards, Peter --- Peter Ujfalusi (4): ASoC: ti: davinci-i2s: Add S32_LE as support format ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP sound/soc/ti/davinci-evm.c | 2 +- sound/soc/ti/davinci-i2s.c | 90 +++++++++++++++++--------------------- sound/soc/ti/edma-pcm.c | 17 ++++++- 3 files changed, 57 insertions(+), 52 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: <broonie@kernel.org>, <lgirdwood@gmail.com> Cc: alsa-devel@alsa-project.org, nsekhar@ti.com, kuninori.morimoto.gx@renesas.com Subject: [alsa-devel] [PATCH 0/4] ASoC: ti: davinci: Fixes for daVinci boards with McBSP Date: Fri, 30 Aug 2019 13:38:37 +0300 [thread overview] Message-ID: <20190830103841.25128-1-peter.ujfalusi@ti.com> (raw) Message-ID: <20190830103837.uP8e_PHZwpLm4yqhNSNkxyis1rr9S_zNjz0ARacJhKc@z> (raw) Hi, Morimoto-san pointed out in a private thread that the davinci-i2s driver is using snd_soc_rtdcom_lookup(), which is should not really. It took a while to get access to a daVinci board which uses McBSP, but eventually I got access to a remote dm644x-evm and dma365-evm. Initially the audio was not even probing on them (fixes sent for mach-davinci), but then the driver was still crashing and not behaving correctly. With the 4 patch dm644x-evm have working audio and the offending snd_soc_rtdcom_lookup() is gone from the driver. dm365-evm still have some issues regarding to EDMA, but it looks like a system issue which can be fixed later. Regards, Peter --- Peter Ujfalusi (4): ASoC: ti: davinci-i2s: Add S32_LE as support format ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP sound/soc/ti/davinci-evm.c | 2 +- sound/soc/ti/davinci-i2s.c | 90 +++++++++++++++++--------------------- sound/soc/ti/edma-pcm.c | 17 ++++++- 3 files changed, 57 insertions(+), 52 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2019-08-30 10:38 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-30 10:38 Peter Ujfalusi [this message] 2019-08-30 10:38 ` [alsa-devel] [PATCH 0/4] ASoC: ti: davinci: Fixes for daVinci boards with McBSP Peter Ujfalusi 2019-08-30 10:38 ` [PATCH 1/4] ASoC: ti: davinci-i2s: Add S32_LE as support format Peter Ujfalusi 2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi 2019-08-30 11:45 ` Applied "ASoC: ti: davinci-i2s: Add S32_LE as support format" to the asoc tree Mark Brown 2019-08-30 11:45 ` [alsa-devel] " Mark Brown 2019-08-30 10:38 ` [PATCH 2/4] ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback Peter Ujfalusi 2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi 2019-08-30 11:45 ` Applied "ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback" to the asoc tree Mark Brown 2019-08-30 11:45 ` [alsa-devel] " Mark Brown 2019-08-30 10:38 ` [PATCH 3/4] ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup Peter Ujfalusi 2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi 2019-08-30 11:45 ` Applied "ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup" to the asoc tree Mark Brown 2019-08-30 11:45 ` [alsa-devel] " Mark Brown 2019-08-30 10:38 ` [PATCH 4/4] ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP Peter Ujfalusi 2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi 2019-08-30 11:45 ` Applied "ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP" to the asoc tree Mark Brown 2019-08-30 11:45 ` [alsa-devel] " Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190830103841.25128-1-peter.ujfalusi@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=lgirdwood@gmail.com \ --cc=nsekhar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.