From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: alsa-devel@alsa-project.org, nsekhar@ti.com,
kuninori.morimoto.gx@renesas.com
Subject: [PATCH 4/4] ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP
Date: Fri, 30 Aug 2019 13:38:41 +0300 [thread overview]
Message-ID: <20190830103841.25128-5-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20190830103841.25128-1-peter.ujfalusi@ti.com>
The davinci McBSP (davinci-i2s) driver does not implement the set_sysclk
callback, which is fine and should not be treated as error.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/ti/davinci-evm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/ti/davinci-evm.c b/sound/soc/ti/davinci-evm.c
index bfd8d1a03ba7..686b23d7a90d 100644
--- a/sound/soc/ti/davinci-evm.c
+++ b/sound/soc/ti/davinci-evm.c
@@ -68,7 +68,7 @@ static int evm_hw_params(struct snd_pcm_substream *substream,
/* set the CPU system clock */
ret = snd_soc_dai_set_sysclk(cpu_dai, 0, sysclk, SND_SOC_CLOCK_OUT);
- if (ret < 0)
+ if (ret < 0 && ret != -ENOTSUPP)
return ret;
return 0;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, nsekhar@ti.com,
kuninori.morimoto.gx@renesas.com
Subject: [alsa-devel] [PATCH 4/4] ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP
Date: Fri, 30 Aug 2019 13:38:41 +0300 [thread overview]
Message-ID: <20190830103841.25128-5-peter.ujfalusi@ti.com> (raw)
Message-ID: <20190830103841.9I8GeFaNB-kAtIywslxOx7c8ip-B1EoaF5q0v9eQdWA@z> (raw)
In-Reply-To: <20190830103841.25128-1-peter.ujfalusi@ti.com>
The davinci McBSP (davinci-i2s) driver does not implement the set_sysclk
callback, which is fine and should not be treated as error.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/ti/davinci-evm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/ti/davinci-evm.c b/sound/soc/ti/davinci-evm.c
index bfd8d1a03ba7..686b23d7a90d 100644
--- a/sound/soc/ti/davinci-evm.c
+++ b/sound/soc/ti/davinci-evm.c
@@ -68,7 +68,7 @@ static int evm_hw_params(struct snd_pcm_substream *substream,
/* set the CPU system clock */
ret = snd_soc_dai_set_sysclk(cpu_dai, 0, sysclk, SND_SOC_CLOCK_OUT);
- if (ret < 0)
+ if (ret < 0 && ret != -ENOTSUPP)
return ret;
return 0;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-08-30 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 10:38 [PATCH 0/4] ASoC: ti: davinci: Fixes for daVinci boards with McBSP Peter Ujfalusi
2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi
2019-08-30 10:38 ` [PATCH 1/4] ASoC: ti: davinci-i2s: Add S32_LE as support format Peter Ujfalusi
2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi
2019-08-30 11:45 ` Applied "ASoC: ti: davinci-i2s: Add S32_LE as support format" to the asoc tree Mark Brown
2019-08-30 11:45 ` [alsa-devel] " Mark Brown
2019-08-30 10:38 ` [PATCH 2/4] ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback Peter Ujfalusi
2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi
2019-08-30 11:45 ` Applied "ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback" to the asoc tree Mark Brown
2019-08-30 11:45 ` [alsa-devel] " Mark Brown
2019-08-30 10:38 ` [PATCH 3/4] ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup Peter Ujfalusi
2019-08-30 10:38 ` [alsa-devel] " Peter Ujfalusi
2019-08-30 11:45 ` Applied "ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup" to the asoc tree Mark Brown
2019-08-30 11:45 ` [alsa-devel] " Mark Brown
2019-08-30 10:38 ` Peter Ujfalusi [this message]
2019-08-30 10:38 ` [alsa-devel] [PATCH 4/4] ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP Peter Ujfalusi
2019-08-30 11:45 ` Applied "ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP" to the asoc tree Mark Brown
2019-08-30 11:45 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830103841.25128-5-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.