From: Daniel Thompson <daniel.thompson@linaro.org> To: Andreas Kemnade <andreas@kemnade.info> Cc: lee.jones@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, "H. Nikolaus Schaller" <hns@goldelico.com> Subject: Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Date: Wed, 11 Sep 2019 11:25:33 +0100 [thread overview] Message-ID: <20190911102533.not4ta3xwgm6bhjo@holly.lan> (raw) In-Reply-To: <20190910212909.18095-3-andreas@kemnade.info> On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: > For now just enable it in the probe function to allow i2c > access. Disabling also means resetting the register values > to default and according to the datasheet does not give > power savings > > Tested on Kobo Clara HD. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > changes in v2: > - simplification > - correct gpio direction initialisation > > drivers/video/backlight/lm3630a_bl.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c > index 8f84f3684f04..9d0639d4202d 100644 > --- a/drivers/video/backlight/lm3630a_bl.c > +++ b/drivers/video/backlight/lm3630a_bl.c > @@ -12,6 +12,8 @@ > #include <linux/uaccess.h> > #include <linux/interrupt.h> > #include <linux/regmap.h> > +#include <linux/gpio/consumer.h> > +#include <linux/gpio.h> Nitpicking... but I don't think linux/gpio.h is used anymore. > #include <linux/pwm.h> > #include <linux/platform_data/lm3630a_bl.h> > > @@ -48,6 +50,7 @@ struct lm3630a_chip { > struct lm3630a_platform_data *pdata; > struct backlight_device *bleda; > struct backlight_device *bledb; > + struct gpio_desc *enable_gpio; > struct regmap *regmap; > struct pwm_device *pwmd; > }; > @@ -535,6 +538,13 @@ static int lm3630a_probe(struct i2c_client *client, > } > pchip->pdata = pdata; > > + pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", > + GPIOD_OUT_HIGH); > + if (IS_ERR(pchip->enable_gpio)) { > + rval = PTR_ERR(pchip->enable_gpio); > + return rval; > + } > + > /* chip initialize */ > rval = lm3630a_chip_init(pchip); > if (rval < 0) { > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org> To: Andreas Kemnade <andreas@kemnade.info> Cc: lee.jones@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, "H. Nikolaus Schaller" <hns@goldelico.com> Subject: Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Date: Wed, 11 Sep 2019 10:25:33 +0000 [thread overview] Message-ID: <20190911102533.not4ta3xwgm6bhjo@holly.lan> (raw) In-Reply-To: <20190910212909.18095-3-andreas@kemnade.info> On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: > For now just enable it in the probe function to allow i2c > access. Disabling also means resetting the register values > to default and according to the datasheet does not give > power savings > > Tested on Kobo Clara HD. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > changes in v2: > - simplification > - correct gpio direction initialisation > > drivers/video/backlight/lm3630a_bl.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c > index 8f84f3684f04..9d0639d4202d 100644 > --- a/drivers/video/backlight/lm3630a_bl.c > +++ b/drivers/video/backlight/lm3630a_bl.c > @@ -12,6 +12,8 @@ > #include <linux/uaccess.h> > #include <linux/interrupt.h> > #include <linux/regmap.h> > +#include <linux/gpio/consumer.h> > +#include <linux/gpio.h> Nitpicking... but I don't think linux/gpio.h is used anymore. > #include <linux/pwm.h> > #include <linux/platform_data/lm3630a_bl.h> > > @@ -48,6 +50,7 @@ struct lm3630a_chip { > struct lm3630a_platform_data *pdata; > struct backlight_device *bleda; > struct backlight_device *bledb; > + struct gpio_desc *enable_gpio; > struct regmap *regmap; > struct pwm_device *pwmd; > }; > @@ -535,6 +538,13 @@ static int lm3630a_probe(struct i2c_client *client, > } > pchip->pdata = pdata; > > + pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", > + GPIOD_OUT_HIGH); > + if (IS_ERR(pchip->enable_gpio)) { > + rval = PTR_ERR(pchip->enable_gpio); > + return rval; > + } > + > /* chip initialize */ > rval = lm3630a_chip_init(pchip); > if (rval < 0) { > -- > 2.20.1 >
next prev parent reply other threads:[~2019-09-11 10:25 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-10 21:29 [PATCH v2 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade 2019-09-10 21:29 ` Andreas Kemnade 2019-09-10 21:29 ` [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade 2019-09-10 21:29 ` Andreas Kemnade 2019-09-11 10:08 ` Daniel Thompson 2019-09-11 10:08 ` Daniel Thompson 2019-09-11 18:44 ` Dan Murphy 2019-09-11 18:44 ` Dan Murphy 2019-09-11 18:44 ` Dan Murphy 2019-09-10 21:29 ` [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade 2019-09-10 21:29 ` Andreas Kemnade 2019-09-11 10:25 ` Daniel Thompson [this message] 2019-09-11 10:25 ` Daniel Thompson 2019-09-11 18:48 ` Dan Murphy 2019-09-11 18:48 ` Dan Murphy 2019-09-11 18:48 ` Dan Murphy 2019-09-11 20:25 ` Andreas Kemnade 2019-09-11 20:25 ` Andreas Kemnade 2019-09-11 20:25 ` Andreas Kemnade 2019-09-12 9:18 ` Daniel Thompson 2019-09-12 9:18 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190911102533.not4ta3xwgm6bhjo@holly.lan \ --to=daniel.thompson@linaro.org \ --cc=andreas@kemnade.info \ --cc=b.zolnierkie@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hns@goldelico.com \ --cc=jacek.anaszewski@gmail.com \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.