From: Dan Murphy <dmurphy@ti.com>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Andreas Kemnade <andreas@kemnade.info>
Cc: <lee.jones@linaro.org>, <jingoohan1@gmail.com>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<b.zolnierkie@samsung.com>, <dri-devel@lists.freedesktop.org>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Wed, 11 Sep 2019 13:44:01 -0500 [thread overview]
Message-ID: <3d8237d0-4e36-3787-6050-b0e75f2fa8c3@ti.com> (raw)
In-Reply-To: <20190911100851.f4rnldghtmly26oo@holly.lan>
Andreas
On 9/11/19 5:08 AM, Daniel Thompson wrote:
> On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote:
>> add enable-gpios to describe HWEN pin
>>
>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>> ---
>> changes in v2: add example
>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> index dc129d9a329e..1fa83feffe16 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> @@ -29,6 +29,10 @@ properties:
>> '#size-cells':
>> const: 0
>>
>> + enable-gpios:
>> + description: GPIO to use to enable/disable the backlight (HWEN pin).
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -92,6 +96,7 @@ examples:
>> i2c {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
This is in the wrong place. This is implying that the gpio is for the
i2c parent
This needs to go under the led-controller node below
Dan
>>
>> led-controller@38 {
>> compatible = "ti,lm3630a";
>> --
>> 2.20.1
>>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Wed, 11 Sep 2019 13:44:01 -0500 [thread overview]
Message-ID: <3d8237d0-4e36-3787-6050-b0e75f2fa8c3@ti.com> (raw)
In-Reply-To: <20190911100851.f4rnldghtmly26oo@holly.lan>
Andreas
On 9/11/19 5:08 AM, Daniel Thompson wrote:
> On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote:
>> add enable-gpios to describe HWEN pin
>>
>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>> ---
>> changes in v2: add example
>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> index dc129d9a329e..1fa83feffe16 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> @@ -29,6 +29,10 @@ properties:
>> '#size-cells':
>> const: 0
>>
>> + enable-gpios:
>> + description: GPIO to use to enable/disable the backlight (HWEN pin).
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -92,6 +96,7 @@ examples:
>> i2c {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
This is in the wrong place. This is implying that the gpio is for the
i2c parent
This needs to go under the led-controller node below
Dan
>>
>> led-controller@38 {
>> compatible = "ti,lm3630a";
>> --
>> 2.20.1
>>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Wed, 11 Sep 2019 18:44:01 +0000 [thread overview]
Message-ID: <3d8237d0-4e36-3787-6050-b0e75f2fa8c3@ti.com> (raw)
In-Reply-To: <20190911100851.f4rnldghtmly26oo@holly.lan>
Andreas
On 9/11/19 5:08 AM, Daniel Thompson wrote:
> On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote:
>> add enable-gpios to describe HWEN pin
>>
>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>> ---
>> changes in v2: add example
>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> index dc129d9a329e..1fa83feffe16 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>> @@ -29,6 +29,10 @@ properties:
>> '#size-cells':
>> const: 0
>>
>> + enable-gpios:
>> + description: GPIO to use to enable/disable the backlight (HWEN pin).
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -92,6 +96,7 @@ examples:
>> i2c {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
This is in the wrong place. This is implying that the gpio is for the
i2c parent
This needs to go under the led-controller node below
Dan
>>
>> led-controller@38 {
>> compatible = "ti,lm3630a";
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2019-09-11 18:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 21:29 [PATCH v2 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade
2019-09-10 21:29 ` Andreas Kemnade
2019-09-10 21:29 ` [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade
2019-09-10 21:29 ` Andreas Kemnade
2019-09-11 10:08 ` Daniel Thompson
2019-09-11 10:08 ` Daniel Thompson
2019-09-11 18:44 ` Dan Murphy [this message]
2019-09-11 18:44 ` Dan Murphy
2019-09-11 18:44 ` Dan Murphy
2019-09-10 21:29 ` [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade
2019-09-10 21:29 ` Andreas Kemnade
2019-09-11 10:25 ` Daniel Thompson
2019-09-11 10:25 ` Daniel Thompson
2019-09-11 18:48 ` Dan Murphy
2019-09-11 18:48 ` Dan Murphy
2019-09-11 18:48 ` Dan Murphy
2019-09-11 20:25 ` Andreas Kemnade
2019-09-11 20:25 ` Andreas Kemnade
2019-09-11 20:25 ` Andreas Kemnade
2019-09-12 9:18 ` Daniel Thompson
2019-09-12 9:18 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8237d0-4e36-3787-6050-b0e75f2fa8c3@ti.com \
--to=dmurphy@ti.com \
--cc=andreas@kemnade.info \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.