From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Mark Rutland" <mark.rutland@arm.com>, "Kukjin Kim" <kgene@kernel.org>, "Jonathan Cameron" <jic23@kernel.org>, "Hartmut Knaack" <knaack.h@gmx.de>, "Lars-Peter Clausen" <lars@metafoo.de>, "Peter Meerwald-Stadler" <pmeerw@pmeerw.net>, "Sebastian Reichel" <sre@kernel.org>, "Alessandro Zummo" <a.zummo@towertech.it>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 07/11] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema Date: Wed, 18 Sep 2019 07:43:06 -0500 [thread overview] Message-ID: <20190918124306.GB318@bogus> (raw) In-Reply-To: <20190907092007.9946-7-krzk@kernel.org> On Sat, Sep 07, 2019 at 11:20:03AM +0200, Krzysztof Kozlowski wrote: > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > format using json-schema. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v1: > 1. Fix clock-names to match all elements against schema (any number of > any clkoutN values). > This currently fails: > properties:clock-names:items: {'enum': ['clkout0', 'clkout1', 'clkout2', > 'clkout3', 'clkout4', 'clkout5', 'clkout6', 'clkout7', 'clkout8', > 'clkout9', 'clkout10', 'clkout11', 'clkout12', 'clkout13', 'clkout14', > 'clkout15', 'clkout16']} is not of type 'array > > 2. Add syscon reboot and poweroff nodes. > --- > .../devicetree/bindings/arm/samsung/pmu.txt | 72 ----------- > .../devicetree/bindings/arm/samsung/pmu.yaml | 117 ++++++++++++++++++ > 2 files changed, 117 insertions(+), 72 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > deleted file mode 100644 > index 433bfd7593ac..000000000000 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > +++ /dev/null > @@ -1,72 +0,0 @@ > -SAMSUNG Exynos SoC series PMU Registers > - > -Properties: > - - compatible : should contain two values. First value must be one from following list: > - - "samsung,exynos3250-pmu" - for Exynos3250 SoC, > - - "samsung,exynos4210-pmu" - for Exynos4210 SoC, > - - "samsung,exynos4412-pmu" - for Exynos4412 SoC, > - - "samsung,exynos5250-pmu" - for Exynos5250 SoC, > - - "samsung,exynos5260-pmu" - for Exynos5260 SoC. > - - "samsung,exynos5410-pmu" - for Exynos5410 SoC, > - - "samsung,exynos5420-pmu" - for Exynos5420 SoC. > - - "samsung,exynos5433-pmu" - for Exynos5433 SoC. > - - "samsung,exynos7-pmu" - for Exynos7 SoC. > - second value must be always "syscon". > - > - - reg : offset and length of the register set. > - > - - #clock-cells : must be <1>, since PMU requires once cell as clock specifier. > - The single specifier cell is used as index to list of clocks > - provided by PMU, which is currently: > - 0 : SoC clock output (CLKOUT pin) > - > - - clock-names : list of clock names for particular CLKOUT mux inputs in > - following format: > - "clkoutN", where N is a decimal number corresponding to > - CLKOUT mux control bits value for given input, e.g. > - "clkout0", "clkout7", "clkout15". > - > - - clocks : list of phandles and specifiers to all input clocks listed in > - clock-names property. > - > -Optional properties: > - > -Some PMUs are capable of behaving as an interrupt controller (mostly > -to wake up a suspended PMU). In which case, they can have the > -following properties: > - > -- interrupt-controller: indicate that said PMU is an interrupt controller > - > -- #interrupt-cells: must be identical to the that of the parent interrupt > - controller. > - > - > -Optional nodes: > - > -- nodes defining the restart and poweroff syscon children > - > - > -Example : > -pmu_system_controller: system-controller@10040000 { > - compatible = "samsung,exynos5250-pmu", "syscon"; > - reg = <0x10040000 0x5000>; > - interrupt-controller; > - #interrupt-cells = <3>; > - interrupt-parent = <&gic>; > - #clock-cells = <1>; > - clock-names = "clkout0", "clkout1", "clkout2", "clkout3", > - "clkout4", "clkout8", "clkout9"; > - clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>, > - <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>, > - <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, > - <&clock CLK_XUSBXTI>; > -}; > - > -Example of clock consumer : > - > -usb3503: usb3503@8 { > - /* ... */ > - clock-names = "refclk"; > - clocks = <&pmu_system_controller 0>; > - /* ... */ > -}; > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > new file mode 100644 > index 000000000000..a5a02f8237fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC series Power Management Unit (PMU) > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + > +properties: > + compatible: > + items: > + - enum: > + - samsung,exynos3250-pmu > + - samsung,exynos4210-pmu > + - samsung,exynos4412-pmu > + - samsung,exynos5250-pmu > + - samsung,exynos5260-pmu > + - samsung,exynos5410-pmu > + - samsung,exynos5420-pmu > + - samsung,exynos5433-pmu > + - samsung,exynos7-pmu > + - const: syscon > + > + reg: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + > + clock-names: > + description: > + List of clock names for particular CLKOUT mux inputs > + minItems: 1 > + maxItems: 32 > + items: > + enum: > + - clkout0 > + - clkout1 Looking at this again, instead of enum, we can just do: pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > + - clkout2 > + - clkout3 > + - clkout4 > + - clkout5 > + - clkout6 > + - clkout7 > + - clkout8 > + - clkout9 > + - clkout10 > + - clkout11 > + - clkout12 > + - clkout13 > + - clkout14 > + - clkout15 > + - clkout16 > + - clkout17 > + - clkout18 > + - clkout19 > + - clkout20 > + - clkout21 > + - clkout22 > + - clkout23 > + - clkout24 > + - clkout25 > + - clkout26 > + - clkout27 > + - clkout28 > + - clkout29 > + - clkout30 > + - clkout31
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Mark Rutland" <mark.rutland@arm.com>, "Alessandro Zummo" <a.zummo@towertech.it>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Lars-Peter Clausen" <lars@metafoo.de>, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org, "Sebastian Reichel" <sre@kernel.org>, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org, "Peter Meerwald-Stadler" <pmeerw@pmeerw.net>, "Hartmut Knaack" <knaack.h@gmx.de>, linux-rtc@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>, "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com> Subject: Re: [PATCH v2 07/11] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema Date: Wed, 18 Sep 2019 07:43:06 -0500 [thread overview] Message-ID: <20190918124306.GB318@bogus> (raw) In-Reply-To: <20190907092007.9946-7-krzk@kernel.org> On Sat, Sep 07, 2019 at 11:20:03AM +0200, Krzysztof Kozlowski wrote: > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > format using json-schema. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v1: > 1. Fix clock-names to match all elements against schema (any number of > any clkoutN values). > This currently fails: > properties:clock-names:items: {'enum': ['clkout0', 'clkout1', 'clkout2', > 'clkout3', 'clkout4', 'clkout5', 'clkout6', 'clkout7', 'clkout8', > 'clkout9', 'clkout10', 'clkout11', 'clkout12', 'clkout13', 'clkout14', > 'clkout15', 'clkout16']} is not of type 'array > > 2. Add syscon reboot and poweroff nodes. > --- > .../devicetree/bindings/arm/samsung/pmu.txt | 72 ----------- > .../devicetree/bindings/arm/samsung/pmu.yaml | 117 ++++++++++++++++++ > 2 files changed, 117 insertions(+), 72 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > deleted file mode 100644 > index 433bfd7593ac..000000000000 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > +++ /dev/null > @@ -1,72 +0,0 @@ > -SAMSUNG Exynos SoC series PMU Registers > - > -Properties: > - - compatible : should contain two values. First value must be one from following list: > - - "samsung,exynos3250-pmu" - for Exynos3250 SoC, > - - "samsung,exynos4210-pmu" - for Exynos4210 SoC, > - - "samsung,exynos4412-pmu" - for Exynos4412 SoC, > - - "samsung,exynos5250-pmu" - for Exynos5250 SoC, > - - "samsung,exynos5260-pmu" - for Exynos5260 SoC. > - - "samsung,exynos5410-pmu" - for Exynos5410 SoC, > - - "samsung,exynos5420-pmu" - for Exynos5420 SoC. > - - "samsung,exynos5433-pmu" - for Exynos5433 SoC. > - - "samsung,exynos7-pmu" - for Exynos7 SoC. > - second value must be always "syscon". > - > - - reg : offset and length of the register set. > - > - - #clock-cells : must be <1>, since PMU requires once cell as clock specifier. > - The single specifier cell is used as index to list of clocks > - provided by PMU, which is currently: > - 0 : SoC clock output (CLKOUT pin) > - > - - clock-names : list of clock names for particular CLKOUT mux inputs in > - following format: > - "clkoutN", where N is a decimal number corresponding to > - CLKOUT mux control bits value for given input, e.g. > - "clkout0", "clkout7", "clkout15". > - > - - clocks : list of phandles and specifiers to all input clocks listed in > - clock-names property. > - > -Optional properties: > - > -Some PMUs are capable of behaving as an interrupt controller (mostly > -to wake up a suspended PMU). In which case, they can have the > -following properties: > - > -- interrupt-controller: indicate that said PMU is an interrupt controller > - > -- #interrupt-cells: must be identical to the that of the parent interrupt > - controller. > - > - > -Optional nodes: > - > -- nodes defining the restart and poweroff syscon children > - > - > -Example : > -pmu_system_controller: system-controller@10040000 { > - compatible = "samsung,exynos5250-pmu", "syscon"; > - reg = <0x10040000 0x5000>; > - interrupt-controller; > - #interrupt-cells = <3>; > - interrupt-parent = <&gic>; > - #clock-cells = <1>; > - clock-names = "clkout0", "clkout1", "clkout2", "clkout3", > - "clkout4", "clkout8", "clkout9"; > - clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>, > - <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>, > - <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, > - <&clock CLK_XUSBXTI>; > -}; > - > -Example of clock consumer : > - > -usb3503: usb3503@8 { > - /* ... */ > - clock-names = "refclk"; > - clocks = <&pmu_system_controller 0>; > - /* ... */ > -}; > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > new file mode 100644 > index 000000000000..a5a02f8237fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC series Power Management Unit (PMU) > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + > +properties: > + compatible: > + items: > + - enum: > + - samsung,exynos3250-pmu > + - samsung,exynos4210-pmu > + - samsung,exynos4412-pmu > + - samsung,exynos5250-pmu > + - samsung,exynos5260-pmu > + - samsung,exynos5410-pmu > + - samsung,exynos5420-pmu > + - samsung,exynos5433-pmu > + - samsung,exynos7-pmu > + - const: syscon > + > + reg: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + > + clock-names: > + description: > + List of clock names for particular CLKOUT mux inputs > + minItems: 1 > + maxItems: 32 > + items: > + enum: > + - clkout0 > + - clkout1 Looking at this again, instead of enum, we can just do: pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > + - clkout2 > + - clkout3 > + - clkout4 > + - clkout5 > + - clkout6 > + - clkout7 > + - clkout8 > + - clkout9 > + - clkout10 > + - clkout11 > + - clkout12 > + - clkout13 > + - clkout14 > + - clkout15 > + - clkout16 > + - clkout17 > + - clkout18 > + - clkout19 > + - clkout20 > + - clkout21 > + - clkout22 > + - clkout23 > + - clkout24 > + - clkout25 > + - clkout26 > + - clkout27 > + - clkout28 > + - clkout29 > + - clkout30 > + - clkout31 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-18 12:43 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-07 9:19 [PATCH v2 01/11] dt-bindings: power: syscon-reboot: Convert bindings to json-schema Krzysztof Kozlowski 2019-09-07 9:19 ` Krzysztof Kozlowski 2019-09-07 9:19 ` [PATCH v2 02/11] dt-bindings: power: syscon-poweroff: " Krzysztof Kozlowski 2019-09-07 9:19 ` Krzysztof Kozlowski 2019-09-18 12:56 ` Rob Herring 2019-09-18 12:56 ` Rob Herring 2019-09-07 9:19 ` [PATCH v2 03/11] dt-bindings: arm: samsung: Convert Samsung board/soc " Krzysztof Kozlowski 2019-09-07 9:19 ` Krzysztof Kozlowski 2019-09-18 12:56 ` Rob Herring 2019-09-18 12:56 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 04/11] dt-bindings: arm: samsung: Document missing S5Pv210 boards bindings Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:56 ` Rob Herring 2019-09-18 12:56 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 05/11] dt-bindings: arm: samsung: Document missing Exynos7 " Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:56 ` Rob Herring 2019-09-18 12:56 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 06/11] dt-bindings: arm: samsung: Convert Exynos Chipid bindings to json-schema Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:57 ` Rob Herring 2019-09-18 12:57 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 07/11] dt-bindings: arm: samsung: Convert Exynos PMU " Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:43 ` Rob Herring [this message] 2019-09-18 12:43 ` Rob Herring 2019-09-18 13:17 ` Krzysztof Kozlowski 2019-09-18 13:17 ` Krzysztof Kozlowski 2019-09-07 9:20 ` [PATCH v2 08/11] dt-bindings: arm: samsung: Convert Exynos System Registers " Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:36 ` Rob Herring 2019-09-18 12:36 ` Rob Herring 2019-09-18 13:07 ` Krzysztof Kozlowski 2019-09-18 13:07 ` Krzysztof Kozlowski 2019-09-07 9:20 ` [PATCH v2 09/11] dt-bindings: rtc: s3c: Convert S3C/Exynos RTC " Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-18 12:57 ` Rob Herring 2019-09-18 12:57 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 10/11] dt-bindings: iio: adc: exynos: Convert Exynos ADC " Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-08 12:29 ` Jonathan Cameron 2019-09-08 12:29 ` Jonathan Cameron 2019-09-18 12:58 ` Rob Herring 2019-09-18 12:58 ` Rob Herring 2019-09-07 9:20 ` [PATCH v2 11/11] dt-bindings: iio: adc: exynos: Remove old requirement of two register address ranges Krzysztof Kozlowski 2019-09-07 9:20 ` Krzysztof Kozlowski 2019-09-08 12:31 ` Jonathan Cameron 2019-09-08 12:31 ` Jonathan Cameron 2019-09-18 12:58 ` Rob Herring 2019-09-18 12:58 ` Rob Herring 2019-09-18 12:55 ` [PATCH v2 01/11] dt-bindings: power: syscon-reboot: Convert bindings to json-schema Rob Herring 2019-09-18 12:55 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190918124306.GB318@bogus \ --to=robh@kernel.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=jic23@kernel.org \ --cc=kgene@kernel.org \ --cc=knaack.h@gmx.de \ --cc=krzk@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.mikolaj.chmiel@gmail.com \ --cc=pmeerw@pmeerw.net \ --cc=sre@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.