All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Cc: <devicetree@vger.kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional
Date: Fri, 11 Oct 2019 16:43:45 +0200	[thread overview]
Message-ID: <20191011144347.19146-7-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20191011144347.19146-1-miquel.raynal@bootlin.com>

The chips have a 'start conversion' and a 'end of conversion' pair of
pins. They can be used but this is absolutely not mandatory as regular
polling is supported by the chip depending on its internal clocking
setup.

There is no physical reason to force the use of interrupts so turn
them optional.

Also, once the interrupt turned optional, these devices fit perfectly
the "trivial devices" described in the generic (yaml) bindings file, so
instead of converting this text file to json schema, we can just add
the relevant compatibles in:
Documentation/devicetree/bindings/trivial-devices.yaml.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
index e680c61dfb84..7b23d68f655c 100644
--- a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
@@ -3,6 +3,8 @@
 Required properties:
   - compatible: Should be "maxim,max1027" or "maxim,max1029" or "maxim,max1031"
   - reg: SPI chip select number for the device
+
+Optional properties:
   - interrupts: IRQ line for the ADC
   see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional
Date: Fri, 11 Oct 2019 16:43:45 +0200	[thread overview]
Message-ID: <20191011144347.19146-7-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20191011144347.19146-1-miquel.raynal@bootlin.com>

The chips have a 'start conversion' and a 'end of conversion' pair of
pins. They can be used but this is absolutely not mandatory as regular
polling is supported by the chip depending on its internal clocking
setup.

There is no physical reason to force the use of interrupts so turn
them optional.

Also, once the interrupt turned optional, these devices fit perfectly
the "trivial devices" described in the generic (yaml) bindings file, so
instead of converting this text file to json schema, we can just add
the relevant compatibles in:
Documentation/devicetree/bindings/trivial-devices.yaml.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
index e680c61dfb84..7b23d68f655c 100644
--- a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
@@ -3,6 +3,8 @@
 Required properties:
   - compatible: Should be "maxim,max1027" or "maxim,max1029" or "maxim,max1031"
   - reg: SPI chip select number for the device
+
+Optional properties:
   - interrupts: IRQ line for the ADC
   see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
 
-- 
2.20.1

  parent reply	other threads:[~2019-10-11 14:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 14:43 [PATCH v4 0/8] Introduce max12xx ADC support Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-11 14:43 ` [PATCH v4 1/8] iio: adc: max1027: Add debugfs register read support Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:25   ` Jonathan Cameron
2019-10-12 11:25     ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 2/8] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:34   ` Jonathan Cameron
2019-10-12 11:34     ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:28   ` Jonathan Cameron
2019-10-12 11:28     ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 4/8] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:29   ` Jonathan Cameron
2019-10-12 11:29     ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 5/8] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:30   ` Jonathan Cameron
2019-10-12 11:30     ` Jonathan Cameron
2019-10-11 14:43 ` Miquel Raynal [this message]
2019-10-11 14:43   ` [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal
2019-10-12 11:31   ` Jonathan Cameron
2019-10-12 11:31     ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 7/8] dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-14 15:38   ` Rob Herring
2019-10-14 15:38     ` Rob Herring
2019-10-11 14:43 ` [PATCH v4 8/8] dt-bindings: Add max12xx SPI ADC series " Miquel Raynal
2019-10-11 14:43   ` Miquel Raynal
2019-10-12 11:32   ` Jonathan Cameron
2019-10-12 11:32     ` Jonathan Cameron
2019-10-14 15:38   ` Rob Herring
2019-10-14 15:38     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011144347.19146-7-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.