From: Andrew Murray <andrew.murray@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Jingoo Han <jingoohan1@gmail.com>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
Ley Foon Tan <lftan@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Ray Jui <rjui@broadcom.com>,
rfi@lists.rocketboards.org, Ryder Lee <ryder.lee@mediatek.com>,
Scott Branden <sbranden@broadcom.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Simon Horman <horms@verge.net.au>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Toan Le <toan@os.amperecomputing.com>,
Tom Joseph <tjoseph@cadence.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 01/25] resource: Add a resource_list_get_entry_of_type helper
Date: Fri, 18 Oct 2019 13:14:24 +0100 [thread overview]
Message-ID: <20191018121424.GF47056@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191017072519.GA19517@infradead.org>
On Thu, Oct 17, 2019 at 12:25:19AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 16, 2019 at 03:06:23PM -0500, Rob Herring wrote:
> > +static inline struct resource_entry *resource_list_get_entry_of_type(struct list_head *list,
> > + unsigned long type)
>
> This adds a way too long line.
>
> Part of that is that the name just seems way too long as well, any
> good shorter name? resourse_list_first_type?
I think it's really helpful to use the word 'first' in there somewhere,
it makes it a little clearer on what happens if there are multiple of
the same type of resource.
Thanks,
Andrew Murray
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Shawn Lin <shawn.lin@rock-chips.com>, Ray Jui <rjui@broadcom.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Jingoo Han <jingoohan1@gmail.com>,
rfi@lists.rocketboards.org, linux-renesas-soc@vge
Subject: Re: [PATCH v2 01/25] resource: Add a resource_list_get_entry_of_type helper
Date: Fri, 18 Oct 2019 13:14:24 +0100 [thread overview]
Message-ID: <20191018121424.GF47056@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191017072519.GA19517@infradead.org>
On Thu, Oct 17, 2019 at 12:25:19AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 16, 2019 at 03:06:23PM -0500, Rob Herring wrote:
> > +static inline struct resource_entry *resource_list_get_entry_of_type(struct list_head *list,
> > + unsigned long type)
>
> This adds a way too long line.
>
> Part of that is that the name just seems way too long as well, any
> good shorter name? resourse_list_first_type?
I think it's really helpful to use the word 'first' in there somewhere,
it makes it a little clearer on what happens if there are multiple of
the same type of resource.
Thanks,
Andrew Murray
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Shawn Lin <shawn.lin@rock-chips.com>, Ray Jui <rjui@broadcom.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Jingoo Han <jingoohan1@gmail.com>,
rfi@lists.rocketboards.org, linux-renesas-soc@vger.kernel.org,
Tom Joseph <tjoseph@cadence.com>,
Simon Horman <horms@verge.net.au>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Ley Foon Tan <lftan@altera.com>
Subject: Re: [PATCH v2 01/25] resource: Add a resource_list_get_entry_of_type helper
Date: Fri, 18 Oct 2019 13:14:24 +0100 [thread overview]
Message-ID: <20191018121424.GF47056@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191017072519.GA19517@infradead.org>
On Thu, Oct 17, 2019 at 12:25:19AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 16, 2019 at 03:06:23PM -0500, Rob Herring wrote:
> > +static inline struct resource_entry *resource_list_get_entry_of_type(struct list_head *list,
> > + unsigned long type)
>
> This adds a way too long line.
>
> Part of that is that the name just seems way too long as well, any
> good shorter name? resourse_list_first_type?
I think it's really helpful to use the word 'first' in there somewhere,
it makes it a little clearer on what happens if there are multiple of
the same type of resource.
Thanks,
Andrew Murray
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Shawn Lin <shawn.lin@rock-chips.com>, Ray Jui <rjui@broadcom.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Jingoo Han <jingoohan1@gmail.com>,
rfi@lists.rocketboards.org, linux-renesas-soc@vger.kernel.org,
Tom Joseph <tjoseph@cadence.com>,
Simon Horman <horms@verge.net.au>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Ley Foon Tan <lftan@altera.com>
Subject: Re: [PATCH v2 01/25] resource: Add a resource_list_get_entry_of_type helper
Date: Fri, 18 Oct 2019 13:14:24 +0100 [thread overview]
Message-ID: <20191018121424.GF47056@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191017072519.GA19517@infradead.org>
On Thu, Oct 17, 2019 at 12:25:19AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 16, 2019 at 03:06:23PM -0500, Rob Herring wrote:
> > +static inline struct resource_entry *resource_list_get_entry_of_type(struct list_head *list,
> > + unsigned long type)
>
> This adds a way too long line.
>
> Part of that is that the name just seems way too long as well, any
> good shorter name? resourse_list_first_type?
I think it's really helpful to use the word 'first' in there somewhere,
it makes it a little clearer on what happens if there are multiple of
the same type of resource.
Thanks,
Andrew Murray
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-18 12:14 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 20:06 [PATCH v2 00/25] PCI host resource consolidation Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 01/25] resource: Add a resource_list_get_entry_of_type helper Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-17 7:25 ` Christoph Hellwig
2019-10-17 7:25 ` Christoph Hellwig
2019-10-17 7:25 ` Christoph Hellwig
2019-10-18 12:14 ` Andrew Murray [this message]
2019-10-18 12:14 ` Andrew Murray
2019-10-18 12:14 ` Andrew Murray
2019-10-18 12:14 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 02/25] PCI: Export pci_parse_request_of_pci_ranges() Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 12:06 ` Andrew Murray
2019-10-18 12:06 ` Andrew Murray
2019-10-18 12:06 ` Andrew Murray
2019-10-18 12:06 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 03/25] PCI: aardvark: Use pci_parse_request_of_pci_ranges() Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 04/25] PCI: altera: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 12:09 ` Andrew Murray
2019-10-18 12:09 ` Andrew Murray
2019-10-18 12:09 ` Andrew Murray
2019-10-18 12:09 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 05/25] PCI: dwc: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 12:35 ` Andrew Murray
2019-10-18 12:35 ` Andrew Murray
2019-10-18 12:35 ` Andrew Murray
2019-10-18 12:35 ` Andrew Murray
2019-10-20 21:39 ` Rob Herring
2019-10-20 21:39 ` Rob Herring
2019-10-20 21:39 ` Rob Herring
2019-10-20 21:39 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 06/25] PCI: faraday: Use pci_parse_request_of_pci_ranges Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 12:57 ` Andrew Murray
2019-10-18 12:57 ` Andrew Murray
2019-10-18 12:57 ` Andrew Murray
2019-10-18 12:57 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 07/25] PCI: iproc: Use pci_parse_request_of_pci_ranges() Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 13:00 ` Andrew Murray
2019-10-18 13:00 ` Andrew Murray
2019-10-18 13:00 ` Andrew Murray
2019-10-18 13:00 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 08/25] PCI: mediatek: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 09/25] PCI: mobiveil: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 15:41 ` Andrew Murray
2019-10-18 15:41 ` Andrew Murray
2019-10-18 15:41 ` Andrew Murray
2019-10-18 15:41 ` Andrew Murray
2019-10-16 20:06 ` [PATCH v2 10/25] PCI: rockchip: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-18 15:51 ` Andrew Murray
2019-10-18 15:51 ` Andrew Murray
2019-10-18 15:51 ` Andrew Murray
2019-10-18 15:51 ` Andrew Murray
2019-10-20 21:36 ` Rob Herring
2019-10-20 21:36 ` Rob Herring
2019-10-20 21:36 ` Rob Herring
2019-10-20 21:36 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 11/25] PCI: rockchip: Drop storing driver private outbound resource data Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-17 7:26 ` Christoph Hellwig
2019-10-17 7:26 ` Christoph Hellwig
2019-10-17 7:26 ` Christoph Hellwig
2019-10-17 12:24 ` Rob Herring
2019-10-17 12:24 ` Rob Herring
2019-10-17 12:24 ` Rob Herring
2019-10-17 12:24 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 12/25] PCI: v3-semi: Use pci_parse_request_of_pci_ranges() Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-21 0:38 ` Linus Walleij
2019-10-21 0:38 ` Linus Walleij
2019-10-21 0:38 ` Linus Walleij
2019-10-21 0:38 ` Linus Walleij
2019-10-16 20:06 ` [PATCH v2 13/25] PCI: xgene: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 14/25] PCI: xilinx: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 15/25] PCI: xilinx-nwl: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 16/25] PCI: versatile: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-21 0:39 ` Linus Walleij
2019-10-21 0:39 ` Linus Walleij
2019-10-21 0:39 ` Linus Walleij
2019-10-21 0:39 ` Linus Walleij
2019-10-16 20:06 ` [PATCH v2 17/25] PCI: versatile: Remove usage of PHYS_OFFSET Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-21 0:40 ` Linus Walleij
2019-10-21 0:40 ` Linus Walleij
2019-10-21 0:40 ` Linus Walleij
2019-10-21 0:40 ` Linus Walleij
2019-10-16 20:06 ` [PATCH v2 18/25] PCI: versatile: Enable COMPILE_TEST Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-16 20:06 ` [PATCH v2 19/25] PCI: of: Add inbound resource parsing to helpers Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 20/25] PCI: ftpci100: Use inbound resources for setup Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-21 0:41 ` Linus Walleij
2019-10-16 20:06 ` [PATCH v2 21/25] PCI: v3-semi: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 22/25] PCI: xgene: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 23/25] PCI: iproc: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 24/25] PCI: rcar: " Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` [PATCH v2 25/25] PCI: Make devm_of_pci_get_host_bridge_resources() static Rob Herring
2019-10-16 20:06 ` Rob Herring
2019-10-16 20:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018121424.GF47056@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hch@infradead.org \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=jingoohan1@gmail.com \
--cc=lftan@altera.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.karthikeyan@mobiveil.co.in \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=rfi@lists.rocketboards.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=srinath.mannam@broadcom.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=toan@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.