From: Christoph Hellwig <hch@infradead.org> To: Paul Walmsley <paul.walmsley@sifive.com> Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S Date: Fri, 18 Oct 2019 08:49:23 -0700 [thread overview] Message-ID: <20191018154923.GA23279@infradead.org> (raw) In-Reply-To: <20191018080841.26712-2-paul.walmsley@sifive.com> On Fri, Oct 18, 2019 at 01:08:34AM -0700, Paul Walmsley wrote: > Add prototypes for assembly language functions defined in entry.S, > and include these prototypes into C source files that call those > functions. > > This patch resolves the following warnings from sparse: > > arch/riscv/kernel/signal.c:32:53: warning: incorrect type in initializer (different address spaces) I don't see how adding prototypes will fix an address space warning. > +asmlinkage void do_trap_unknown(struct pt_regs *regs); > +asmlinkage void do_trap_insn_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_insn_fault(struct pt_regs *regs); > +asmlinkage void do_trap_insn_illegal(struct pt_regs *regs); > +asmlinkage void do_trap_load_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_load_fault(struct pt_regs *regs); > +asmlinkage void do_trap_store_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_store_fault(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_u(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_s(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_m(struct pt_regs *regs); > +asmlinkage void do_trap_break(struct pt_regs *regs); All these are not defined in entry.S, but called from entry.S. And as Luc pointed out last time the easiest way to fix the sparse warnings is to add __visible to the definitions of those functions.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org> To: Paul Walmsley <paul.walmsley@sifive.com> Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S Date: Fri, 18 Oct 2019 08:49:23 -0700 [thread overview] Message-ID: <20191018154923.GA23279@infradead.org> (raw) In-Reply-To: <20191018080841.26712-2-paul.walmsley@sifive.com> On Fri, Oct 18, 2019 at 01:08:34AM -0700, Paul Walmsley wrote: > Add prototypes for assembly language functions defined in entry.S, > and include these prototypes into C source files that call those > functions. > > This patch resolves the following warnings from sparse: > > arch/riscv/kernel/signal.c:32:53: warning: incorrect type in initializer (different address spaces) I don't see how adding prototypes will fix an address space warning. > +asmlinkage void do_trap_unknown(struct pt_regs *regs); > +asmlinkage void do_trap_insn_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_insn_fault(struct pt_regs *regs); > +asmlinkage void do_trap_insn_illegal(struct pt_regs *regs); > +asmlinkage void do_trap_load_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_load_fault(struct pt_regs *regs); > +asmlinkage void do_trap_store_misaligned(struct pt_regs *regs); > +asmlinkage void do_trap_store_fault(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_u(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_s(struct pt_regs *regs); > +asmlinkage void do_trap_ecall_m(struct pt_regs *regs); > +asmlinkage void do_trap_break(struct pt_regs *regs); All these are not defined in entry.S, but called from entry.S. And as Luc pointed out last time the easiest way to fix the sparse warnings is to add __visible to the definitions of those functions. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-18 15:49 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-18 8:08 [PATCH v3 0/8] riscv: resolve most warnings from sparse Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 8:08 ` [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:49 ` Christoph Hellwig [this message] 2019-10-18 15:49 ` Christoph Hellwig 2019-10-24 23:59 ` Paul Walmsley 2019-10-24 23:59 ` Paul Walmsley 2019-10-18 8:08 ` [PATCH v3 2/8] riscv: add prototypes for assembly language functions from head.S Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 8:08 ` [PATCH v3 3/8] riscv: init: merge split string literals in preprocessor directive Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:50 ` Christoph Hellwig 2019-10-18 15:50 ` Christoph Hellwig 2019-10-18 8:08 ` [PATCH v3 4/8] riscv: add missing prototypes Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:54 ` Christoph Hellwig 2019-10-18 15:54 ` Christoph Hellwig 2019-10-18 8:08 ` [PATCH v3 5/8] riscv: mark some code and data as file-static Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:55 ` Christoph Hellwig 2019-10-18 15:55 ` Christoph Hellwig 2019-10-23 5:46 ` Greentime Hu 2019-10-23 5:46 ` Greentime Hu 2019-10-23 22:32 ` Paul Walmsley 2019-10-23 22:32 ` Paul Walmsley 2019-10-18 8:08 ` [PATCH v3 6/8] riscv: add missing header file includes Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:55 ` Christoph Hellwig 2019-10-18 15:55 ` Christoph Hellwig 2019-10-18 8:08 ` [PATCH v3 7/8] riscv: fp: add missing __user pointer annotations Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:56 ` Christoph Hellwig 2019-10-18 15:56 ` Christoph Hellwig 2019-10-18 8:08 ` [PATCH v3 8/8] riscv: for C functions called only from assembly, mark with __visible Paul Walmsley 2019-10-18 8:08 ` Paul Walmsley 2019-10-18 15:56 ` Christoph Hellwig 2019-10-18 15:56 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191018154923.GA23279@infradead.org \ --to=hch@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.