From: Paul Walmsley <paul.walmsley@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S
Date: Thu, 24 Oct 2019 16:59:01 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910231812080.6074@viisi.sifive.com> (raw)
In-Reply-To: <20191018154923.GA23279@infradead.org>
On Fri, 18 Oct 2019, Christoph Hellwig wrote:
> On Fri, Oct 18, 2019 at 01:08:34AM -0700, Paul Walmsley wrote:
> > Add prototypes for assembly language functions defined in entry.S,
> > and include these prototypes into C source files that call those
> > functions.
> >
> > This patch resolves the following warnings from sparse:
> >
> > arch/riscv/kernel/signal.c:32:53: warning: incorrect type in initializer (different address spaces)
>
> I don't see how adding prototypes will fix an address space warning.
You're right - that was a cut-and-paste error on my part.
[ ... ]
> All these are not defined in entry.S, but called from entry.S.
Indeed. After reviewing this patch closely, I've just dropped it, and
used __visible for just about everything. All that is reflected in the v4
series.
Thanks for the review.
- Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S
Date: Thu, 24 Oct 2019 16:59:01 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910231812080.6074@viisi.sifive.com> (raw)
In-Reply-To: <20191018154923.GA23279@infradead.org>
On Fri, 18 Oct 2019, Christoph Hellwig wrote:
> On Fri, Oct 18, 2019 at 01:08:34AM -0700, Paul Walmsley wrote:
> > Add prototypes for assembly language functions defined in entry.S,
> > and include these prototypes into C source files that call those
> > functions.
> >
> > This patch resolves the following warnings from sparse:
> >
> > arch/riscv/kernel/signal.c:32:53: warning: incorrect type in initializer (different address spaces)
>
> I don't see how adding prototypes will fix an address space warning.
You're right - that was a cut-and-paste error on my part.
[ ... ]
> All these are not defined in entry.S, but called from entry.S.
Indeed. After reviewing this patch closely, I've just dropped it, and
used __visible for just about everything. All that is reflected in the v4
series.
Thanks for the review.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-24 23:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:08 [PATCH v3 0/8] riscv: resolve most warnings from sparse Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:49 ` Christoph Hellwig
2019-10-18 15:49 ` Christoph Hellwig
2019-10-24 23:59 ` Paul Walmsley [this message]
2019-10-24 23:59 ` Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 2/8] riscv: add prototypes for assembly language functions from head.S Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 3/8] riscv: init: merge split string literals in preprocessor directive Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:50 ` Christoph Hellwig
2019-10-18 15:50 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 4/8] riscv: add missing prototypes Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:54 ` Christoph Hellwig
2019-10-18 15:54 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 5/8] riscv: mark some code and data as file-static Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:55 ` Christoph Hellwig
2019-10-18 15:55 ` Christoph Hellwig
2019-10-23 5:46 ` Greentime Hu
2019-10-23 5:46 ` Greentime Hu
2019-10-23 22:32 ` Paul Walmsley
2019-10-23 22:32 ` Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 6/8] riscv: add missing header file includes Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:55 ` Christoph Hellwig
2019-10-18 15:55 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 7/8] riscv: fp: add missing __user pointer annotations Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:56 ` Christoph Hellwig
2019-10-18 15:56 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 8/8] riscv: for C functions called only from assembly, mark with __visible Paul Walmsley
2019-10-18 8:08 ` Paul Walmsley
2019-10-18 15:56 ` Christoph Hellwig
2019-10-18 15:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910231812080.6074@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.