From: Patchwork <patchwork@emeril.freedesktop.org> To: Jason Wang <jasowang@redhat.com> Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev6) Date: Wed, 23 Oct 2019 23:42:37 -0000 [thread overview] Message-ID: <20191023234237.3027.71271@emeril.freedesktop.org> (raw) In-Reply-To: <20191023130752.18980-1-jasowang@redhat.com> == Series Details == Series: mdev based hardware virtio offloading support (rev6) URL : https://patchwork.freedesktop.org/series/66989/ State : warning == Summary == $ dim checkpatch origin/drm-tip dbcc3602f990 mdev: class id support cdfeed47be7f modpost: add support for mdev class id d18fa8d08a1d mdev: introduce device specific ops -:258: CHECK:LINE_SPACING: Please don't use multiple blank lines #258: FILE: drivers/vfio/mdev/mdev_core.c:48: + -:263: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #263: FILE: drivers/vfio/mdev/mdev_core.c:51: + * provided by each class. */ -:500: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #500: new file mode 100644 total: 0 errors, 2 warnings, 1 checks, 620 lines checked 091ee68346c6 mdev: introduce virtio device and its device ops -:94: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 223 lines checked 76b1265016b1 virtio: introduce a mdev based transport -:26: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #26: FILE: drivers/virtio/Kconfig:46: +config VIRTIO_MDEV_DEVICE -:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/virtio/virtio_mdev.c:56: +static void virtio_mdev_get(struct virtio_device *vdev, unsigned offset, -:107: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #107: FILE: drivers/virtio/virtio_mdev.c:57: + void *buf, unsigned len) -:115: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #115: FILE: drivers/virtio/virtio_mdev.c:65: +static void virtio_mdev_set(struct virtio_device *vdev, unsigned offset, -:116: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #116: FILE: drivers/virtio/virtio_mdev.c:66: + const void *buf, unsigned len) -:186: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #186: FILE: drivers/virtio/virtio_mdev.c:136: +virtio_mdev_setup_vq(struct virtio_device *vdev, unsigned index, -:265: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #265: FILE: drivers/virtio/virtio_mdev.c:215: + +} -:297: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #297: FILE: drivers/virtio/virtio_mdev.c:247: +static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs, total: 0 errors, 8 warnings, 1 checks, 430 lines checked e114c74e4182 docs: sample driver to demonstrate how to implement virtio-mdev framework -:39: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #39: FILE: samples/Kconfig:134: +config SAMPLE_VIRTIO_MDEV_NET -:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 -:147: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #147: FILE: samples/vfio-mdev/mvnet.c:84: + spinlock_t lock; -:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #180: FILE: samples/vfio-mdev/mvnet.c:117: + vringh_init_kern(&vq->vring, mvnet_features, MVNET_QUEUE_MAX, + false, 0, 0, 0); -:285: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!addr" #285: FILE: samples/vfio-mdev/mvnet.c:222: + if (addr == NULL) -:288: CHECK:SPACING: No space is necessary after a cast #288: FILE: samples/vfio-mdev/mvnet.c:225: + *dma_addr = (dma_addr_t) addr; -:318: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*mvnet)...) over kzalloc(sizeof(struct mvnet_state)...) #318: FILE: samples/vfio-mdev/mvnet.c:255: + mvnet = kzalloc(sizeof(struct mvnet_state), GFP_KERNEL); -:319: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!mvnet" #319: FILE: samples/vfio-mdev/mvnet.c:256: + if (mvnet == NULL) -:375: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #375: FILE: samples/vfio-mdev/mvnet.c:312: +sample_mvnet_dev_show(struct device *dev, struct device_attribute *attr, + char *buf) total: 0 errors, 2 warnings, 7 checks, 715 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org> To: "Jason Wang" <jasowang@redhat.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev6) Date: Wed, 23 Oct 2019 23:42:37 -0000 [thread overview] Message-ID: <20191023234237.3027.71271@emeril.freedesktop.org> (raw) Message-ID: <20191023234237.l9_wtTCV6bPBtBLlXHTDg3tKHCNme2P-pKWmty164HA@z> (raw) In-Reply-To: <20191023130752.18980-1-jasowang@redhat.com> == Series Details == Series: mdev based hardware virtio offloading support (rev6) URL : https://patchwork.freedesktop.org/series/66989/ State : warning == Summary == $ dim checkpatch origin/drm-tip dbcc3602f990 mdev: class id support cdfeed47be7f modpost: add support for mdev class id d18fa8d08a1d mdev: introduce device specific ops -:258: CHECK:LINE_SPACING: Please don't use multiple blank lines #258: FILE: drivers/vfio/mdev/mdev_core.c:48: + -:263: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #263: FILE: drivers/vfio/mdev/mdev_core.c:51: + * provided by each class. */ -:500: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #500: new file mode 100644 total: 0 errors, 2 warnings, 1 checks, 620 lines checked 091ee68346c6 mdev: introduce virtio device and its device ops -:94: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 223 lines checked 76b1265016b1 virtio: introduce a mdev based transport -:26: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #26: FILE: drivers/virtio/Kconfig:46: +config VIRTIO_MDEV_DEVICE -:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/virtio/virtio_mdev.c:56: +static void virtio_mdev_get(struct virtio_device *vdev, unsigned offset, -:107: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #107: FILE: drivers/virtio/virtio_mdev.c:57: + void *buf, unsigned len) -:115: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #115: FILE: drivers/virtio/virtio_mdev.c:65: +static void virtio_mdev_set(struct virtio_device *vdev, unsigned offset, -:116: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #116: FILE: drivers/virtio/virtio_mdev.c:66: + const void *buf, unsigned len) -:186: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #186: FILE: drivers/virtio/virtio_mdev.c:136: +virtio_mdev_setup_vq(struct virtio_device *vdev, unsigned index, -:265: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #265: FILE: drivers/virtio/virtio_mdev.c:215: + +} -:297: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #297: FILE: drivers/virtio/virtio_mdev.c:247: +static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs, total: 0 errors, 8 warnings, 1 checks, 430 lines checked e114c74e4182 docs: sample driver to demonstrate how to implement virtio-mdev framework -:39: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #39: FILE: samples/Kconfig:134: +config SAMPLE_VIRTIO_MDEV_NET -:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 -:147: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #147: FILE: samples/vfio-mdev/mvnet.c:84: + spinlock_t lock; -:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #180: FILE: samples/vfio-mdev/mvnet.c:117: + vringh_init_kern(&vq->vring, mvnet_features, MVNET_QUEUE_MAX, + false, 0, 0, 0); -:285: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!addr" #285: FILE: samples/vfio-mdev/mvnet.c:222: + if (addr == NULL) -:288: CHECK:SPACING: No space is necessary after a cast #288: FILE: samples/vfio-mdev/mvnet.c:225: + *dma_addr = (dma_addr_t) addr; -:318: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*mvnet)...) over kzalloc(sizeof(struct mvnet_state)...) #318: FILE: samples/vfio-mdev/mvnet.c:255: + mvnet = kzalloc(sizeof(struct mvnet_state), GFP_KERNEL); -:319: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!mvnet" #319: FILE: samples/vfio-mdev/mvnet.c:256: + if (mvnet == NULL) -:375: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #375: FILE: samples/vfio-mdev/mvnet.c:312: +sample_mvnet_dev_show(struct device *dev, struct device_attribute *attr, + char *buf) total: 0 errors, 2 warnings, 7 checks, 715 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-23 23:42 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-23 13:07 [PATCH V5 0/6] mdev based hardware virtio offloading support Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [PATCH V5 1/6] mdev: class id support Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 16:30 ` Parav Pandit 2019-10-23 16:30 ` [Intel-gfx] " Parav Pandit 2019-10-23 16:30 ` Parav Pandit 2019-10-23 16:30 ` Parav Pandit 2019-10-23 16:30 ` Parav Pandit 2019-10-23 21:42 ` Alex Williamson 2019-10-23 21:42 ` [Intel-gfx] " Alex Williamson 2019-10-23 21:42 ` Alex Williamson 2019-10-23 21:42 ` Alex Williamson 2019-10-24 3:27 ` Jason Wang 2019-10-24 3:27 ` [Intel-gfx] " Jason Wang 2019-10-24 3:27 ` Jason Wang 2019-10-24 3:27 ` Jason Wang 2019-10-24 19:46 ` Alex Williamson 2019-10-24 19:46 ` Alex Williamson 2019-10-24 19:46 ` [Intel-gfx] " Alex Williamson 2019-10-24 19:46 ` Alex Williamson 2019-10-24 19:46 ` Alex Williamson 2019-10-24 20:13 ` Alex Williamson 2019-10-24 20:13 ` [Intel-gfx] " Alex Williamson 2019-10-24 20:13 ` Alex Williamson 2019-10-24 20:13 ` Alex Williamson 2019-10-25 1:42 ` Jason Wang 2019-10-25 1:42 ` Jason Wang 2019-10-25 1:42 ` [Intel-gfx] " Jason Wang 2019-10-25 1:42 ` Jason Wang 2019-10-25 1:42 ` Jason Wang 2019-10-24 3:27 ` Jason Wang 2019-10-23 21:42 ` Alex Williamson 2019-10-23 13:07 ` [PATCH V5 2/6] modpost: add support for mdev class id Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 21:42 ` Alex Williamson 2019-10-23 21:42 ` [Intel-gfx] " Alex Williamson 2019-10-23 21:42 ` Alex Williamson 2019-10-23 21:42 ` Alex Williamson 2019-10-24 3:31 ` Jason Wang 2019-10-24 3:31 ` Jason Wang 2019-10-24 3:31 ` [Intel-gfx] " Jason Wang 2019-10-24 3:31 ` Jason Wang 2019-10-24 3:31 ` Jason Wang 2019-10-24 19:54 ` Alex Williamson 2019-10-24 19:54 ` Alex Williamson 2019-10-24 19:54 ` [Intel-gfx] " Alex Williamson 2019-10-24 19:54 ` Alex Williamson 2019-10-24 19:54 ` Alex Williamson 2019-10-25 1:44 ` Jason Wang 2019-10-25 1:44 ` [Intel-gfx] " Jason Wang 2019-10-25 1:44 ` Jason Wang 2019-10-25 1:44 ` Jason Wang 2019-10-25 1:44 ` Jason Wang 2019-10-23 21:42 ` Alex Williamson 2019-10-23 13:07 ` [PATCH V5 3/6] mdev: introduce device specific ops Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [PATCH V5 4/6] mdev: introduce virtio device and its device ops Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 21:57 ` Alex Williamson 2019-10-23 21:57 ` [Intel-gfx] " Alex Williamson 2019-10-23 21:57 ` Alex Williamson 2019-10-23 21:57 ` Alex Williamson 2019-10-24 3:51 ` Jason Wang 2019-10-24 3:51 ` [Intel-gfx] " Jason Wang 2019-10-24 3:51 ` Jason Wang 2019-10-24 3:51 ` Jason Wang 2019-10-24 20:44 ` Alex Williamson 2019-10-24 20:44 ` Alex Williamson 2019-10-24 20:44 ` [Intel-gfx] " Alex Williamson 2019-10-24 20:44 ` Alex Williamson 2019-10-24 20:44 ` Alex Williamson 2019-10-25 1:54 ` Jason Wang 2019-10-25 1:54 ` Jason Wang 2019-10-25 1:54 ` [Intel-gfx] " Jason Wang 2019-10-25 1:54 ` Jason Wang 2019-10-25 1:54 ` Jason Wang 2019-10-24 3:51 ` Jason Wang 2019-10-29 7:42 ` Zhu Lingshan 2019-10-29 7:42 ` [Intel-gfx] " Zhu Lingshan 2019-10-29 7:42 ` Zhu Lingshan 2019-10-29 7:42 ` Zhu Lingshan 2019-10-29 10:42 ` Jason Wang 2019-10-29 10:42 ` Jason Wang 2019-10-29 10:42 ` [Intel-gfx] " Jason Wang 2019-10-29 10:42 ` Jason Wang 2019-10-30 7:36 ` Zhu Lingshan 2019-10-30 7:36 ` [Intel-gfx] " Zhu Lingshan 2019-10-30 7:36 ` Zhu Lingshan 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [PATCH V5 5/6] virtio: introduce a mdev based transport Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` [PATCH V5 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang 2019-10-23 13:07 ` [Intel-gfx] " Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 13:07 ` Jason Wang 2019-10-23 23:42 ` Patchwork [this message] 2019-10-23 23:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev6) Patchwork 2019-10-24 0:10 ` ✓ Fi.CI.BAT: success " Patchwork 2019-10-24 0:10 ` [Intel-gfx] " Patchwork 2019-10-24 20:36 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-10-24 20:36 ` [Intel-gfx] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191023234237.3027.71271@emeril.freedesktop.org \ --to=patchwork@emeril.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jasowang@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.