From: Zhu Lingshan <lingshan.zhu@linux.intel.com>
To: Jason Wang <jasowang@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, cohuck@redhat.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, haotian.wang@sifive.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com,
oberpar@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
akrowiak@linux.ibm.com, freude@linux.ibm.com,
lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com,
lulu@redhat.com, parav@mellanox.com,
christophe.de.dinechin@gmail.com, kevin.tian@intel.com,
stefanha@redhat.com
Subject: Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops
Date: Wed, 30 Oct 2019 15:36:24 +0800 [thread overview]
Message-ID: <bc6b2565-b0b6-bf0a-812f-d0bb157be086@linux.intel.com> (raw)
In-Reply-To: <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com>
On 10/29/2019 6:42 PM, Jason Wang wrote:
> On 2019/10/29 下午3:42, Zhu Lingshan wrote:
>>> + void (*set_status)(struct mdev_device *mdev, u8 status);
>> Hi Jason
>>
>> Is it possible to make set_status() return an u8 or bool, because this
>> may fail in real hardware. Without a returned code, I am not sure
>> whether it is a good idea to set the status | NEED_RESET when fail.
>>
>> Thanks,
>> BR
>> Zhu Lingshan
>
> Hi:
>
>
> It's possible but I'm not sure whether any user will care about it. E.g
> see virtio_add_status():
>
> void virtio_add_status(struct virtio_device *dev, unsigned int status)
> {
> might_sleep();
> dev->config->set_status(dev, dev->config->get_status(dev) | status);
> }
> EXPORT_SYMBOL_GPL(virtio_add_status);
>
> And I believe how it work should be:
>
> virtio_add_status(xyz);
>
> status = virtio_get_status();
>
> if (!(status & xyz))
>
> error;
>
> Thanks
>
Thanks Jason, then I believe upper layer can handle this well.
>
WARNING: multiple messages have this Message-ID (diff)
From: Zhu Lingshan <lingshan.zhu@linux.intel.com>
To: Jason Wang <jasowang@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com
Cc: christophe.de.dinechin@gmail.com, sebott@linux.ibm.com,
airlied@linux.ie, heiko.carstens@de.ibm.com,
kevin.tian@intel.com, virtualization@lists.linux-foundation.org,
rob.miller@broadcom.com, lulu@redhat.com, eperezma@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
haotian.wang@sifive.com, zhi.a.wang@intel.com,
farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com,
cunming.liang@intel.com, rodrigo.vivi@intel.com,
xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com,
zhihong.wang@intel.com, stefanha@redhat.com,
akrowiak@linux.ibm.com, netdev@vger.kernel.org,
cohuck@redhat.com, oberpar@linux.ibm.com,
maxime.coquelin@redhat.com, lingshan.zhu@intel.com
Subject: Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops
Date: Wed, 30 Oct 2019 15:36:24 +0800 [thread overview]
Message-ID: <bc6b2565-b0b6-bf0a-812f-d0bb157be086@linux.intel.com> (raw)
Message-ID: <20191030073624.Br4fVQcEl_ZdQ8w-OnhGD576YTOvE3wRK-PvOugun9g@z> (raw)
In-Reply-To: <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com>
On 10/29/2019 6:42 PM, Jason Wang wrote:
> On 2019/10/29 下午3:42, Zhu Lingshan wrote:
>>> + void (*set_status)(struct mdev_device *mdev, u8 status);
>> Hi Jason
>>
>> Is it possible to make set_status() return an u8 or bool, because this
>> may fail in real hardware. Without a returned code, I am not sure
>> whether it is a good idea to set the status | NEED_RESET when fail.
>>
>> Thanks,
>> BR
>> Zhu Lingshan
>
> Hi:
>
>
> It's possible but I'm not sure whether any user will care about it. E.g
> see virtio_add_status():
>
> void virtio_add_status(struct virtio_device *dev, unsigned int status)
> {
> might_sleep();
> dev->config->set_status(dev, dev->config->get_status(dev) | status);
> }
> EXPORT_SYMBOL_GPL(virtio_add_status);
>
> And I believe how it work should be:
>
> virtio_add_status(xyz);
>
> status = virtio_get_status();
>
> if (!(status & xyz))
>
> error;
>
> Thanks
>
Thanks Jason, then I believe upper layer can handle this well.
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Zhu Lingshan <lingshan.zhu@linux.intel.com>
To: Jason Wang <jasowang@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com
Cc: christophe.de.dinechin@gmail.com, sebott@linux.ibm.com,
airlied@linux.ie, heiko.carstens@de.ibm.com,
virtualization@lists.linux-foundation.org,
rob.miller@broadcom.com, lulu@redhat.com, eperezma@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
haotian.wang@sifive.com, farman@linux.ibm.com, idos@mellanox.com,
gor@linux.ibm.com, cunming.liang@intel.com,
xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com,
zhihong.wang@intel.com, stefanha@redhat.com,
akrowiak@linux.ibm.com, netdev@vger.kernel.org,
cohuck@redhat.com, oberpar@linux.ibm.com,
maxime.coquelin@redhat.com, lingshan.zhu@intel.com
Subject: Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops
Date: Wed, 30 Oct 2019 15:36:24 +0800 [thread overview]
Message-ID: <bc6b2565-b0b6-bf0a-812f-d0bb157be086@linux.intel.com> (raw)
Message-ID: <20191030073624.Qkzpuq6RkZo_1d3VdGswJ5ORiYo4Pn96HHbIu25oHjE@z> (raw)
In-Reply-To: <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com>
On 10/29/2019 6:42 PM, Jason Wang wrote:
> On 2019/10/29 下午3:42, Zhu Lingshan wrote:
>>> + void (*set_status)(struct mdev_device *mdev, u8 status);
>> Hi Jason
>>
>> Is it possible to make set_status() return an u8 or bool, because this
>> may fail in real hardware. Without a returned code, I am not sure
>> whether it is a good idea to set the status | NEED_RESET when fail.
>>
>> Thanks,
>> BR
>> Zhu Lingshan
>
> Hi:
>
>
> It's possible but I'm not sure whether any user will care about it. E.g
> see virtio_add_status():
>
> void virtio_add_status(struct virtio_device *dev, unsigned int status)
> {
> might_sleep();
> dev->config->set_status(dev, dev->config->get_status(dev) | status);
> }
> EXPORT_SYMBOL_GPL(virtio_add_status);
>
> And I believe how it work should be:
>
> virtio_add_status(xyz);
>
> status = virtio_get_status();
>
> if (!(status & xyz))
>
> error;
>
> Thanks
>
Thanks Jason, then I believe upper layer can handle this well.
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-30 7:36 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:07 [PATCH V5 0/6] mdev based hardware virtio offloading support Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [PATCH V5 1/6] mdev: class id support Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 16:30 ` Parav Pandit
2019-10-23 16:30 ` [Intel-gfx] " Parav Pandit
2019-10-23 16:30 ` Parav Pandit
2019-10-23 16:30 ` Parav Pandit
2019-10-23 16:30 ` Parav Pandit
2019-10-23 21:42 ` Alex Williamson
2019-10-23 21:42 ` [Intel-gfx] " Alex Williamson
2019-10-23 21:42 ` Alex Williamson
2019-10-23 21:42 ` Alex Williamson
2019-10-24 3:27 ` Jason Wang
2019-10-24 3:27 ` [Intel-gfx] " Jason Wang
2019-10-24 3:27 ` Jason Wang
2019-10-24 3:27 ` Jason Wang
2019-10-24 19:46 ` Alex Williamson
2019-10-24 19:46 ` Alex Williamson
2019-10-24 19:46 ` [Intel-gfx] " Alex Williamson
2019-10-24 19:46 ` Alex Williamson
2019-10-24 19:46 ` Alex Williamson
2019-10-24 20:13 ` Alex Williamson
2019-10-24 20:13 ` [Intel-gfx] " Alex Williamson
2019-10-24 20:13 ` Alex Williamson
2019-10-24 20:13 ` Alex Williamson
2019-10-25 1:42 ` Jason Wang
2019-10-25 1:42 ` Jason Wang
2019-10-25 1:42 ` [Intel-gfx] " Jason Wang
2019-10-25 1:42 ` Jason Wang
2019-10-25 1:42 ` Jason Wang
2019-10-24 3:27 ` Jason Wang
2019-10-23 21:42 ` Alex Williamson
2019-10-23 13:07 ` [PATCH V5 2/6] modpost: add support for mdev class id Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 21:42 ` Alex Williamson
2019-10-23 21:42 ` [Intel-gfx] " Alex Williamson
2019-10-23 21:42 ` Alex Williamson
2019-10-23 21:42 ` Alex Williamson
2019-10-24 3:31 ` Jason Wang
2019-10-24 3:31 ` Jason Wang
2019-10-24 3:31 ` [Intel-gfx] " Jason Wang
2019-10-24 3:31 ` Jason Wang
2019-10-24 3:31 ` Jason Wang
2019-10-24 19:54 ` Alex Williamson
2019-10-24 19:54 ` Alex Williamson
2019-10-24 19:54 ` [Intel-gfx] " Alex Williamson
2019-10-24 19:54 ` Alex Williamson
2019-10-24 19:54 ` Alex Williamson
2019-10-25 1:44 ` Jason Wang
2019-10-25 1:44 ` [Intel-gfx] " Jason Wang
2019-10-25 1:44 ` Jason Wang
2019-10-25 1:44 ` Jason Wang
2019-10-25 1:44 ` Jason Wang
2019-10-23 21:42 ` Alex Williamson
2019-10-23 13:07 ` [PATCH V5 3/6] mdev: introduce device specific ops Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [PATCH V5 4/6] mdev: introduce virtio device and its device ops Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 21:57 ` Alex Williamson
2019-10-23 21:57 ` [Intel-gfx] " Alex Williamson
2019-10-23 21:57 ` Alex Williamson
2019-10-23 21:57 ` Alex Williamson
2019-10-24 3:51 ` Jason Wang
2019-10-24 3:51 ` [Intel-gfx] " Jason Wang
2019-10-24 3:51 ` Jason Wang
2019-10-24 3:51 ` Jason Wang
2019-10-24 20:44 ` Alex Williamson
2019-10-24 20:44 ` Alex Williamson
2019-10-24 20:44 ` [Intel-gfx] " Alex Williamson
2019-10-24 20:44 ` Alex Williamson
2019-10-24 20:44 ` Alex Williamson
2019-10-25 1:54 ` Jason Wang
2019-10-25 1:54 ` Jason Wang
2019-10-25 1:54 ` [Intel-gfx] " Jason Wang
2019-10-25 1:54 ` Jason Wang
2019-10-25 1:54 ` Jason Wang
2019-10-24 3:51 ` Jason Wang
2019-10-29 7:42 ` Zhu Lingshan
2019-10-29 7:42 ` [Intel-gfx] " Zhu Lingshan
2019-10-29 7:42 ` Zhu Lingshan
2019-10-29 7:42 ` Zhu Lingshan
2019-10-29 10:42 ` Jason Wang
2019-10-29 10:42 ` Jason Wang
2019-10-29 10:42 ` [Intel-gfx] " Jason Wang
2019-10-29 10:42 ` Jason Wang
2019-10-30 7:36 ` Zhu Lingshan [this message]
2019-10-30 7:36 ` [Intel-gfx] " Zhu Lingshan
2019-10-30 7:36 ` Zhu Lingshan
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [PATCH V5 5/6] virtio: introduce a mdev based transport Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` [PATCH V5 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-10-23 13:07 ` [Intel-gfx] " Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 13:07 ` Jason Wang
2019-10-23 23:42 ` ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev6) Patchwork
2019-10-23 23:42 ` [Intel-gfx] " Patchwork
2019-10-24 0:10 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-24 0:10 ` [Intel-gfx] " Patchwork
2019-10-24 20:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-24 20:36 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6b2565-b0b6-bf0a-812f-d0bb157be086@linux.intel.com \
--to=lingshan.zhu@linux.intel.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=haotian.wang@sifive.com \
--cc=heiko.carstens@de.ibm.com \
--cc=idos@mellanox.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=parav@mellanox.com \
--cc=pasic@linux.ibm.com \
--cc=rob.miller@broadcom.com \
--cc=rodrigo.vivi@intel.com \
--cc=sebott@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiao.w.wang@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.