From: Lucas De Marchi <lucas.demarchi@intel.com> To: Matt Roper <matthew.d.roper@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS Date: Fri, 25 Oct 2019 16:24:44 -0700 [thread overview] Message-ID: <20191025232444.zervpwg36m3oiwwq@ldmartin-desk1.jf.intel.com> (raw) In-Reply-To: <20191025230623.27829-6-matthew.d.roper@intel.com> On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote: >Our TGL CI platforms are running into cases where aux transactions have >failed to complete or declare a timeout well after the timeout limit >that the hardware is supposed to enforce. From the logs it appears that it's a good idea to copy the relevant part of the log here so the commit message is self-sufficient >these failures arise when aux transactions happen after we've entered >DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather >than PG3 as they were on ICL. > >Signed-off-by: Matt Roper <matthew.d.roper@intel.com> >--- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c >index 6f9e7927e248..707ac110e271 100644 >--- a/drivers/gpu/drm/i915/display/intel_display_power.c >+++ b/drivers/gpu/drm/i915/display/intel_display_power.c >@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv, > TGL_PW_2_POWER_DOMAINS | \ > BIT_ULL(POWER_DOMAIN_MODESET) | \ > BIT_ULL(POWER_DOMAIN_AUX_A) | \ >+ BIT_ULL(POWER_DOMAIN_AUX_B) | \ >+ BIT_ULL(POWER_DOMAIN_AUX_C) | \ > BIT_ULL(POWER_DOMAIN_INIT)) > > #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \ >-- >2.21.0 > >_______________________________________________ >Intel-gfx mailing list >Intel-gfx@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com> To: Matt Roper <matthew.d.roper@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS Date: Fri, 25 Oct 2019 16:24:44 -0700 [thread overview] Message-ID: <20191025232444.zervpwg36m3oiwwq@ldmartin-desk1.jf.intel.com> (raw) Message-ID: <20191025232444.9cv8WSg8LJZeNH0p5q0TBGNryi5sMk9zO7GaTRUHfkY@z> (raw) In-Reply-To: <20191025230623.27829-6-matthew.d.roper@intel.com> On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote: >Our TGL CI platforms are running into cases where aux transactions have >failed to complete or declare a timeout well after the timeout limit >that the hardware is supposed to enforce. From the logs it appears that it's a good idea to copy the relevant part of the log here so the commit message is self-sufficient >these failures arise when aux transactions happen after we've entered >DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather >than PG3 as they were on ICL. > >Signed-off-by: Matt Roper <matthew.d.roper@intel.com> >--- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c >index 6f9e7927e248..707ac110e271 100644 >--- a/drivers/gpu/drm/i915/display/intel_display_power.c >+++ b/drivers/gpu/drm/i915/display/intel_display_power.c >@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv, > TGL_PW_2_POWER_DOMAINS | \ > BIT_ULL(POWER_DOMAIN_MODESET) | \ > BIT_ULL(POWER_DOMAIN_AUX_A) | \ >+ BIT_ULL(POWER_DOMAIN_AUX_B) | \ >+ BIT_ULL(POWER_DOMAIN_AUX_C) | \ > BIT_ULL(POWER_DOMAIN_INIT)) > > #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \ >-- >2.21.0 > >_______________________________________________ >Intel-gfx mailing list >Intel-gfx@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-25 23:24 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-25 23:06 [PATCH 0/5] DP AUX updates Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:06 ` [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:11 ` Lucas De Marchi 2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi 2019-10-25 23:06 ` [PATCH 2/5] drm/i915: Drop unused AUX register offsets Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:11 ` Lucas De Marchi 2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi 2019-10-26 5:12 ` Matt Roper 2019-10-26 5:12 ` [Intel-gfx] " Matt Roper 2019-10-25 23:06 ` [PATCH 3/5] drm/i915: Add missing AUX channel H & I support Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:13 ` Lucas De Marchi 2019-10-25 23:13 ` [Intel-gfx] " Lucas De Marchi 2019-10-28 14:57 ` Matt Roper 2019-10-28 14:57 ` [Intel-gfx] " Matt Roper 2019-10-29 17:59 ` Lucas De Marchi 2019-10-29 17:59 ` [Intel-gfx] " Lucas De Marchi 2019-10-25 23:06 ` [PATCH 4/5] drm/i915: Provide more information on DP AUX failures Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:19 ` Lucas De Marchi 2019-10-25 23:19 ` [Intel-gfx] " Lucas De Marchi 2019-10-25 23:25 ` Matt Roper 2019-10-25 23:25 ` [Intel-gfx] " Matt Roper 2019-10-25 23:32 ` Lucas De Marchi 2019-10-25 23:32 ` [Intel-gfx] " Lucas De Marchi 2019-10-29 17:31 ` [PATCH v2 " Matt Roper 2019-10-29 17:31 ` [Intel-gfx] " Matt Roper 2019-10-29 19:33 ` Lucas De Marchi 2019-10-29 19:33 ` [Intel-gfx] " Lucas De Marchi 2019-10-28 16:43 ` [PATCH " Ville Syrjälä 2019-10-28 16:43 ` [Intel-gfx] " Ville Syrjälä 2019-10-25 23:06 ` [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS Matt Roper 2019-10-25 23:06 ` [Intel-gfx] " Matt Roper 2019-10-25 23:24 ` Lucas De Marchi [this message] 2019-10-25 23:24 ` Lucas De Marchi 2019-10-26 8:57 ` Imre Deak 2019-10-26 8:57 ` [Intel-gfx] " Imre Deak 2019-10-26 1:09 ` ✗ Fi.CI.BUILD: failure for DP AUX updates Patchwork 2019-10-26 1:09 ` [Intel-gfx] " Patchwork 2019-10-26 5:37 ` ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev2) Patchwork 2019-10-26 5:37 ` [Intel-gfx] " Patchwork 2019-10-26 5:57 ` ✗ Fi.CI.BAT: failure " Patchwork 2019-10-26 5:57 ` [Intel-gfx] " Patchwork 2019-10-26 6:26 ` ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3) Patchwork 2019-10-26 6:26 ` [Intel-gfx] " Patchwork 2019-10-26 6:47 ` ✓ Fi.CI.BAT: success " Patchwork 2019-10-26 6:47 ` [Intel-gfx] " Patchwork 2019-10-28 1:02 ` ✓ Fi.CI.IGT: " Patchwork 2019-10-28 1:02 ` [Intel-gfx] " Patchwork 2019-10-29 17:58 ` Matt Roper 2019-10-29 17:58 ` [Intel-gfx] " Matt Roper 2019-10-29 19:56 ` Matt Roper 2019-10-29 19:56 ` [Intel-gfx] " Matt Roper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191025232444.zervpwg36m3oiwwq@ldmartin-desk1.jf.intel.com \ --to=lucas.demarchi@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.d.roper@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.