All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <kuninori.morimoto.gx@renesas.com>,
	<linus.walleij@linaro.org>, <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] ASoC: pcm3168a: Poor man's RST gpio handling
Date: Wed, 13 Nov 2019 14:47:32 +0200	[thread overview]
Message-ID: <20191113124734.27984-1-peter.ujfalusi@ti.com> (raw)

Hi,

when the codec RST input is connected to a GPIO it needs to be pulled high in
order to take the pcm3168a out from reset and to make it respond to register
accesses via i2c.

I have a board where one GPIO line is connected to two pcm3168a codec so runtime
handling of the RST gpio is not possible (one codec would place the other codec
to reset as well).

The only possible solution is to request the gpio with
GPIOD_FLAGS_BIT_NONEXCLUSIVE flag, ask it to be high initially and never touch
it again.

If the optinal GPIO is not described then issue the reset as the driver did.

Regards,
Peter
---
Peter Ujfalusi (2):
  bindings: sound: pcm3168a: Document optional RST gpio
  ASoC: pcm3168a: Add support for optional RST gpio handling

 .../devicetree/bindings/sound/ti,pcm3168a.txt |  7 ++++
 sound/soc/codecs/pcm3168a.c                   | 38 +++++++++++++++++--
 2 files changed, 41 insertions(+), 4 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	kuninori.morimoto.gx@renesas.com, linus.walleij@linaro.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: [alsa-devel] [PATCH 0/2] ASoC: pcm3168a: Poor man's RST gpio handling
Date: Wed, 13 Nov 2019 14:47:32 +0200	[thread overview]
Message-ID: <20191113124734.27984-1-peter.ujfalusi@ti.com> (raw)

Hi,

when the codec RST input is connected to a GPIO it needs to be pulled high in
order to take the pcm3168a out from reset and to make it respond to register
accesses via i2c.

I have a board where one GPIO line is connected to two pcm3168a codec so runtime
handling of the RST gpio is not possible (one codec would place the other codec
to reset as well).

The only possible solution is to request the gpio with
GPIOD_FLAGS_BIT_NONEXCLUSIVE flag, ask it to be high initially and never touch
it again.

If the optinal GPIO is not described then issue the reset as the driver did.

Regards,
Peter
---
Peter Ujfalusi (2):
  bindings: sound: pcm3168a: Document optional RST gpio
  ASoC: pcm3168a: Add support for optional RST gpio handling

 .../devicetree/bindings/sound/ti,pcm3168a.txt |  7 ++++
 sound/soc/codecs/pcm3168a.c                   | 38 +++++++++++++++++--
 2 files changed, 41 insertions(+), 4 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

             reply	other threads:[~2019-11-13 12:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 12:47 Peter Ujfalusi [this message]
2019-11-13 12:47 ` [alsa-devel] [PATCH 0/2] ASoC: pcm3168a: Poor man's RST gpio handling Peter Ujfalusi
2019-11-13 12:47 ` [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio Peter Ujfalusi
2019-11-13 12:47   ` [alsa-devel] " Peter Ujfalusi
2019-11-18 13:08   ` Mark Brown
2019-11-18 13:08     ` [alsa-devel] " Mark Brown
2019-11-18 14:46     ` Peter Ujfalusi
2019-11-18 14:46       ` [alsa-devel] " Peter Ujfalusi
2019-11-18 16:01       ` Mark Brown
2019-11-18 16:01         ` [alsa-devel] " Mark Brown
2019-11-18 13:09   ` Applied "ASoC: pcm3168a: Document optional RST gpio" to the asoc tree Mark Brown
2019-11-18 13:09     ` [alsa-devel] " Mark Brown
2019-11-18 21:32   ` [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio Rob Herring
2019-11-18 21:32     ` [alsa-devel] " Rob Herring
2019-11-13 12:47 ` [PATCH 2/2] ASoC: pcm3168a: Add support for optional RST gpio handling Peter Ujfalusi
2019-11-13 12:47   ` [alsa-devel] " Peter Ujfalusi
2019-11-18 13:09   ` Applied "ASoC: pcm3168a: Add support for optional RST gpio handling" to the asoc tree Mark Brown
2019-11-18 13:09     ` [alsa-devel] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113124734.27984-1-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.